summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix a memory leak on agent authentication cancellationgvariant-auditMiloslav Trmač2017-06-211-1/+6
| | | | | | | | (This is cancellation by the daemon, possibly requested by the client, not by the agent.) https://bugs.freedesktop.org/show_bug.cgi?id=99741 Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* Fix a memory leak per agent authenticationMiloslav Trmač2017-06-211-3/+4
| | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=99741 Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* Fix error handling in polkit_authority_enumerate_temporary_authorizations_finishMiloslav Trmač2017-06-211-1/+3
| | | | | | | | Fix memory leaks, and don't return a pointer to freed memory. https://bugs.freedesktop.org/show_bug.cgi?id=99741 Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* Fix memory leaks in server_handle_*_temporary_authorizationsMiloslav Trmač2017-06-211-0/+2
| | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=99741 Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* Fix a memory leak in server_handle_authentication_agent_response{,2}Miloslav Trmač2017-06-211-0/+2
| | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=99741 Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* Fix a memory leak in server_handle_unregister_authentication_agentMiloslav Trmač2017-06-211-0/+1
| | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=99741 Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* Fix a memory leak in server_handle_register_authentication_agent_with_optionsMiloslav Trmač2017-06-211-0/+1
| | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=99741 Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* Fix a memory leak on an error path of lookup_asv (twice)Miloslav Trmač2017-06-212-0/+2
| | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=99741 Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* Simplify GVariant reference countingMiloslav Trmač2017-06-219-114/+49
| | | | | | | | | | | | For (non-public-API) *_to_gvariant, explicitly document that they return a floating value, and rely on it in callers to avoid a variable/sink/unref combo. This should not change behavior. https://bugs.freedesktop.org/show_bug.cgi?id=99741 Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* Add hr.pomuzena2017-04-242-0/+205
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=100764
* polkitpermission: Fix a memory leak on authority changesRui Matos2017-04-041-0/+1
| | | | | | Signed-off-by: Rui Matos <tiagomatos@gmail.com> https://bugs.freedesktop.org/show_bug.cgi?id=99741
* Add Indonesian translation by Andika TriwidadaMiloslav Trmač2017-02-132-0/+206
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=99790
* build: Pull in GCC warning infra from ostreeColin Walters2016-12-127-70/+318
| | | | | | | | | I'm trying to keep a relatively standard set around, and the code there is cleaner than what we had before. Also, injecting as WARN_CFLAGS rather than changing CFLAGS during autoconf avoids any surprises from new warnings breaking autoconf checks.
* Replace autocompartmentJeremy Linton2016-12-121-7/+8
| | | | | | | | The autocompartment definition in the previous patches seems to be fine, but constructing the autocompartment for the lifetime of the global object is probably a better way to handle this. Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
* Fix warnings caused by building with C++Jeremy Linton2016-12-122-70/+70
| | | | | | | | | C++ needs explicit casts for many pointer type conversions For example char * to void * should have a cast. Fix a number of these cases. Also, correct a white space indentation error left in the last patch for review clarity. Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
* Switch to hard requiring mozjs24Jeremy Linton2016-12-122-63/+25
| | | | | | | | | | | Remove mozjs185 and mozjs17 from autoconf and replace them with mozjs24. Now that polkitbackendjsauthority is compiling in C++ mode and the autoconf supports mozjs24, update the module so that it builds with mozjs24. Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
* change mozjs interface module to c++Jeremy Linton2016-12-124-1/+12
| | | | | | | | The JSAPI is now a full C++ interface. Convert the polkit to JavaScript interface module to C++ compilation in order to support newer versions of spidermonkey. Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
* gettext: switch to default-translate "no"Peter Hutterer2016-11-081-2/+3
| | | | | | | | | | | | | | | | | | | | The default appears to be to translate all entries. This rule never takes effect, the path to /action/message and /action/description is wrong (/action is not a root node). Since we wanted them to be translated, it doesn't matter. But it also translates all other tags (vendor, allow_any, etc.) and that causes polkit to be unhappy, it can't handle the various language versions of "no" ** (polkitd:27434): WARNING **: Unknown PolkitImplicitAuthorization string 'tidak' Switch to a default of "no" and explicitly include the message and description strings to be translated. The patch was modified for PolicyKit by Ondrej Holy <oholy@redhat.com>. https://bugs.freedesktop.org/show_bug.cgi?id=98366
* Add Slovak translation by Dusan Kazik <prescott66@gmail.com>Miloslav Trmač2016-08-092-0/+212
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=97238
* Add gettext support for .policy filesMatthias Clasen2016-07-153-0/+18
| | | | | | | gettext can extract strings from and merge them back into xml file formats, with the help of .its files. https://bugs.freedesktop.org/show_bug.cgi?id=96940
* data: Set GIO_USE_VFS=local in the environmentPhilip Withnall2016-06-065-0/+19
| | | | | | | | | | | | There is no need for polkit to ever use GVFS to load files from non-local sources, so it's best to avoid loading GVFS code, and to just rely on the local implementation in GIO instead. This reduces the attack surface of polkit. Implemented for the daemon, pkaction, pkcheck, pkexec and pkttyagent, because none of them need remote file access. https://bugs.freedesktop.org/show_bug.cgi?id=95487
* polkit: Add g_autoptr() support for GObject-derived polkit typesPhilip Withnall2016-05-041-0/+17
| | | | | | | | | | Add G_DEFINE_AUTOPTR_CLEANUP_FUNC calls to polkittypes.h, so that g_autoptr() can be used with polkit objects. This is conditional on GLib ≥ 2.44.0 being available. It does not bump polkit’s dependency on GLib. https://bugs.freedesktop.org/show_bug.cgi?id=95065
* Added Turkish translationMuhammet Kara2016-04-152-0/+212
|
* Remove polkitbackendconfigsource.[ch]Miloslav Trmač2016-03-234-665/+0
| | | | | | | It is no longer used since the move to JavaScript, and we don't want to maintain it unnecessarily. https://bugs.freedesktop.org/show_bug.cgi?id=94670
* Fix a memory leak of PolkitAgentListener's Server objectMiloslav Trmač2016-03-121-0/+2
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=94506
* polkitagent: Fix access after dereference on hashtableStef Walter2016-03-121-3/+4
| | | | | | | | | If an authentication is going on while the agent listener is going away, then we access memory that has been freed. g_hash_table_lookup_node: assertion failed: (hash_table->ref_count > 0)' https://bugs.freedesktop.org/show_bug.cgi?id=94486
* Add initial Hungarian translation, and add hu to LINGUASGabor Kelemen2016-01-252-0/+221
|
* Add zh_CN translationMingye Wang (Arthur2e5)2016-01-252-0/+197
|
* Add Swedish translationAnders Jonsson2015-11-212-0/+208
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=93028
* Refactor send_to_helper usageDariusz Gadomski2015-11-181-55/+26
| | | | | | | There were duplicated pieces of code detecting EOLs and escaping the code. Those actions has been delegated to already-existing send_to_helper function. https://bugs.freedesktop.org/show_bug.cgi?id=92886
* Fix multi-line pam text info.Dariusz Gadomski2015-11-181-4/+9
| | | | | | | | | There are pam modules (e.g. pam_vas) that may attempt to display multi-line PAM_TEXT_INFO messages. Polkit was interpreting the lines after the first one as a separate message that was not recognized causing the authorization to fail. Escaping these strings and unescaping them fixes the issue. https://bugs.freedesktop.org/show_bug.cgi?id=92886
* Add German translationChristian Kirbach2015-11-182-0/+213
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=93000
* Add Ukrainian translationYuri Chornoivan2015-11-162-0/+211
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=92960
* pkcheck: fix man typosAnders Jonsson2015-10-211-5/+5
| | | https://bugs.freedesktop.org/show_bug.cgi?id=92566
* Add Brazilian Portuguese translationRafael Fontenelle2015-10-072-0/+210
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=92321
* Fix abnomal formatting of authentication header linesenkore2015-10-041-4/+4
|
* Add support for NetBSDOBATA Akio2015-10-013-10/+46
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=92046
* Add Polish translationPiotr Drąg2015-08-282-0/+207
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=26355
* Consistently use HAVE_NETGROUP_H instead of HAVE_OPENBSDMiloslav Trmač2015-07-202-2/+2
| | | | | Cleanup for https://bugs.freedesktop.org/show_bug.cgi?id=75187
* Add support for OpenBSDAntoine Jacoutot2015-07-206-8/+234
| | | | | | | | | - OpenBSD does not use PAM nor SHADOW but bsd_auth(3) for authentication - get_kinfo_proc(): adapt FreeBSD code to OpenBSD - OpenBSD, get/setnetgrent are defined in netgroup.h and getnetgrent(3) takes a const char https://bugs.freedesktop.org/show_bug.cgi?id=75187
* Post-release version bump to 0.114Miloslav Trmač2015-07-022-1/+31
|
* Update NEWS for release.0.113Miloslav Trmač2015-07-021-3/+90
|
* README: Note to send security reports via DBus's mechanismColin Walters2015-06-231-1/+17
| | | | This avoids duplicating effort.
* Fix use-after-free in polkitagentsession.cMiloslav Trmač2015-06-231-1/+2
| | | | | | | | | | PolkitAgentTextListener's "completed" handler drops the last reference to the session; in fact this is explicitly recommended in the signal's documentation. So we must not access any members of session after emitting the signal. Found while dealing with https://bugs.freedesktop.org/show_bug.cgi?id=69501
* CVE-2015-3255 Fix GHashTable usage.Miloslav Trmač2015-06-231-5/+3
| | | | | | | | | | | | | | Don't assume that the hash table with free both the key and the value at the same time, supply proper deallocation functions for the key and value separately. Then drop ParsedAction::action_id which is no longer used for anything. https://bugs.freedesktop.org/show_bug.cgi?id=69501 and https://bugs.freedesktop.org/show_bug.cgi?id=83590 CVE: CVE-2015-3255
* Fix spurious timeout exceptions on GCMiloslav Trmač2015-06-191-0/+23
| | | | | | | | | | | | | | | The JS “Operation callback” can be called by the runtime for other reasons, not only when we trigger it by a timeout—notably as part of GC. So, make sure to only raise an exception if there actually was a timeout. Adding a whole extra mutex to protect a single boolean is somewhat of an overkill, but better than worrying about “subtle bugs and occasionally undefined behaviour” the g_atomic_* API is warning about. https://bugs.freedesktop.org/show_bug.cgi?id=69501 also https://bugs.freedesktop.org/show_bug.cgi?id=77524
* Clear the JS operation callback before invoking JS in the callbackMiloslav Trmač2015-06-191-0/+2
| | | | | | | | Setting the callback to NULL is required by https://developer.mozilla.org/en-US/docs/SpiderMonkey/JSAPI_Reference/JS_SetOperationCallback to avoid the possibility of recursion. https://bugs.freedesktop.org/show_bug.cgi?id=69501
* Prevent builds against SpiderMonkey with exact stack rootingMiloslav Trmač2015-06-191-0/+7
| | | | | | | | | | | | | “Exact stack rooting” means that every on-stack pointer to a JavaScript value needs to be registered with the runtime. The current code doesn't do this, so it is not safe to use against a runtime with this configuration. Luckily this configuration is not default. See https://developer.mozilla.org/en-US/docs/SpiderMonkey/Internals/GC/Exact_Stack_Rooting and other pages in the wiki for what the conversion would require. https://bugs.freedesktop.org/show_bug.cgi?id=69501
* Register heap-based JSObject pointers to GCMiloslav Trmač2015-06-191-0/+7
| | | | | | | This is necessary so that the GC can move the objects (though I haven't so far encountered this in testing). https://bugs.freedesktop.org/show_bug.cgi?id=69501
* Wrap all JS usage within “requests”Miloslav Trmač2015-06-191-2/+27
| | | | | | | | | Required by https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_THREADSAFE ; lack of requests causes assertion failures with a debug build of mozjs17. https://bugs.freedesktop.org/show_bug.cgi?id=69501