summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorElliott Sales de Andrade <qulogic@pidgin.im>2019-02-07 05:17:39 -0500
committerElliott Sales de Andrade <qulogic@pidgin.im>2019-02-07 05:17:39 -0500
commit903bb720ead7d7ba17419f0f2ac08e1d8f57162a (patch)
treedb4f7fda417f23a622f96683b6c3a2c435b1bfc3
parentba86a963be87fc19c851b7cbdab76817e1f17af2 (diff)
downloadpidgin-903bb720ead7d7ba17419f0f2ac08e1d8f57162a.tar.gz
Use g_value_dup_string where needed.
-rw-r--r--libpurple/account.c2
-rw-r--r--libpurple/connection.c2
-rw-r--r--libpurple/conversation.c4
-rw-r--r--libpurple/conversationtypes.c4
-rw-r--r--libpurple/message.c8
-rw-r--r--libpurple/plugins.c2
-rw-r--r--libpurple/whiteboard.c2
7 files changed, 12 insertions, 12 deletions
diff --git a/libpurple/account.c b/libpurple/account.c
index 83b77e599b..76e5dda5a4 100644
--- a/libpurple/account.c
+++ b/libpurple/account.c
@@ -2469,7 +2469,7 @@ status_attribute_to_xmlnode(const PurpleStatus *status, const PurpleStatusType *
const char *default_string_value = g_value_get_string(default_value);
if (purple_strequal(string_value, default_string_value))
return NULL;
- value = g_strdup(g_value_get_string(attr_value));
+ value = g_value_dup_string(attr_value);
}
else if (attr_type == G_TYPE_INT)
{
diff --git a/libpurple/connection.c b/libpurple/connection.c
index f71cf59f55..5c638c3711 100644
--- a/libpurple/connection.c
+++ b/libpurple/connection.c
@@ -734,7 +734,7 @@ purple_connection_set_property(GObject *obj, guint param_id, const GValue *value
break;
case PROP_PASSWORD:
g_free(priv->password);
- priv->password = g_strdup(g_value_get_string(value));
+ priv->password = g_value_dup_string(value);
break;
case PROP_DISPLAY_NAME:
purple_connection_set_display_name(gc, g_value_get_string(value));
diff --git a/libpurple/conversation.c b/libpurple/conversation.c
index 40ebcb72b3..cc46d7705b 100644
--- a/libpurple/conversation.c
+++ b/libpurple/conversation.c
@@ -938,11 +938,11 @@ purple_conversation_set_property(GObject *obj, guint param_id, const GValue *val
break;
case PROP_NAME:
g_free(priv->name);
- priv->name = g_strdup(g_value_get_string(value));
+ priv->name = g_value_dup_string(value);
break;
case PROP_TITLE:
g_free(priv->title);
- priv->title = g_strdup(g_value_get_string(value));
+ priv->title = g_value_dup_string(value);
break;
case PROP_LOGGING:
purple_conversation_set_logging(conv, g_value_get_boolean(value));
diff --git a/libpurple/conversationtypes.c b/libpurple/conversationtypes.c
index 7f6017e029..09e09d1545 100644
--- a/libpurple/conversationtypes.c
+++ b/libpurple/conversationtypes.c
@@ -1743,11 +1743,11 @@ purple_chat_user_set_property(GObject *obj, guint param_id, const GValue *value,
break;
case CU_PROP_NAME:
g_free(priv->name);
- priv->name = g_strdup(g_value_get_string(value));
+ priv->name = g_value_dup_string(value);
break;
case CU_PROP_ALIAS:
g_free(priv->alias);
- priv->alias = g_strdup(g_value_get_string(value));
+ priv->alias = g_value_dup_string(value);
break;
case CU_PROP_FLAGS:
priv->flags = g_value_get_flags(value);
diff --git a/libpurple/message.c b/libpurple/message.c
index cc344d0ff7..820f4b850b 100644
--- a/libpurple/message.c
+++ b/libpurple/message.c
@@ -304,19 +304,19 @@ purple_message_set_property(GObject *object, guint par_id, const GValue *value,
switch (par_id) {
case PROP_AUTHOR:
g_free(priv->author);
- priv->author = g_strdup(g_value_get_string(value));
+ priv->author = g_value_dup_string(value);
break;
case PROP_AUTHOR_ALIAS:
g_free(priv->author_alias);
- priv->author_alias = g_strdup(g_value_get_string(value));
+ priv->author_alias = g_value_dup_string(value);
break;
case PROP_RECIPIENT:
g_free(priv->recipient);
- priv->recipient = g_strdup(g_value_get_string(value));
+ priv->recipient = g_value_dup_string(value);
break;
case PROP_CONTENTS:
g_free(priv->contents);
- priv->contents = g_strdup(g_value_get_string(value));
+ priv->contents = g_value_dup_string(value);
break;
case PROP_TIME:
priv->msgtime = g_value_get_uint64(value);
diff --git a/libpurple/plugins.c b/libpurple/plugins.c
index 11124834cd..47ab841962 100644
--- a/libpurple/plugins.c
+++ b/libpurple/plugins.c
@@ -334,7 +334,7 @@ purple_plugin_info_set_property(GObject *obj, guint param_id, const GValue *valu
switch (param_id) {
case PROP_UI_REQUIREMENT:
- priv->ui_requirement = g_strdup(g_value_get_string(value));
+ priv->ui_requirement = g_value_dup_string(value);
break;
case PROP_ACTIONS_CB:
priv->actions_cb = g_value_get_pointer(value);
diff --git a/libpurple/whiteboard.c b/libpurple/whiteboard.c
index 6d6a6465ce..64ac003d6a 100644
--- a/libpurple/whiteboard.c
+++ b/libpurple/whiteboard.c
@@ -381,7 +381,7 @@ purple_whiteboard_set_property(GObject *obj, guint param_id, const GValue *value
priv->account = g_value_get_object(value);
break;
case PROP_WHO:
- priv->who = g_strdup(g_value_get_string(value));
+ priv->who = g_value_dup_string(value);
break;
case PROP_DRAW_LIST:
purple_whiteboard_set_draw_list(wb, g_value_get_pointer(value));