| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \
| |/ / |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Put the usage message near the top of the script,
into a separate function.
Closes GH-5558.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I used php-cs-fixer to do the cs fixes. The configuration I used is
posted below. The reason I disabled some of the rules is because they
create too much noise and would make it difficult to review. But please
feel free to close this PR and run the php-cs-fixer yourself.
<?php
$config = PhpCsFixer\Config::create();
$config->setRiskyAllowed(false);
$config->setRules([
'@PSR2' => true,
'@Symfony' => true,
'array_syntax' => false,
'binary_operator_spaces' => false,
'blank_line_before_statement' => false,
'concat_space' => false,
'increment_style' => false,
'phpdoc_align' => false,
'single_quote' => false,
'trailing_comma_in_multiline_array' => false,
'unary_operator_spaces' => false,
'yoda_style' => false,
]);
$finder = PhpCsFixer\Finder::create();
$finder->in(getcwd());
$finder->exclude('Zend');
$finder->exclude('build');
$finder->exclude('ext');
$finder->exclude('pear');
$finder->exclude('sapi');
$finder->exclude('scripts');
$finder->exclude('win32');
$config->setFinder($finder);
return $config;
Closes GH-5557.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The FILE_BINARY (and FILE_TEXT) constants are not really valid or useful
constants. It looks like they were added in 5.2.7 and have "no effect,
and are only available for forward compatibility."
See: https://www.php.net/manual/en/filesystem.constants.php
The default value of the file_put_contents() flags parameter is 0 and
FILE_BINARY is set to 0, so removing it doesn't change functionality.
P.S. Maybe those constants should be deprecated or removed in 8.0.
Closes GH-5556.
|
| | |
| | |
| | |
| | |
| | | |
This reverts commit 5eb4ab07f27c82336d337afa01d02a7bf574adaf.
The temporary hack has served its purpose.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Pass worker ID to clean scripts
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
On Windows, reusing/sharing of OPcache instances with different
configuration is not necessarily supported, so we have to make that it
does not happen for the clean scripts, by using `$orig_ini_settings`
instead of `$clean_params`.
|
| | |
| | |
| | |
| | |
| | |
| | | |
This is a hack to investigate why mysqli_insert_packet_overflow.phpt
intermittently fails on AppVeyor, and will be reverted in due time.
See <https://github.com/php/php-src/pull/5447#issuecomment-620508790>.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Flexible heredoc syntax is only available since PHP 7.3.
Closes GH-5444.
|
| | | |
|
| | |
| | |
| | |
| | | |
Make sure we don't accidentially add tests depending on short tags.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
var_dump() is debugging functionality, so it should print
floating-point numbers accurately. We do this by switching
to serialize_precision, which (by default) will print with
as much precision as necessary to preserve the exact value
of the float.
This also affects debug_zval_dump().
Closes GH-5172.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Create a new console for each test worker on Windows
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The primary motivation to have each test worker running its own console
is to allow the windows_mb_path tests to run in parallel. A nice side
effect is that this also prevents changing the code page of the
tester's console window (which can even cause its font to be changed).
To be able to do so, we introduce the `create_new_console` option for
`proc_open()`, which might occasionally be useful for other purposes
than testing.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Apply tidy formatting
|
| | |
| | |
| | |
| | | |
Mostly reindent PHP scripts to spaces.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Add WHITESPACE_SENSITIVE run-tests section
|
| | |
| | |
| | |
| | |
| | | |
This is used to indicate that the test should not be changed by
automated formatting changes.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Don't use CRLF when generating diffs
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- When valgrind is used, communication overhead is relatively small,
so just use a batch size of 1.
- If this is running a small enough number of tests,
reduce the batch size to give batches to more workers.
(Previously, if there were 90 tests and -j8,
only 3 of 8 workers would get a batch of size 32 or less.
After this change, the batch size is 12 or less)
Closes GH-5098
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If there's only 2 files to test, then only start 2 workers instead of N.
If there's only 1 file, then avoid parallelism entirely.
A separate option such as `--force-parallel` could be added
if this turns out to be something developers would want to do
when debugging test failures.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Avoid some @count() suppressions in run-tests.php
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently mail related tests are split for *nix and Windows (if there
are even Windows versions). The basic difference is that the *nix
variants set the INI directive sendmail_path to just write the email to
disk, while the Windows tests use ext/imap. The latter tests are way
more verbose, and such duplicated tests are generally a pain point.
Furthermore, the Windows tests are much slower, and could not be run
without ext/imap being available.
We therefore introduce a small fakemail application, which basically
works like `tee <path> >/dev/null`, and which will be shipped with the
Windows tests packs. fakemail.exe would also need to be added to the
PHP binary SDK, so these tests could be run during developments.
To cater to the remaining differences, we also introduce support for
`{MAIL:<path>}` placeholders in the INI sections to run-tests.php. How
to use this can be seen in mail_basic.phpt, which is currently the only
modified test case, because these tests are yet supposed to fail on
Windows, due to the missing fakemail.exe in the PHP SDK.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Set zend.exception_ignore_args=0 in run-tests.php
|
| | |
| | |
| | |
| | | |
Any existing tests are going to be written under this assumption...
|
|\ \ \
| |/ / |
|
| | |
| | |
| | |
| | |
| | |
| | | |
The default PHP executable was not set when no args were provided.
Closes GH-4894.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Avoid code duplication
Closes GH-4866.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Now that we're displaying errors in skipif, suppress this particular
category. Otherwise we get warnings in the SKIPIF of tests with
EXTENSION where the extension does not exist, and there's no way
to suppress them.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Bail out if JUNIT is not enabled
|
| | |
| | |
| | |
| | |
| | |
| | | |
Otherwise we would try to access an array element of `false`, which
issues a notice as of PHP 7.4.0. This would happen, for instance, for
bug63447_001.phpt if CGI is not available.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Delete temporary .post files of run-tests.php
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Commit 5649267[1] changed run-tests.php to only delete .post files for
passing tests. However, that code wouldn't be exercised at all, since
`run_test()` already returned, so we move the deletion upwards.
[1]
<http://git.php.net/?p=php-src.git;a=commit;h=5649267b257c78e46a934434c0bff894e0b5b694>
|
| | |
| | |
| | |
| | | |
We don't want to treat a PHP "Warning: " as a run-tests warn.
|
| | |
| | |
| | |
| | |
| | |
| | | |
SKIPIF section should either output nothing, or start with a
supported keyword like "skip". Mark all tests that don't do so as
BORKED.
|
|/ /
| |
| |
| | |
Closes GH-4732.
|
| |
| |
| |
| |
| | |
These were being reported under the wrong name ... which means that
they don't show up as failures on azure :(
|
| |
| |
| |
| |
| |
| |
| |
| | |
Due to a typo in commit e1151c9[1], succeeding XFAIL test without an
EXPECTF or EXPECTREGEX section have been reported reported as passed
instead of warned.
[1] <http://git.php.net/?p=php-src.git;a=commit;h=e1151c9549cf5a7235c1609019f79bbb1bbcdbea>
|
|\ \
| |/
| |
| |
| | |
* PHP-7.3:
Remove .post files only for passing tests
|
| |\
| | |
| | |
| | |
| | | |
* PHP-7.2:
Remove .post files only for passing tests
|
| | |
| | |
| | |
| | | |
This allows the sh script for failing tests with --POST-- to work
|
| | |
| | |
| | |
| | |
| | | |
It does nothing on 7.3, but this makes it easier to write tests in
3rd party extensions.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- when $status is boolean, E_NOTICE appears and tests fail
- opcache is never enabled on these tests anyway.
- Add opcache.revalidate_freq=0 to testing script
Instead of checking this in the tests files it can be used directly in
the main testing script. Also this fixes failed tests.
- Use opcache_invalidate() instead of sleep() delay in some tests. Some
delays are still used since the opcache_invalidate seems to be buggy
and not working as expected.
Closes GH-4392
|
| | |
| | |
| | |
| | | |
RFC: https://wiki.php.net/rfc/deprecate_curly_braces_array_access
|