summaryrefslogtreecommitdiff
path: root/ext/simplexml
Commit message (Collapse)AuthorAgeFilesLines
* Fixes bug #75871 Use pkg-config for libxml2 if availablePedro Magalhães2018-02-081-1/+1
|
* year++Xinchen Hui2018-01-025-5/+5
|
* Merge branch 'PHP-7.0' into PHP-7.1Anatol Belski2017-09-111-3/+1
|\ | | | | | | | | * PHP-7.0: Fix test compat with libxml2 2.9.5
| * Fix test compat with libxml2 2.9.5Anatol Belski2017-09-111-3/+1
| | | | | | | | One warning disappeared, but the flow is still valid.
* | Skip 64-bit related testDmitry Stogov2017-08-151-0/+1
| |
* | Merge branch 'PHP-7.0' into PHP-7.1Xinchen Hui2017-07-212-6/+22
|\ \ | |/ | | | | | | * PHP-7.0: Fixed bug #74950 (nullpointer deref in simplexml_element_getDocNamespaces)
| * Fixed bug #74950 (nullpointer deref in simplexml_element_getDocNamespaces)Xinchen Hui2017-07-212-6/+22
| |
| * Update copyright headers to 2017Sammy Kaye Powers2017-01-045-5/+5
| |
| * fix typoAnatol Belski2016-10-121-1/+1
| |
| * Fix bug #73293 - NULL pointer dereference in SimpleXMLElement::asXML()Stanislav Malyshev2016-10-121-3/+16
| | | | | | | | (cherry picked from commit 96a8cf8e1b5dc1b0c708bb5574e0d6727cc56d9e)
* | Update copyright headers to 2017Sammy Kaye Powers2017-01-045-5/+5
| |
* | fix typoAnatol Belski2016-10-141-1/+1
| | | | | | | | (cherry picked from commit efc1f33b58b0936539ea6ca1de345bd83c7e8f26)
* | Fix bug #73293 - NULL pointer dereference in SimpleXMLElement::asXML()Stanislav Malyshev2016-10-141-3/+16
| | | | | | | | | | (cherry picked from commit 96a8cf8e1b5dc1b0c708bb5574e0d6727cc56d9e) (cherry picked from commit 4ef79370a82d6c92f4ea0cd462274ba24e007f56)
* | Merge branch 'PHP-7.0' into PHP-7.1Christoph M. Becker2016-09-091-2/+0
|\ \ | |/
| * Merge branch 'PHP-5.6' into PHP-7.0Christoph M. Becker2016-09-091-2/+0
| |\
| | * Remove ignored --FAIL-- section from test caseChristoph M. Becker2016-09-091-2/+0
| | | | | | | | | | | | This is just confusing.
* | | Merge branch 'PHP-7.0' into PHP-7.1Nikita Popov2016-08-303-13/+58
|\ \ \ | |/ /
| * | Fix bug #72957Nikita Popov2016-08-302-12/+22
| | |
| * | Followup for bug #72971Nikita Popov2016-08-302-1/+36
| | | | | | | | | | | | | | | | | | Property writes did not respect the namespace either. This is an incomplete fix in that it only handles the case where an existing child element is modified, not when a new one is created.
* | | Merge branch 'PHP-7.0' into PHP-7.1Nikita Popov2016-08-302-2/+23
|\ \ \ | |/ /
| * | Fix bug #72971Nikita Popov2016-08-302-2/+23
| | |
* | | Avoid uncollectable cycle in sxe_property_get_adrNikita Popov2016-07-161-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The code was storing the created object in a property on the created object, creating a trivial cycle. This cycle cannot be collected (even if sxe->tmp is exposed via get_gc), because it is never rooted (and we cannot safely manually root it). Change the code to store the created object on the parent node instead. The only reason this is not showing up as a leak is that sxe->tmp is dtor'ed in the dtor handler, which means that these objects do get collected on shutdown -- but never earlier.
* | | Remove unnecessary use of sxe->tmpNikita Popov2016-07-161-5/+1
| | |
* | | Merge branch 'PHP-7.0'Xinchen Hui2016-07-132-26/+81
|\ \ \ | |/ / | | | | | | | | | * PHP-7.0: Fixed bug #72588 (Using global var doesn't work while accessing SimpleXML element)
| * | Fixed bug #72588 (Using global var doesn't work while accessing SimpleXML ↵Xinchen Hui2016-07-132-26/+81
| | | | | | | | | | | | element)
* | | Merge branch 'throw-error-in-extensions'Aaron Piotrowski2016-07-052-8/+14
|\ \ \
| * | | Replace zend_ce_error with NULL and replace more E_ERROR with thrown ErrorAaron Piotrowski2016-06-131-5/+5
| | | |
| * | | Merge branch 'master' into throw-error-in-extensionsAaron Piotrowski2016-06-107-23/+48
| |\ \ \
| * | | | Update memory freeing and other issues, revert some changesAaron Piotrowski2015-07-051-2/+5
| | | | |
| * | | | Convert E_ERROR to thrown Error in extensionsAaron Piotrowski2015-07-052-6/+9
| | | | |
* | | | | Fixed compilation warningsDmitry Stogov2016-06-222-2/+5
| | | | |
* | | | | Added ZEND_ATTRIBUTE_FORMAT to some middind functions.Dmitry Stogov2016-06-211-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | "%p" replaced by ZEND_LONG_FMT to avoid compilation warnings. Fixed most incorrect use cases of format specifiers.
* | | | | Fixed the UTF-8 and long path support in the streams on Windows.Anatol Belski2016-06-202-0/+60
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since long the default PHP charset is UTF-8, however the Windows part is out of step with this important point. The current implementation in PHP doesn't technically permit to handle UTF-8 filepath and several other things. Till now, only the ANSI compatible APIs are being used. Here is more about it https://msdn.microsoft.com/en-us/library/windows/desktop/dd317752%28v=vs.85%29.aspx The patch fixes not only issues with multibyte filenames under incompatible codepages, but indirectly also issues with some other multibyte encodings like BIG5, Shift-JIS, etc. by providing a clean way to access filenames in UTF-8. Below is a small list of issues from the bug tracker, that are getting fixed: https://bugs.php.net/63401 https://bugs.php.net/41199 https://bugs.php.net/50203 https://bugs.php.net/71509 https://bugs.php.net/64699 https://bugs.php.net/64506 https://bugs.php.net/30195 https://bugs.php.net/65358 https://bugs.php.net/61315 https://bugs.php.net/70943 https://bugs.php.net/70903 https://bugs.php.net/63593 https://bugs.php.net/54977 https://bugs.php.net/54028 https://bugs.php.net/43148 https://bugs.php.net/30730 https://bugs.php.net/33350 https://bugs.php.net/35300 https://bugs.php.net/46990 https://bugs.php.net/61309 https://bugs.php.net/69333 https://bugs.php.net/45517 https://bugs.php.net/70551 https://bugs.php.net/50197 https://bugs.php.net/72200 https://bugs.php.net/37672 Yet more related tickets can for sure be found - on bugs.php.net, Stackoverflow and Github. Some of the bugs are pretty recent, some descend to early 2000th, but the user comments in there last even till today. Just for example, bug #30195 was opened in 2004, the latest comment in there was made in 2014. It is certain, that these bugs descend not only to pure PHP use cases, but get also redirected from the popular PHP based projects. Given the modern systems (and those supported by PHP) are always based on NTFS, there is no excuse to keep these issues unresolved. The internalization approach on Windows is in many ways different from UNIX and Linux, while it supports and is based on Unicode. It depends on the current system code page, APIs used and exact kind how the binary was compiled The locale doesn't affect the way Unicode or ANSI API work. PHP in particular is being compiled without _UNICODE defined and this is conditioned by the way we handle strings. Here is more about it https://msdn.microsoft.com/en-us/library/tsbaswba.aspx However, with any system code page ANSI functions automatically convert paths to UTF-16. Paths in some encodings incompatible with the current system code page, won't work correctly with ANSI APIs. PHP till now only uses the ANSI Windows APIs. For example, on a system with the current code page 1252, the paths in cp1252 are supported and transparently converted to UTF-16 by the ANSI functions. Once one wants to handle a filepath encoded with cp932 on that particular system, an ANSI or a POSIX compatible function used in PHP will produce an erroneous result. When trying to convert that cp932 path to UTF-8 and passing to the ANSI functions, an ANSI function would likely interpret the UTF-8 string as some string in the current code page and create a filepath that represents every single byte of the UTF-8 string. These behaviors are not only broken but also disregard the documented INI settings. This patch solves the issies with the multibyte paths on Windows by intelligently enforcing the usage of the Unicode aware APIs. For functions expect Unicode (fe CreateFileW, FindFirstFileW, etc.), arguments will be converted to UTF-16 wide chars. For functions returning Unicode aware data (fe GetCurrentDirectoryW, etc.), resulting wide string is converted back to char's depending on the current PHP charset settings, either to the current ANSI codepage (this is the behavior prior to this patch) or to UTF-8 (the default behavior). In a particular case, users might have to explicitly set internal_encoding or default_charset, if filenames in ANSI codepage are necessary. Current tests show no regressions and witness that this will be an exotic case, the current default UTF-8 encoding is compatible with any supported system. The dependency libraries are long switching to Unicode APIs, so some tests were also added for extensions not directly related to streams. At large, the patch brings over 150 related tests into the core. Those target and was run on various environments with European, Asian, etc. codepages. General PHP frameworks was tested and showed no regressions. The impact on the current C code base is low, the most places affected are the Windows only places in the three files tsrm_win32.c, zend_virtual_cwd.c and plain_wrapper.c. The actual implementation of the most of the wide char supporting functionality is in win32/ioutil.* and win32/codepage.*, several low level functionsare extended in place to avoid reimplementation for now. No performance impact was sighted. As previously mentioned, the ANSI APIs used prior the patch perform Unicode conversions internally. Using the Unicode APIs directly while doing custom conversions just retains the status quo. The ways to optimize it are open (fe. by implementing caching for the strings converted to wide variants). The long path implementation is user transparent. If a path exceeds the length of _MAX_PATH, it'll be automatically prefixed with \\?\. The MAXPATHLEN is set to 2048 bytes. Appreciation to Pierre Joye, Matt Ficken, @algo13 and others for tips, ideas and testing. Thanks.
* | | | Merge branch 'PHP-7.0'Anatol Belski2016-03-082-1/+3
|\ \ \ \ | | |/ / | |/| | | | | | | | | | * PHP-7.0: fix regression introduced in 5683b6fa39
| * | | Merge branch 'PHP-5.6' into PHP-7.0Anatol Belski2016-03-082-1/+3
| |\ \ \ | | | |/ | | |/| | | | | | | | | * PHP-5.6: fix regression introduced in 5683b6fa39
| | * | fix regression introduced in 5683b6fa39Anatol Belski2016-03-082-1/+3
| | | | | | | | | | | | | | | | | | | | Test extended. Basically, both iterator type and next node have to be checked.
* | | | Remove HAVE_SPL checksNikita Popov2016-01-301-3/+0
|/ / / | | | | | | | | | | | | | | | SPL is always built. Also clean up spl_ce_RuntimeException handling in PDO.
* | | Merge branch 'PHP-5.6' into PHP-7.0Lior Kaplan2016-01-015-5/+5
|\ \ \ | |/ / | | | | | | | | | * PHP-5.6: Happy new year (Update copyright to 2016)
| * | Happy new year (Update copyright to 2016)Lior Kaplan2016-01-015-5/+5
| | |
| * | fixed testChristoph M. Becker2015-08-011-1/+1
| | |
| * | Merge branch 'PHP-5.5' into PHP-5.6Anatol Belski2015-05-313-1/+52
| |\ \ | | | | | | | | | | | | | | | | | | | | * PHP-5.5: split the original test to check behaviour diff on 32- and 64-bit recovered original meaning of SXE xpath test
| | * | split the original test to check behaviour diff on 32- and 64-bitChristoph M. Becker2015-05-312-0/+44
| | | |
| | * | recovered original meaning of SXE xpath testChristoph M. Becker2015-05-311-1/+8
| | | |
| * | | Merge branch 'PHP-5.5' into PHP-5.6Anatol Belski2015-05-297-1/+299
| |\ \ \ | | |/ / | | | | | | | | | | | | | | | | * PHP-5.5: Refactored the fix for bug #66084, by cmb@php.net Merge the fix for #69703 to 5.5 per request from Julien
| | * | Refactored the fix for bug #66084, by cmb@php.netAnatol Belski2015-05-297-1/+299
| | | |
| | * | Bump yearXinchen Hui2015-01-155-5/+5
| | | |
| * | | bump yearXinchen Hui2015-01-155-5/+5
| | | |
* | | | fix testAnatol Belski2015-08-261-7/+2
| | | |
* | | | add range checks to simplexmlAnatol Belski2015-08-261-3/+34
| | | |
* | | | Fix simplexml warningsNikita Popov2015-07-171-4/+4
| |_|/ |/| |
View Lorry Controller Status