summaryrefslogtreecommitdiff
path: root/TSRM/tsrm_win32.c
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | map ell the err codeAnatol Belski2016-08-181-4/+1
| | | |
* | | | Merge branch 'PHP-7.1'Anatol Belski2016-08-181-0/+10
|\ \ \ \ | |/ / / | | | | | | | | | | | | * PHP-7.1: Fixed bug #72858 shm_attach null dereference
| * | | Merge branch 'PHP-7.0' into PHP-7.1Anatol Belski2016-08-181-0/+10
| |\ \ \ | | |/ / | | | | | | | | | | | | * PHP-7.0: Fixed bug #72858 shm_attach null dereference
| | * | Fixed bug #72858 shm_attach null dereferenceAnatol Belski2016-08-181-0/+10
| | | |
| * | | Fixed 7.1 build, decls first please!Kalle Sommer Nielsen2016-08-171-3/+2
| | | |
* | | | Also fix TSRM on WindowsKalle Sommer Nielsen2016-07-301-3/+3
|/ / /
* | | Fixed the UTF-8 and long path support in the streams on Windows.Anatol Belski2016-06-201-17/+75
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since long the default PHP charset is UTF-8, however the Windows part is out of step with this important point. The current implementation in PHP doesn't technically permit to handle UTF-8 filepath and several other things. Till now, only the ANSI compatible APIs are being used. Here is more about it https://msdn.microsoft.com/en-us/library/windows/desktop/dd317752%28v=vs.85%29.aspx The patch fixes not only issues with multibyte filenames under incompatible codepages, but indirectly also issues with some other multibyte encodings like BIG5, Shift-JIS, etc. by providing a clean way to access filenames in UTF-8. Below is a small list of issues from the bug tracker, that are getting fixed: https://bugs.php.net/63401 https://bugs.php.net/41199 https://bugs.php.net/50203 https://bugs.php.net/71509 https://bugs.php.net/64699 https://bugs.php.net/64506 https://bugs.php.net/30195 https://bugs.php.net/65358 https://bugs.php.net/61315 https://bugs.php.net/70943 https://bugs.php.net/70903 https://bugs.php.net/63593 https://bugs.php.net/54977 https://bugs.php.net/54028 https://bugs.php.net/43148 https://bugs.php.net/30730 https://bugs.php.net/33350 https://bugs.php.net/35300 https://bugs.php.net/46990 https://bugs.php.net/61309 https://bugs.php.net/69333 https://bugs.php.net/45517 https://bugs.php.net/70551 https://bugs.php.net/50197 https://bugs.php.net/72200 https://bugs.php.net/37672 Yet more related tickets can for sure be found - on bugs.php.net, Stackoverflow and Github. Some of the bugs are pretty recent, some descend to early 2000th, but the user comments in there last even till today. Just for example, bug #30195 was opened in 2004, the latest comment in there was made in 2014. It is certain, that these bugs descend not only to pure PHP use cases, but get also redirected from the popular PHP based projects. Given the modern systems (and those supported by PHP) are always based on NTFS, there is no excuse to keep these issues unresolved. The internalization approach on Windows is in many ways different from UNIX and Linux, while it supports and is based on Unicode. It depends on the current system code page, APIs used and exact kind how the binary was compiled The locale doesn't affect the way Unicode or ANSI API work. PHP in particular is being compiled without _UNICODE defined and this is conditioned by the way we handle strings. Here is more about it https://msdn.microsoft.com/en-us/library/tsbaswba.aspx However, with any system code page ANSI functions automatically convert paths to UTF-16. Paths in some encodings incompatible with the current system code page, won't work correctly with ANSI APIs. PHP till now only uses the ANSI Windows APIs. For example, on a system with the current code page 1252, the paths in cp1252 are supported and transparently converted to UTF-16 by the ANSI functions. Once one wants to handle a filepath encoded with cp932 on that particular system, an ANSI or a POSIX compatible function used in PHP will produce an erroneous result. When trying to convert that cp932 path to UTF-8 and passing to the ANSI functions, an ANSI function would likely interpret the UTF-8 string as some string in the current code page and create a filepath that represents every single byte of the UTF-8 string. These behaviors are not only broken but also disregard the documented INI settings. This patch solves the issies with the multibyte paths on Windows by intelligently enforcing the usage of the Unicode aware APIs. For functions expect Unicode (fe CreateFileW, FindFirstFileW, etc.), arguments will be converted to UTF-16 wide chars. For functions returning Unicode aware data (fe GetCurrentDirectoryW, etc.), resulting wide string is converted back to char's depending on the current PHP charset settings, either to the current ANSI codepage (this is the behavior prior to this patch) or to UTF-8 (the default behavior). In a particular case, users might have to explicitly set internal_encoding or default_charset, if filenames in ANSI codepage are necessary. Current tests show no regressions and witness that this will be an exotic case, the current default UTF-8 encoding is compatible with any supported system. The dependency libraries are long switching to Unicode APIs, so some tests were also added for extensions not directly related to streams. At large, the patch brings over 150 related tests into the core. Those target and was run on various environments with European, Asian, etc. codepages. General PHP frameworks was tested and showed no regressions. The impact on the current C code base is low, the most places affected are the Windows only places in the three files tsrm_win32.c, zend_virtual_cwd.c and plain_wrapper.c. The actual implementation of the most of the wide char supporting functionality is in win32/ioutil.* and win32/codepage.*, several low level functionsare extended in place to avoid reimplementation for now. No performance impact was sighted. As previously mentioned, the ANSI APIs used prior the patch perform Unicode conversions internally. Using the Unicode APIs directly while doing custom conversions just retains the status quo. The ways to optimize it are open (fe. by implementing caching for the strings converted to wide variants). The long path implementation is user transparent. If a path exceeds the length of _MAX_PATH, it'll be automatically prefixed with \\?\. The MAXPATHLEN is set to 2048 bytes. Appreciation to Pierre Joye, Matt Ficken, @algo13 and others for tips, ideas and testing. Thanks.
* | bump year which is missed in rev 49493a2Xinchen Hui2016-01-021-1/+1
| |
* | correct snprintf usageAnatol Belski2015-10-271-4/+2
| |
* | fix stack overflowAnatol Belski2015-10-101-2/+4
| |
* | don't leak handlesAnatol Belski2015-10-051-0/+6
| |
* | use correct function to close handlesAnatol Belski2015-10-051-2/+2
| |
* | unmap correct handleAnatol Belski2015-09-221-1/+1
| |
* | nullify the memory chunk to avoid crashes when freeing resourceAnatol Belski2015-09-221-0/+1
| |
* | check for NULL returnAnatol Belski2015-09-221-0/+5
| |
* | cleanup an atavismAnatol Belski2015-09-021-1/+1
| | | | | | | | no DOS support here )
* | made ZEND_TSRMLS_CACHE_* macros look like function callsAnatol Belski2015-02-161-1/+1
| | | | | | | | which also comply with the current semantics for such macros
* | bump yearXinchen Hui2015-01-151-1/+1
| |
* | trailing whitespace removalStanislav Malyshev2015-01-101-1/+1
| |
* | first shot remove TSRMLS_* thingsAnatol Belski2014-12-131-18/+15
| |
* | Merge remote-tracking branch 'origin/master' into native-tlsAnatol Belski2014-11-181-14/+61
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * origin/master: (398 commits) NEWS add test for bug #68381 Fixed bug #68381 Set FPM log level earlier during init proper dllexport move to size_t where zend_string is used internally fix some datatype mismatches return after the warning, to fix uninitialized salt usage fix datatype mismatches add missing type specifier fix datatype mismatches fix unsigned check "extern" shouldn't be used for definitions joined identical conditional blocks simplify fpm tests SEND_VAR_NO_REF optimization Add test for bug #68442 Add various tests for FPM - covering recent bugs (68420, 68421, 68423, 68428) - for UDS - for ping and status URI - for multi pool and multi mode Include small MIT FastCGI client library from https://github.com/adoy/PHP-FastCGI-Client Get rid of zend_free_op structure (use zval* instead). Get rid of useless TSRMLS arguments. Add new FPM test for IPv4/IPv6 ... Conflicts: win32/build/config.w32
| * | avoid repeated strlen usage, remove unused varsAnatol Belski2014-11-131-11/+10
| | |
| * | move these functions to the appropriate placeAnatol Belski2014-11-101-0/+48
| | | | | | | | | | | | and include the necessary header
| * | fix datatype mismatch warnsAnatol Belski2014-10-291-3/+3
| | |
* | | moved most of the core to use static tsrm ls cache pointerAnatol Belski2014-10-151-0/+3
|/ / | | | | | | plus apache2handler, cli and cgi
* | remove misprint parenthesesAnatol Belski2014-10-031-2/+2
| |
* | s/PHP 5/PHP 7/Johannes Schlüter2014-09-191-1/+1
| |
* | reverted some previous IS_ABSOLUTE_PATH related changesAnatol Belski2014-09-191-2/+1
| | | | | | | | It's fine with strlen usage now, only one call
* | avoid repeated strlen usageAnatol Belski2014-09-141-1/+2
| |
* | avoid usage of 'type' before the null pointer checkAnatol Belski2014-08-291-1/+1
|/
* Bump yearXinchen Hui2014-01-031-1/+1
|
* initial move on renaming files and fixing includesAnatol Belski2013-10-171-1/+1
|
* fixed possible null derefAnatol Belski2013-07-221-3/+5
|
* Happy New YearXinchen Hui2013-01-011-1/+1
|
* Merge branch 'PHP-5.3' into PHP-5.4Xinchen Hui2012-11-021-1/+4
|\
| * Fixed bug #62444 (Handle leak in is_readable on windows).Xinchen Hui2012-11-021-1/+4
| |
| * - Year++Felipe Pena2012-01-011-1/+1
| |
| * - Fix #55295, check if malloc failedPierre Joye2011-07-271-0/+4
| |
| * - Year++Felipe Pena2011-01-011-1/+1
| |
* | - Year++Felipe Pena2012-01-011-1/+1
| |
* | - Fix #55295, check if malloc failedPierre Joye2011-07-271-0/+4
| |
* | - Year++Felipe Pena2011-01-011-1/+1
| |
* | - drop tsrmls_fetch in popen_exPierre Joye2010-09-171-4/+4
| |
* | - drop tsrmls_fetch in tsrm_win32_accessPierre Joye2010-09-171-3/+1
|/
* - silent warningPierre Joye2010-02-041-1/+1
|
* - fix leakPierre Joye2010-01-311-0/+2
|
* - fix write access check when write mode only is requested (not RW)Pierre Joye2010-01-301-1/+6
|
* - fix leakPierre Joye2010-01-271-1/+1
|
* - fix leak when the SID is already used and duplicatedPierre Joye2010-01-271-0/+4
|
* - wsPierre Joye2010-01-251-1/+1
|
View Lorry Controller Status