summaryrefslogtreecommitdiff
path: root/ext/phar/util.c
diff options
context:
space:
mode:
authorSteph Fox <sfox@php.net>2008-06-21 21:37:39 +0000
committerSteph Fox <sfox@php.net>2008-06-21 21:37:39 +0000
commit0e5b3a35273fd591b573cfec94efe4ad2205bc6e (patch)
treedce8ffa9d97d016ac4ed93376f7428aa8f9b118d /ext/phar/util.c
parent35e0565a4b6e487c48ad9f060ca06151d4daf657 (diff)
downloadphp-git-0e5b3a35273fd591b573cfec94efe4ad2205bc6e.tar.gz
- Don't free stuff you still need
Diffstat (limited to 'ext/phar/util.c')
-rw-r--r--ext/phar/util.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/ext/phar/util.c b/ext/phar/util.c
index 09119f86f0..2f9e9e3df1 100644
--- a/ext/phar/util.c
+++ b/ext/phar/util.c
@@ -746,12 +746,12 @@ phar_entry_data *phar_get_or_create_entry_data(char *fname, int fname_len, char
etemp.tar_type = TAR_FILE;
}
if (FAILURE == zend_hash_add(&phar->manifest, etemp.filename, path_len, (void*)&etemp, sizeof(phar_entry_info), (void **) &entry)) {
- efree(ret);
php_stream_close(etemp.fp);
- efree(etemp.filename);
if (error) {
spprintf(error, 0, "phar error: unable to add new entry \"%s\" to phar \"%s\"", etemp.filename, phar->fname);
}
+ efree(ret);
+ efree(etemp.filename);
return NULL;
}