A picture is worth a thousand message digests

The bundled GD test suites makes heavy use of md5() to verify the result
of drawing operations. This leads to fragile tests (even a slight change
in a PNG header would cause failure, and of course there is the
possibility of collisions), and even worse, eventual test failures are
rather unrevealing.

Therefore we replace all md5() verification with a simplistic
test_image_equals_file(), which is basically a simplified port of libgd's
gdTestImageCompareToFile(), adapted to the needs of PHPTs.

In the long run better tests helpers should be introduced (see also
<http://news.php.net/php.internals/94081>), but for now this solution
is preferable over the former.

(cherry picked from commit 24f9e96792518ec2a75f26b1eb2471dd7694f2b7)

1 files changed, 3 insertions, 8 deletions

diff --git a/ext/gd/tests/imagerectangle_basic.phpt b/ext/gd/tests/imagerectangle_basic.phpt
index eaa1566f7f..507d715326 100644
--- a/ext/gd/tests/imagerectangle_basic.phpt
+++ b/ext/gd/tests/imagerectangle_basic.phpt
@@ -15,13 +15,8 @@ $image = imagecreatetruecolor( 100, 100 );
 // Draw a rectangle

 imagerectangle( $image, 0, 0, 50, 50, imagecolorallocate($image, 255, 255, 255) );

 

-ob_start(); 

-imagegd( $image );

-$img = ob_get_contents(); 

-ob_end_clean();

-

-echo md5(base64_encode($img));

-

+include_once __DIR__ . '/func.inc';

+test_image_equals_file(__DIR__ . '/imagerectangle_basic.png', $image);

 ?> 

 --EXPECT-- 

-e7f8ca8c63fb08b248f3ed6435983aed
\ No newline at end of file
+The images are equal.