summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGeorge Peter Banyard <girgias@php.net>2020-03-26 03:20:10 +0100
committerDmitry Stogov <dmitry@zend.com>2020-03-26 10:28:38 +0300
commit6e88f19346236aad75779c9d91fffe4987786894 (patch)
tree9ca47554e0838c8edbc073547ea7c68d863e1f41
parent91ee85c20c29fdf8750dbbf22cec998382318620 (diff)
downloadphp-git-6e88f19346236aad75779c9d91fffe4987786894.tar.gz
Explicitly declare the char as signed in zend_ffi_val.
This causes issues down the line as char are unsigned on some platforms, e.g. ARM and cause a [-Wtype-limits] warning to be emitted.
-rw-r--r--ext/ffi/php_ffi.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/ext/ffi/php_ffi.h b/ext/ffi/php_ffi.h
index 913d63ecd0..1b51a832c9 100644
--- a/ext/ffi/php_ffi.h
+++ b/ext/ffi/php_ffi.h
@@ -200,7 +200,7 @@ typedef struct _zend_ffi_val {
uint64_t u64;
int64_t i64;
zend_ffi_double d;
- char ch;
+ signed char ch;
struct {
const char *str;
size_t len;