summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNikita Popov <nikita.ppv@gmail.com>2020-01-29 16:19:14 +0100
committerNikita Popov <nikita.ppv@gmail.com>2020-01-29 16:19:14 +0100
commitacc616c455c007857e6aeb006e3e9aa63565c461 (patch)
tree4ee1f74d2f8c2434e0f9789aaa4a89cef8cecd98
parent18599f9c52959b2e8cbfac57e278644499a3547d (diff)
parenta62c06c4cf2020c04a2f5ac0b55aff4bb71f3edc (diff)
downloadphp-git-acc616c455c007857e6aeb006e3e9aa63565c461.tar.gz
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3: Fix mb_ord() crash if internal encoding not supported
-rw-r--r--ext/mbstring/mbstring.c2
-rw-r--r--ext/mbstring/tests/mb_ord.phpt11
2 files changed, 9 insertions, 4 deletions
diff --git a/ext/mbstring/mbstring.c b/ext/mbstring/mbstring.c
index d6b633ff3a..dcd067a390 100644
--- a/ext/mbstring/mbstring.c
+++ b/ext/mbstring/mbstring.c
@@ -4987,7 +4987,7 @@ static inline zend_long php_mb_ord(const char *str, size_t str_len, zend_string
no_enc = enc->no_encoding;
if (php_mb_is_unsupported_no_encoding(no_enc)) {
- php_error_docref(NULL, E_WARNING, "Unsupported encoding \"%s\"", ZSTR_VAL(enc_name));
+ php_error_docref(NULL, E_WARNING, "Unsupported encoding \"%s\"", enc->name);
return -1;
}
diff --git a/ext/mbstring/tests/mb_ord.phpt b/ext/mbstring/tests/mb_ord.phpt
index b42bd05425..e0c5610c0b 100644
--- a/ext/mbstring/tests/mb_ord.phpt
+++ b/ext/mbstring/tests/mb_ord.phpt
@@ -19,6 +19,9 @@ var_dump(
mb_ord("\u{d800}", "utf-7"),
mb_ord("")
);
+
+mb_internal_encoding("utf-7");
+mb_ord("");
?>
--EXPECTF--
bool(true)
@@ -29,11 +32,11 @@ Warning: mb_ord(): Unknown encoding "typo" %s 10
Warning: mb_ord(): Unsupported encoding "pass" %s 11
-Warning: mb_ord(): Unsupported encoding "jis" %s 12
+Warning: mb_ord(): Unsupported encoding "JIS" in %s on line %d
-Warning: mb_ord(): Unsupported encoding "cp50222" %s 13
+Warning: mb_ord(): Unsupported encoding "CP50222" in %s on line %d
-Warning: mb_ord(): Unsupported encoding "utf-7" %s 14
+Warning: mb_ord(): Unsupported encoding "UTF-7" in %s on line %d
Warning: mb_ord(): Empty string in %s on line %d
bool(false)
@@ -42,3 +45,5 @@ bool(false)
bool(false)
bool(false)
bool(false)
+
+Warning: mb_ord(): Unsupported encoding "UTF-7" in %s on line %d