diff options
| author | Stanislav Malyshev <stas@php.net> | 2019-08-24 23:11:45 -0700 |
|---|---|---|
| committer | Stanislav Malyshev <stas@php.net> | 2019-08-24 23:11:45 -0700 |
| commit | 1258303e66d8dede4f02347334b9f6576e98a21b (patch) | |
| tree | aa9e4a287253a97a3e8605311e2ca3a6b48ff531 | |
| parent | 1c01a1579ed554bd22dfcdcf38e94b554b90a585 (diff) | |
| download | php-git-1258303e66d8dede4f02347334b9f6576e98a21b.tar.gz | |
Fix CVE-2019-13224: don't allow different encodings for onig_new_deluxe()
Backport from https://github.com/kkos/oniguruma/commit/0f7f61ed1b7b697e283e37bd2d731d0bd57adb55
| -rw-r--r-- | ext/mbstring/oniguruma/regext.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ext/mbstring/oniguruma/regext.c b/ext/mbstring/oniguruma/regext.c index b1b957b40c..b108e638c6 100644 --- a/ext/mbstring/oniguruma/regext.c +++ b/ext/mbstring/oniguruma/regext.c @@ -29,6 +29,7 @@ #include "regint.h" +#if 0 static void conv_ext0be32(const UChar* s, const UChar* end, UChar* conv) { @@ -158,6 +159,7 @@ conv_encoding(OnigEncoding from, OnigEncoding to, const UChar* s, const UChar* e return ONIGERR_NOT_SUPPORTED_ENCODING_COMBINATION; } +#endif extern int onig_new_deluxe(regex_t** reg, const UChar* pattern, const UChar* pattern_end, @@ -169,9 +171,7 @@ onig_new_deluxe(regex_t** reg, const UChar* pattern, const UChar* pattern_end, if (IS_NOT_NULL(einfo)) einfo->par = (UChar* )NULL; if (ci->pattern_enc != ci->target_enc) { - r = conv_encoding(ci->pattern_enc, ci->target_enc, pattern, pattern_end, - &cpat, &cpat_end); - if (r) return r; + return ONIGERR_NOT_SUPPORTED_ENCODING_COMBINATION; } else { cpat = (UChar* )pattern; |