diff options
| author | Stanislav Malyshev <stas@php.net> | 2018-12-03 10:20:07 -0800 |
|---|---|---|
| committer | Christoph M. Becker <cmbecker69@gmx.de> | 2018-12-04 11:09:04 +0100 |
| commit | f7275963cd098452d4be8e0f7e1ff0f3dd1482b7 (patch) | |
| tree | 782f2f0a1364bbd187f47e605154a2015dd744dc | |
| parent | 648fc1e369fc05fb9200a42c7938912236b2a318 (diff) | |
| download | php-git-f7275963cd098452d4be8e0f7e1ff0f3dd1482b7.tar.gz | |
Fix null pointer deref in qprint-encode filter (bug #77231)
(cherry picked from commit 36534afd10956b5191f7e23ff050c9b9ff40e6ac)
| -rw-r--r-- | ext/standard/filters.c | 2 | ||||
| -rw-r--r-- | ext/standard/tests/filters/bug77231.phpt | 11 |
2 files changed, 12 insertions, 1 deletions
diff --git a/ext/standard/filters.c b/ext/standard/filters.c index 9bd494f38d..7b039cd18f 100644 --- a/ext/standard/filters.c +++ b/ext/standard/filters.c @@ -917,7 +917,7 @@ static php_conv_err_t php_conv_qprint_encode_convert(php_conv_qprint_encode *ins line_ccnt--; CONSUME_CHAR(ps, icnt, lb_ptr, lb_cnt); } else { - if (line_ccnt < 4) { + if (line_ccnt < 4 && inst->lbchars != NULL) { if (ocnt < inst->lbchars_len + 1) { err = PHP_CONV_ERR_TOO_BIG; break; diff --git a/ext/standard/tests/filters/bug77231.phpt b/ext/standard/tests/filters/bug77231.phpt new file mode 100644 index 0000000000..17967ee80f --- /dev/null +++ b/ext/standard/tests/filters/bug77231.phpt @@ -0,0 +1,11 @@ +--TEST-- +Bug #77231 (Segfault when using convert.quoted-printable-encode filter) +--FILE-- +<?php +var_dump(file(urldecode('php://filter/convert.quoted-printable-encode/resource=data://,%bfAAAAAAAAFAAAAAAAAAAAAAA%ff%ff%ff%ff%ff%ff%ff%ffAAAAAAAAAAAAAAAAAAAAAAAA'))); +?> +--EXPECT-- +array(1) { + [0]=> + string(74) "=BFAAAAAAAAFAAAAAAAAAAAAAA=FF=FF=FF=FF=FF=FF=FF=FFAAAAAAAAAAAAAAAAAAAAAAAA" +}
\ No newline at end of file |