summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXinchen Hui <laruence@gmail.com>2018-05-23 14:46:01 +0800
committerXinchen Hui <laruence@gmail.com>2018-05-23 14:46:01 +0800
commitdc461d6f561dd7e2da0f9664afc75b740ef3dc44 (patch)
treea3e46957c0440e3af8633e9be81e25a120594db1
parenta231860b026baf8a2dfd34852c0cc196e7c7ebfb (diff)
parent8f221bdec0e1a81ef4471f926cf0b0f23724204c (diff)
downloadphp-git-dc461d6f561dd7e2da0f9664afc75b740ef3dc44.tar.gz
Merge branch 'PHP-7.1' into PHP-7.2
* PHP-7.1: Fixed bug #76367 (NoRewindIterator segfault 11)
-rw-r--r--ext/spl/spl_array.c2
-rw-r--r--ext/spl/tests/bug76367.phpt16
2 files changed, 17 insertions, 1 deletions
diff --git a/ext/spl/spl_array.c b/ext/spl/spl_array.c
index bc883b02e6..d34902ce80 100644
--- a/ext/spl/spl_array.c
+++ b/ext/spl/spl_array.c
@@ -1039,7 +1039,7 @@ static zval *spl_array_it_get_current_data(zend_object_iterator *iter) /* {{{ */
return zend_user_it_get_current_data(iter);
} else {
zval *data = zend_hash_get_current_data_ex(aht, spl_array_get_pos_ptr(aht, object));
- if (Z_TYPE_P(data) == IS_INDIRECT) {
+ if (data && Z_TYPE_P(data) == IS_INDIRECT) {
data = Z_INDIRECT_P(data);
}
return data;
diff --git a/ext/spl/tests/bug76367.phpt b/ext/spl/tests/bug76367.phpt
new file mode 100644
index 0000000000..f34e8a39de
--- /dev/null
+++ b/ext/spl/tests/bug76367.phpt
@@ -0,0 +1,16 @@
+--TEST--
+Bug #76367 (NoRewindIterator segfault 11)
+--FILE--
+<?php
+$arr = [1,3,55,66,43,6];
+
+$iter = new NoRewindIterator(new ArrayIterator($arr));
+
+while($iter->valid()) {
+ $iter->next();
+}
+
+var_dump($iter->current());
+?>
+--EXPECT--
+NULL