summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnatol Belski <ab@php.net>2017-01-05 13:59:01 +0100
committerAnatol Belski <ab@php.net>2017-01-05 06:20:22 +0100
commit564a161258e53c05e1d0b02a16568e24d4da3b51 (patch)
tree7ec8734d1415ecf65ba22d39552ac4f2bb563246
parent20d9ebc6fb75b55d3bc98bae9e2b8e796142486e (diff)
downloadphp-git-564a161258e53c05e1d0b02a16568e24d4da3b51.tar.gz
Revert "Merge branch 'bugfix_timeout_61471' of https://github.com/axot/php-src into PHP-7.0"php-7.0.15RC1
This reverts commit a8931df672bb173ef81c10e4fc2a5de23789c935, reversing changes made to f2f35a2b27d0074ab015b8a37d6563eec74147d5. (cherry picked from commit 57736cc937fc6dfdfb403293d7bf88b264e83e15)
-rw-r--r--sapi/apache2handler/sapi_apache2.c45
1 files changed, 1 insertions, 44 deletions
diff --git a/sapi/apache2handler/sapi_apache2.c b/sapi/apache2handler/sapi_apache2.c
index 68757d6ad8..bf22d2c783 100644
--- a/sapi/apache2handler/sapi_apache2.c
+++ b/sapi/apache2handler/sapi_apache2.c
@@ -69,33 +69,6 @@ char *apache2_php_ini_path_override = NULL;
ZEND_TSRMLS_CACHE_DEFINE()
#endif
-/* if apache's version is newer than 2.2.31 or 2.4.16 */
-#if MODULE_MAGIC_COOKIE == 0x41503232UL && AP_MODULE_MAGIC_AT_LEAST(20051115,40) || \
- MODULE_MAGIC_COOKIE == 0x41503234UL && AP_MODULE_MAGIC_AT_LEAST(20120211,47)
-#define php_ap_map_http_request_error ap_map_http_request_error
-#else
-static int php_ap_map_http_request_error(apr_status_t rv, int status)
-{
- switch (rv) {
- case AP_FILTER_ERROR: {
- return AP_FILTER_ERROR;
- }
- case APR_ENOSPC: {
- return HTTP_REQUEST_ENTITY_TOO_LARGE;
- }
- case APR_ENOTIMPL: {
- return HTTP_NOT_IMPLEMENTED;
- }
- case APR_ETIMEDOUT: {
- return HTTP_REQUEST_TIME_OUT;
- }
- default: {
- return status;
- }
- }
-}
-#endif
-
static size_t
php_apache_sapi_ub_write(const char *str, size_t str_length)
{
@@ -211,7 +184,6 @@ php_apache_sapi_read_post(char *buf, size_t count_bytes)
php_struct *ctx = SG(server_context);
request_rec *r;
apr_bucket_brigade *brigade;
- apr_status_t ret;
r = ctx->r;
brigade = ctx->brigade;
@@ -223,7 +195,7 @@ php_apache_sapi_read_post(char *buf, size_t count_bytes)
* need to make sure that if data is available we fill the buffer completely.
*/
- while ((ret=ap_get_brigade(r->input_filters, brigade, AP_MODE_READBYTES, APR_BLOCK_READ, len)) == APR_SUCCESS) {
+ while (ap_get_brigade(r->input_filters, brigade, AP_MODE_READBYTES, APR_BLOCK_READ, len) == APR_SUCCESS) {
apr_brigade_flatten(brigade, buf, &len);
apr_brigade_cleanup(brigade);
tlen += len;
@@ -234,14 +206,6 @@ php_apache_sapi_read_post(char *buf, size_t count_bytes)
len = count_bytes - tlen;
}
- if (ret != APR_SUCCESS) {
- if (APR_STATUS_IS_TIMEUP(ret)) {
- SG(sapi_headers).http_response_code = php_ap_map_http_request_error(ret, HTTP_REQUEST_TIME_OUT);
- } else {
- SG(sapi_headers).http_response_code = php_ap_map_http_request_error(ret, HTTP_BAD_REQUEST);
- }
- }
-
return tlen;
}
@@ -692,13 +656,6 @@ zend_first_try {
brigade = ctx->brigade;
}
- if (SG(request_info).content_length > SG(read_post_bytes)) {
- ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, "Error while attempting to read POST data: %d", SG(sapi_headers).http_response_code);
- apr_brigade_cleanup(brigade);
- PHPAP_INI_OFF;
- return SG(sapi_headers).http_response_code;
- }
-
if (AP2(last_modified)) {
ap_update_mtime(r, r->finfo.mtime);
ap_set_last_modified(r);