diff options
| author | Yasuo Ohgaki <yohgaki@php.net> | 2015-02-03 13:38:49 +0900 |
|---|---|---|
| committer | Yasuo Ohgaki <yohgaki@php.net> | 2015-02-03 13:38:49 +0900 |
| commit | 853ae39d6ea6a4d2ce95098744e481a1e8573ad8 (patch) | |
| tree | 09641f1e3ee404ead0eb21485bd0ab30955780fd | |
| parent | 17beba686e69a6f0dae9db9548582c34df81ceef (diff) | |
| download | php-git-853ae39d6ea6a4d2ce95098744e481a1e8573ad8.tar.gz | |
Fixed bug #68063 Empty session IDs do still start sessions
| -rw-r--r-- | ext/session/session.c | 5 | ||||
| -rw-r--r-- | ext/session/tests/bug68063.phpt | 20 |
2 files changed, 25 insertions, 0 deletions
diff --git a/ext/session/session.c b/ext/session/session.c index 2c4d5c0d46..9b609308ed 100644 --- a/ext/session/session.c +++ b/ext/session/session.c @@ -2053,6 +2053,11 @@ static PHP_FUNCTION(session_decode) static PHP_FUNCTION(session_start) { /* skipping check for non-zero args for performance reasons here ?*/ + if (PS(id) && !strlen(PS(id))) { + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Cannot start session with empty session ID"); + RETURN_FALSE; + } + php_session_start(TSRMLS_C); if (PS(session_status) != php_session_active) { diff --git a/ext/session/tests/bug68063.phpt b/ext/session/tests/bug68063.phpt new file mode 100644 index 0000000000..d3da470d06 --- /dev/null +++ b/ext/session/tests/bug68063.phpt @@ -0,0 +1,20 @@ +--TEST-- +Bug #68063 (Empty session IDs do still start sessions) +--SKIPIF-- +<?php include('skipif.inc'); ?> +--INI-- +--FILE-- +<?php +// Could also be set with a cookie like "PHPSESSID=; path=/" +session_id(''); + +// Will still start the session and return true +var_dump(session_start()); + +// Returns an empty string +var_dump(session_id()); +?> +--EXPECTF-- +Warning: session_start(): Cannot start session with empty session ID in %s on line %d +bool(false) +string(0) "" |