diff options
| author | Christoph M. Becker <cmbecker69@gmx.de> | 2016-08-27 01:02:58 +0200 |
|---|---|---|
| committer | Christoph M. Becker <cmbecker69@gmx.de> | 2016-08-27 01:12:01 +0200 |
| commit | 2139918ea6f5088e9ed5daa734568b4a50217f52 (patch) | |
| tree | b070de9641e20d52d8f06b99ff1c9caf1879637b | |
| parent | 84512a117789563a64172115c648944538006a69 (diff) | |
| download | php-git-2139918ea6f5088e9ed5daa734568b4a50217f52.tar.gz | |
Fix #65550: get_browser() incorrectly parsers entries with "+" sign
+ signs in the browscap patterns are meant to be literal characters, so we
have to escape them for the regex matching.
| -rw-r--r-- | NEWS | 2 | ||||
| -rw-r--r-- | ext/standard/browscap.c | 4 | ||||
| -rw-r--r-- | ext/standard/tests/misc/bug65550.phpt | 19 |
3 files changed, 25 insertions, 0 deletions
@@ -44,6 +44,8 @@ PHP NEWS - Standard: . Fixed bug #72823 (strtr out-of-bound access). (cmb) . Fixed bug #72278 (getimagesize returning FALSE on valid jpg). (cmb) + . Fixed bug #65550 (get_browser() incorrectly parses entries with "+" sign). + (cmb) - XML: . Fixed bug #72085 (SEGV on unknown address zif_xml_parse). (cmb) diff --git a/ext/standard/browscap.c b/ext/standard/browscap.c index 2b75135640..36def71838 100644 --- a/ext/standard/browscap.c +++ b/ext/standard/browscap.c @@ -123,6 +123,10 @@ static void convert_browscap_pattern(zval *pattern, int persistent) /* {{{ */ t[j++] = '\\'; t[j] = '~'; break; + case '+': + t[j++] = '\\'; + t[j] = '+'; + break; default: t[j] = Z_STRVAL_P(pattern)[i]; break; diff --git a/ext/standard/tests/misc/bug65550.phpt b/ext/standard/tests/misc/bug65550.phpt new file mode 100644 index 0000000000..41967426fa --- /dev/null +++ b/ext/standard/tests/misc/bug65550.phpt @@ -0,0 +1,19 @@ +--TEST-- +Bug #65550 (get_browser() incorrectly parses entries with "+" sign) +--INI-- +browscap={PWD}/browscap.ini +--SKIPIF-- +<?php +if (!is_readable(ini_get('browscap'))) die('skip browscap.ini file ' . ini_get('browscap') . ' not readable'); +?> +--FILE-- +<?php +$user_agent = 'Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US) AppleWebKit/522+ (KHTML, like Gecko, Safari/522) OmniWeb/v613'; +$caps = get_browser($user_agent, true); +var_dump($caps['browser'], $caps['version']); +?> +==DONE== +--EXPECT-- +string(7) "OmniWeb" +string(3) "5.6" +==DONE== |