summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristopher Jones <christopher.jones@oracle.com>2015-11-07 02:14:18 +1100
committerChristopher Jones <christopher.jones@oracle.com>2015-11-07 02:14:18 +1100
commita57b2053832fc0136d6b894148d0d20c0d9d90df (patch)
tree6dc59f1b8b660a7916f94b0a4c16f5f94769c177
parentf88a9a964368ad21e78cf96197952aa3e03d4604 (diff)
downloadphp-git-a57b2053832fc0136d6b894148d0d20c0d9d90df.tar.gz
Fix compile warnings about comparison of unsigned expression always being true
-rw-r--r--ext/oci8/oci8_interface.c2
-rw-r--r--ext/oci8/oci8_lob.c4
2 files changed, 1 insertions, 5 deletions
diff --git a/ext/oci8/oci8_interface.c b/ext/oci8/oci8_interface.c
index bb7212290d..817b8dbf8b 100644
--- a/ext/oci8/oci8_interface.c
+++ b/ext/oci8/oci8_interface.c
@@ -373,7 +373,7 @@ PHP_FUNCTION(oci_lob_eof)
PHP_OCI_ZVAL_TO_DESCRIPTOR(*tmp, descriptor);
- if (!php_oci_lob_get_length(descriptor, &lob_length TSRMLS_CC) && lob_length >= 0) {
+ if (!php_oci_lob_get_length(descriptor, &lob_length TSRMLS_CC)) {
if (lob_length == descriptor->lob_current_position) {
RETURN_TRUE;
}
diff --git a/ext/oci8/oci8_lob.c b/ext/oci8/oci8_lob.c
index ca08373ff2..079e0a6a8f 100644
--- a/ext/oci8/oci8_lob.c
+++ b/ext/oci8/oci8_lob.c
@@ -417,10 +417,6 @@ int php_oci_lob_write (php_oci_descriptor *descriptor, ub4 offset, char *data, i
return 0;
}
- if (offset < 0) {
- offset = 0;
- }
-
if (offset > descriptor->lob_current_position) {
offset = descriptor->lob_current_position;
}