diff options
| author | Michael Wallner <mike@php.net> | 2013-09-18 11:10:55 +0200 |
|---|---|---|
| committer | Michael Wallner <mike@php.net> | 2013-09-18 11:10:55 +0200 |
| commit | 9bfd55cda3bd66b56af84a569fafd8a77cbb3726 (patch) | |
| tree | 44774584aaad23fde333d5e2a1930f4e79c3204b | |
| parent | dfd7d1063a5292b04f6134284337550f4f513749 (diff) | |
| download | php-git-9bfd55cda3bd66b56af84a569fafd8a77cbb3726.tar.gz | |
fix a very rare case of use of uninitialized value combined with a
memleak
| -rw-r--r-- | main/fopen_wrappers.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/main/fopen_wrappers.c b/main/fopen_wrappers.c index 6f11cf3f32..9b8645a061 100644 --- a/main/fopen_wrappers.c +++ b/main/fopen_wrappers.c @@ -775,7 +775,12 @@ PHPAPI char *expand_filepath_with_mode(const char *filepath, char *real_path, co * we cannot cannot getcwd() and the requested, * relatively referenced file is accessible */ copy_len = strlen(filepath) > MAXPATHLEN - 1 ? MAXPATHLEN - 1 : strlen(filepath); - real_path = estrndup(filepath, copy_len); + if (real_path) { + memcpy(real_path, filepath, copy_len); + real_path[copy_len] = '\0'; + } else { + real_path = estrndup(filepath, copy_len); + } close(fdtest); return real_path; } else { |