diff options
| author | Stanislav Malyshev <stas@php.net> | 2015-04-11 16:42:16 -0700 |
|---|---|---|
| committer | Julien Pauli <jpauli@php.net> | 2015-04-15 10:12:04 +0200 |
| commit | b4554a022ee1ad718e372a646c92eddea1d08da4 (patch) | |
| tree | 15cfeafcf5fb8917916bf248d78988b8d6275546 | |
| parent | 1da9156e60d3d02cc4661244e40d95d5eb76b881 (diff) | |
| download | php-git-b4554a022ee1ad718e372a646c92eddea1d08da4.tar.gz | |
Additional fix for bug #69324
Not so happy about duplication but needed due to bug #69429
| -rw-r--r-- | ext/phar/phar.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/ext/phar/phar.c b/ext/phar/phar.c index 8bc7b61efc..b90005d300 100644 --- a/ext/phar/phar.c +++ b/ext/phar/phar.c @@ -598,27 +598,28 @@ int phar_open_parsed_phar(char *fname, int fname_len, char *alias, int alias_len * * Meta-data is in this format: * [len32][data...] - * + * * data is the serialized zval */ int phar_parse_metadata(char **buffer, zval **metadata, php_uint32 zip_metadata_len TSRMLS_DC) /* {{{ */ { - const unsigned char *p; php_unserialize_data_t var_hash; if (zip_metadata_len) { + const unsigned char *p, *p_buff = estrndup(*buffer, zip_metadata_len); + p = p_buff; ALLOC_ZVAL(*metadata); INIT_ZVAL(**metadata); - p = (const unsigned char*) *buffer; PHP_VAR_UNSERIALIZE_INIT(var_hash); if (!php_var_unserialize(metadata, &p, p + zip_metadata_len, &var_hash TSRMLS_CC)) { + efree(p_buff); PHP_VAR_UNSERIALIZE_DESTROY(var_hash); zval_ptr_dtor(metadata); *metadata = NULL; return FAILURE; } - + efree(p_buff); PHP_VAR_UNSERIALIZE_DESTROY(var_hash); if (PHAR_G(persist)) { @@ -641,7 +642,7 @@ int phar_parse_metadata(char **buffer, zval **metadata, php_uint32 zip_metadata_ * * Parse a new one and add it to the cache, returning either SUCCESS or * FAILURE, and setting pphar to the pointer to the manifest entry - * + * * This is used by phar_open_from_filename to process the manifest, but can be called * directly. */ @@ -2234,7 +2235,7 @@ last_time: /** * Process a phar stream name, ensuring we can handle any of: - * + * * - whatever.phar * - whatever.phar.gz * - whatever.phar.bz2 |