summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Lowrey <rdlowrey@php.net>2014-02-14 18:15:24 -0700
committerDaniel Lowrey <rdlowrey@php.net>2014-02-14 18:15:24 -0700
commit65adb74984db4d93e57ddc2583e6bceee5bdc7da (patch)
tree9b7cfbaa338fc6e32df895009ba366da9fa8aafe
parentf9829690d4f6e747a8d46751c9d37e5e5e40336c (diff)
parent19524fc6feb44050bbb70c19717c59864ae4955d (diff)
downloadphp-git-65adb74984db4d93e57ddc2583e6bceee5bdc7da.tar.gz
Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4: Fix for bug66501 - "key type not supported in this PHP build"
-rw-r--r--ext/openssl/openssl.c9
-rw-r--r--ext/openssl/tests/bug66501.phpt21
2 files changed, 30 insertions, 0 deletions
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
index 4e659a10db..8ba24026b4 100644
--- a/ext/openssl/openssl.c
+++ b/ext/openssl/openssl.c
@@ -3026,6 +3026,15 @@ static int php_openssl_is_private_key(EVP_PKEY* pkey TSRMLS_DC)
}
break;
#endif
+#ifdef EVP_PKEY_EC
+ case EVP_PKEY_EC:
+ assert(pkey->pkey.ec != NULL);
+
+ if ( NULL == EC_KEY_get0_private_key(pkey->pkey.ec)) {
+ return 0;
+ }
+ break;
+#endif
default:
php_error_docref(NULL TSRMLS_CC, E_WARNING, "key type not supported in this PHP build!");
break;
diff --git a/ext/openssl/tests/bug66501.phpt b/ext/openssl/tests/bug66501.phpt
new file mode 100644
index 0000000000..5c57f2117f
--- /dev/null
+++ b/ext/openssl/tests/bug66501.phpt
@@ -0,0 +1,21 @@
+--TEST--
+Bug #66501: EC private key support in openssl_sign
+--SKIPIF--
+<?php
+if (!extension_loaded("openssl")) die("skip");
+--FILE--
+<?php
+$pkey = 'ASN1 OID: prime256v1
+-----BEGIN EC PARAMETERS-----
+BggqhkjOPQMBBw==
+-----END EC PARAMETERS-----
+-----BEGIN EC PRIVATE KEY-----
+MHcCAQEEILPkqoeyM7XgwYkuSj3077lrsrfWJK5LqMolv+m2oOjZoAoGCCqGSM49
+AwEHoUQDQgAEPq4hbIWHvB51rdWr8ejrjWo4qVNWVugYFtPg/xLQw0mHkIPZ4DvK
+sqOTOnMoezkbSmVVMuwz9flvnqHGmQvmug==
+-----END EC PRIVATE KEY-----';
+$key = openssl_pkey_get_private($pkey);
+$res = openssl_sign($data ='alpha', $sign, $key, 'ecdsa-with-SHA1');
+var_dump($res);
+--EXPECTF--
+bool(true)