diff options
| author | Remi Collet <remi@php.net> | 2014-12-17 10:59:36 +0100 |
|---|---|---|
| committer | Stanislav Malyshev <stas@php.net> | 2015-04-05 17:36:47 -0700 |
| commit | bd31cb756399101234258c5491443531099957c3 (patch) | |
| tree | 497c83f11ee5e79746ca0afc31f6873a4624d781 | |
| parent | afbf725e7380dfb3ff43a993e43abd9759a66c2b (diff) | |
| download | php-git-bd31cb756399101234258c5491443531099957c3.tar.gz | |
Better fix for #68601 for perf
https://bitbucket.org/libgd/gd-libgd/commits/81e9a993f2893d651d225646378e3fd1b7465467
| -rw-r--r-- | ext/gd/libgd/gd_gif_in.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/ext/gd/libgd/gd_gif_in.c b/ext/gd/libgd/gd_gif_in.c index 491e9422db..f41ec8460a 100644 --- a/ext/gd/libgd/gd_gif_in.c +++ b/ext/gd/libgd/gd_gif_in.c @@ -400,14 +400,14 @@ GetCode_(gdIOCtx *fd, CODE_STATIC_DATA *scd, int code_size, int flag, int *ZeroD scd->lastbit = (2+count)*8 ; } - ret = 0; - for (i = scd->curbit, j = 0; j < code_size; ++i, ++j) - if (i < CSD_BUF_SIZE * 8) { + if ((scd->curbit + code_size - 1) >= (CSD_BUF_SIZE * 8)) { + ret = -1; + } else { + ret = 0; + for (i = scd->curbit, j = 0; j < code_size; ++i, ++j) { ret |= ((scd->buf[i / 8] & (1 << (i % 8))) != 0) << j; - } else { - ret = -1; - break; } + } scd->curbit += code_size; return ret; |