| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Guessing the encoding of a report file prepared ahead of time is
really, well, too much guesswork, plus there are at least a couple
of mistakes in the implementation. And we weren't even trying to
guess for reports created on-the-fly in an editor, which is a bit
inconsistent.
So handle prepared reports the same way as on-the-fly reports and
attachments, which means all I/O is done using the :raw layer.
This is only "Unicode-aware" in the sense that we're aware there
are a lot of encodings out there and we're trying not to mangle
them in transit by accidental conversion. We're not doing any
explicit character set conversions and we shouldn't assert in the
MIME headers that we know what character set we're sending because
we don't.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Try to do input in whatever the locale wants and output raw in
hopes that will best survive mail transport.
Except when reading in a patch file, we'll also use raw for input
because there may be multiple encodings in the patch, and we'll
also use raw for input when reading in the report file that we've
written out raw.
We attempt to detect the locale encoding using the private and
undocumented _get_locale_encoding() function of the deprecated
encoding pragma module. But it's what the open pragma does and
we protect ourselves by checking that it's available and falling
back to an empty layer specification ("<:") if we can't load that
function. That should also give us something workable when there
is no dynamic loading, such as under miniperl.
|
|
|
|
|
|
|
|
|
|
|
| |
The VMS mail utility can't do attachments because it always adds
a blank line in front of any headers you add. So use the Send
From File utility, which has been documented and supported for
any release in the last decade and was latently present before
that.
It takes the whole message verbatim just like sendmail, but also
needs the envelope prepended.
|
|
|
|
|
|
|
|
|
|
|
| |
Log files and other text attachments should also be fine as long
as they aren't big enough to be rejected by RT.
Only text attachments are supported, as other kinds would involve
wrestling with myriad MIME types and possibly content transfer
encodings. This should be fine for binary patches, though, as
git format-patch encodes those in Base85, so the patch file itself
is still text.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Re-parsing patchlevel.h in Perl by perlbug.PL is error prone
and apparently unnecessary. The same information is available
to perlbug via Config::local_patches().
This fixes [perl #118433].
|
| |
|
|
|
|
| |
Suggested by Dave Mitchell.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
patch does:
perl -pi -e 's/$::opt_(\w)/$opt{$1}/g' perlbug.PL
adds my %opt decl, and in getopts.
drops no warnings 'once'
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
|
|
|
|
|
|
|
| |
Many systems thesedays don't have a valid internet domain name and
perlbug@perl.org does not accept email with a return-path that does not
resolve. Therefore pass the user's address to sendmail so it's less
likely to get stuck in a mail queue somewhere.
|
| |
|
|
|
|
|
|
|
|
|
| |
# New Ticket Created by (Peter J. Acklam)
# Please include the string: [perl #81914]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=81914 >
Signed-off-by: Abigail <abigail@abigail.be>
|
|
|
|
|
| |
the "right" thing and insert a valid "From:", not all of them do,
potentially resulting in dropped mail.
|
|
|
|
|
|
|
|
|
|
| |
The code that guessed a default sender address would under some
circumstances not display this guess to the user with the option to change
it. Specifically, if $Config{cf_me} eq {login id of the user running
perlbug}.
In my case, cf_email got set at build time (Configure default) of
'davem@pigeon.(none)', which was then silently used. Not good!
|
| |
|
|
|
|
| |
Signed-off-by: H.Merijn Brand <h.m.brand@xs4all.nl>
|
|
|
|
|
| |
This patch also make PERL_GIT_UNCOMMITTED_CHANGES useful and thus avoids
always adding the "*" to the 'perl -v' output.
|
|
|
|
|
| |
perlbug doesn't check the return status of Mail::Send and so reports
"Message sent" even if it hasn't:
|
| |
|
| |
|
| |
|
|
|
|
|
| |
but these days it contains macros that expand to patch lists;
for now, just skip these macros. need a proper fix sometime.
|
|
|
|
|
|
|
| |
Where the user names a module that their bug report is about, and we know the
URL for its upstream bug tracker, provide a message to the user explaining
that the core copies the CPAN version directly, and provide the URL for
reporting the bug directly to upstream.
|
|
|
|
|
|
| |
From: Abigail (via RT) <perlbug-followup@perl.org>
Date: Tue, 16 Dec 2008 13:09:56 -0800
Message-ID: <rt-3.6.HEAD-15883-1229461796-1657.61418-75-0@perl.org>
|
|
|
| |
p4raw-id: //depot/perl@35120
|
|
|
|
|
| |
local_patches section of patchlevel.h.
p4raw-id: //depot/perl@34824
|
|
|
|
|
| |
Message-Id: <200809241407.38389.Richard.Foley@rfi.net>
p4raw-id: //depot/perl@34414
|
|
|
|
|
|
| |
From: Jesse (via RT) <perlbug-followup@perl.org>
Message-ID: <rt-3.6.HEAD-18229-1213543909-1580.55844-75-0@perl.org>
p4raw-id: //depot/perl@34061
|
|
|
| |
p4raw-id: //depot/perl@34020
|
|
|
|
|
|
|
| |
Message-Id: <89557793-48C2-4962-BE7A-24DC2EAFAF15@fsck.com>
(applied to perlbug.PL instead of the generated perlbug)
p4raw-id: //depot/perl@34019
|
|
|
|
|
| |
http://www.cl.cam.ac.uk/~mgk25/ucs/quotes.html
p4raw-id: //depot/perl@33531
|
|
|
| |
p4raw-id: //depot/perl@33375
|
|
|
|
|
|
| |
From: "Vincent Pit" <perl@profvince.com>
Message-ID: <1232.90.46.219.25.1204016219.squirrel@90.46.219.25>
p4raw-id: //depot/perl@33373
|
|
|
|
|
|
| |
their appreciation to perl-thanks@perl.org.
It would be nice to get feedback other than bug reports.
p4raw-id: //depot/perl@33371
|
|
|
|
|
|
| |
Message-ID: <20080116174617.GA30446@abigail.be>
Date: Wed, 16 Jan 2008 18:46:17 +0100
p4raw-id: //depot/perl@32986
|
|
|
|
|
| |
Message-ID: <1367844687.20070712134624@gmail.com>
p4raw-id: //depot/perl@31599
|
|
|
|
|
|
| |
This avoids problem with using STRINGIFY in patchlevel.h
(ref msg <43BE4BAC.6010701@uk.radan.com> posted to p5p).
p4raw-id: //depot/perl@26672
|
|
|
|
|
| |
Message-ID: <20051114000049.GA7676@efn.org>
p4raw-id: //depot/perl@26118
|
|
|
| |
p4raw-id: //depot/perl@25444
|
|
|
|
|
|
|
| |
(Based on a patch from Solar Designer <solar@openwall.com> in
Message-ID: <20040125222218.GA13499@openwall.com>, the bulk of which
was applied as change 22258)
p4raw-id: //depot/perl@22407
|
|
|
|
|
| |
Message-ID: <87fzra7bwi.fsf@vran.herceg.de>
p4raw-id: //depot/perl@18698
|
|
|
|
|
|
|
| |
Message-Id: <200207171604.g6HG4iO03603@crypt.compulink.co.uk>
Correct Hugo's email address.
p4raw-id: //depot/perl@17603
|
|
|
|
|
| |
Message-ID: <20020713074456.M95399-100000@miette.develooper.com>
p4raw-id: //depot/perl@17520
|
|
|
|
|
| |
Message-ID: <17KgXO-0dYZCiC@fwd08.sul.t-online.com>
p4raw-id: //depot/perl@17300
|
|
|
|
|
| |
Message-ID: <Pine.LNX.4.44.0203262107310.2288-100000@hope.stason.org>
p4raw-id: //depot/perl@15515
|