summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* utfebcdic.h: Add synonymous macrosKarl Williamson2011-11-211-0/+2
| | | | I8 is a synonym for 'UTF' in this context, and is more meaningful to me.
* perldiag: constant redef warning is not always defaultFather Chrysostomos2011-11-211-3/+3
| | | | | | If the value of the new constant is the same as the old, this warning only occurs under ‘use warnings 'redefine'’ and $^W=1, not under $^W=0 outside of any warnings scope.
* perlsub: constant redef warning is default, not mandatoryFather Chrysostomos2011-11-211-2/+3
|
* Make constant sub redef warnings obey scopeFather Chrysostomos2011-11-213-10/+18
| | | | | | | | | | | In perldiag, this is listed as (S), which means that outside of any use/no warnings scope it always warns, regardless of $^W. But this warning was ignoring use/no warnings, too. There were actually tests for this oddity, but I think those were added by mistake, or this was just not thought through. I cannot see how this is not a bug.
* autouse.t: suppress warningsFather Chrysostomos2011-11-211-2/+2
|
* Don’t call an early-returning destructorFather Chrysostomos2011-11-211-2/+10
| | | | | | | | | | | | | | | | This speeds things up 2.8 times in my naïve benchmarks. This applies to code like: use constant DEBUG => 1; DESTROY { return unless DEBUG; ... } which gets optimised down to: DESTROY { return; ... } Adding such a destructor will now have almost no impact on speed in production.
* Make newXS redefinition warning respect UTF8Father Chrysostomos2011-11-212-4/+21
|
* Make newCONSTSUB use the right warning scope.Father Chrysostomos2011-11-212-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | newCONSTSUB uses the compile-time warning hints, instead of the run- time hints. This means that use warnings; BEGIN { no warnings; some_XS_function_that_calls_new_CONSTSUB(); } may trigger a redefinition warning, whereas it should be analogous to use warnings; BEGIN { no warnings; *foo = \&bar; } which does not warn. newCONSTSUB localises PL_curcop and sets it to &PL_compiling. When it does that, it needs to copy the hints over. Running tests inside eval is not reliable without a test count, so I added one.
* Restore autouse’s exemption from redef warningsFather Chrysostomos2011-11-216-13/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also restores the subroutine redefinition warning for newly-cre- ated XSUBs outside the autouse package. See below. This commit added the exemption to fix a known bug, that loading a module and importing from it would cause a redefinition warning if there were an autouse stub: perl-5.004_03-1092-g2f34f9d commit 2f34f9d4825ac9262ece854fc4c50479f4838ff8 Author: Ilya Zakharevich <ilya@math.berkeley.edu> Date: Mon Mar 2 16:36:02 1998 -0500 Make autouse -w-safe p4raw-id: //depot/perl@781 The subroutine redefinition warning occurs in three places. This commit removed the autouse exemption from two of them. I can’t see how it wasn’t a mistake, as <5104D4DBC598D211B5FE0000F8FE7EB202D49EE9@mbtlipnt02.btlabs.bt.co.uk> (the apparent source of the patch, makes no mention of it: perl-5.005_02-2920-ge476b1b commit e476b1b5c29f354cf8dad61a9fc6d855bdfb5b7d Author: Gurusamy Sarathy <gsar@cpan.org> Date: Sun Feb 20 22:58:09 2000 +0000 lexical warnings update, ability to inspect bitmask in calling scope, among other things (from Paul Marquess) p4raw-id: //depot/perl@5170 This commit refactored things to remove some compiler warnings, but in doing so reversed the logic of the condition, causing redefini- tion warnings for newly-created XSUBs to apply only to subs from the autouse package: perl-5.8.0-5131-g66a1b24 commit 66a1b24beb76ea873ad4caa57ee3ab9df945afbf Author: Andy Lester <andy@petdance.com> Date: Mon Jun 6 05:11:07 2005 -0500 Random cleanups #47 Message-ID: <20050606151107.GC7022@petdance.com> p4raw-id: //depot/perl@24735 I’ve basically reinstated the changes in 2f34f9d4, but with tests this time. It may not make sense for autouse to be exempt for newATTRSUB and newXS, but keeping the logic surrounding the warning as close as possible to being the same could allow future refactorings to merge them.
* sv.c: I missed a dotFather Chrysostomos2011-11-211-1/+1
|
* Make sort {} and sort {()} equivalentFather Chrysostomos2011-11-212-6/+17
| | | | | | | | | | sub {} and sub{()} are equivalent. In list context they both return the empty list. In scalar context they both return undef. But sort doesn’t seem to think so. It croaks on sub{}. This commit fixes that and makes it consistent. I left XSUBs alone, since I’m not sure how they are supposed to behave.
* Merge remote-tracking branch 'p5p/smoke-me/gsoc-pod' into bleadRicardo Signes2011-11-2031-2109/+5269
|\
| * Dynamically create and delete testdir/test.lib/smoke-me/gsoc-podMarc Green2011-10-3113-72/+138
| | | | | | | | | | | | | | Due to the '.' in 'test.lib's name, t/filenames.t fails (because '.' is the path separator on VMS). To fix this, I create and delete the directory and its contents during each test that needs to access the directory. Said tests will be skipped if the directory cannot be created (e.g., on VMS).
| * Update known_pod_issuesMarc Green2011-10-311-10/+10
| |
| * Add Marc Green an an AUTHOR of Pod::HtmlMarc Green2011-10-311-1/+3
| |
| * Update known_pod_issuesMarc Green2011-10-311-8/+12
| | | | | | | | (updated to ignore perlvar/perlpodspec issues)
| * Rename 2 tests, update files that reference themMarc Green2011-10-3115-27/+27
| | | | | | | | This fixes the podcheck error complaining about their filenames
| * Update version number (1.11 -> 1.12)Marc Green2011-10-311-1/+1
| |
| * add new Pod-Html tests (etc) to MANIFESTRicardo Signes2011-10-311-0/+22
| |
| * add Marc Green to AUTHORSRicardo Signes2011-10-311-0/+1
| |
| * Clean up some documentationMarc Green2011-10-311-6/+5
| |
| * Clean up test cases, rename a fewMarc Green2011-10-3121-86/+66
| |
| * Stop prepending $volume onto $cwd --podrootMarc Green2011-10-311-1/+1
| | | | | | | | $cwd already includes $volume
| * Unixify the whole path, not just $dir.$fileMarc Green2011-10-311-2/+1
| |
| * Fix crossref cross platform compatability issuesMarc Green2011-10-3110-65/+106
| | | | | | | | | | | | | | I added a whole bunch of "File::Spec"s and "File::Spec::Unix"s and I updated the test cases and test harness to be platform independent. I also updated some documentation in Pod::Html and removed some unneeded code.
| * Fix crossref bugMarc Green2011-10-312-22/+20
| | | | | | | | Take into account Windows paths in Podroot and Podpath
| * Tabs -> SpacesMarc Green2011-10-312-141/+88
| |
| * Implement option to disable POD ERRORS sectionMarc Green2011-10-315-39/+215
| |
| * Remove unneeded codeMarc Green2011-10-311-4/+1
| |
| * Stop using wrong outfileMarc Green2011-10-311-1/+1
| |
| * Add a test caseMarc Green2011-10-312-0/+76
| |
| * Remove /usr/share/perl presence dependencyMarc Green2011-10-315-16/+3661
| |
| * Update htmlview.t for new Pod::HtmlMarc Green2011-10-312-103/+183
| |
| * Update test case for new Pod::HtmlMarc Green2011-10-311-73/+103
| |
| * Don't uc(), keep case the sameMarc Green2011-10-311-1/+1
| |
| * Implement --recurse and update test casesMarc Green2011-10-315-9/+29
| |
| * Fix bug with removal of Podroot from each PodpathMarc Green2011-10-311-2/+7
| | | | | | | | | | Correct the lack of possible offset when removing Podroot from each Podpath to account for a trailing slash in Podroot.
| * Always anchor =item definitions.Marc Green2011-10-311-0/+1
| |
| * Update htmlfeature2.t for new p2hMarc Green2011-10-311-28/+24
| |
| * Update htmlfeature.t for new p2h; fix typo in HtmlMarc Green2011-10-313-30/+20
| |
| * Update old-p2h to new-p2h script conversionMarc Green2011-10-311-13/+12
| | | | | | | | | | It converts more and correctly converts anchored =head directives and index elements
| * Fix --backlink bug; add some documentationMarc Green2011-10-311-4/+10
| | | | | | | | | | The bug prevented '<body id="_podtop_">' from appearing when --backlink was enabled
| * Update htmlescp.t test case for new Pod::HtmlMarc Green2011-10-311-24/+16
| | | | | | | | | | Note that it uses <b> instead of <strong>, <i> instead of <em>, and converts E<> formatting codes before they are written to .html
| * Fix typo in test caseMarc Green2011-10-311-1/+1
| |
| * Update htmldir4.t to test new Pod::HtmlMarc Green2011-10-311-23/+20
| |
| * Update htmldir2.t and htmldir3.t to test new p2hMarc Green2011-10-312-46/+40
| |
| * Use catdir (not catfile) to avoid a leading '//'Marc Green2011-10-311-1/+2
| |
| * Add old-p2h test to new-p2h test conversion scriptMarc Green2011-10-311-0/+53
| | | | | | | | | | The script does basic conversion of old Pod::HTMl test cases to new Pod::Html test cases.
| * Fix bug dealing with PODS not in %PagesMarc Green2011-10-311-4/+4
| | | | | | | | | | | | | | The bug inhibited finding replacement paths for POD documents not found in %Pages. Update the accompanying warning message, too.
| * Update htmldir.t testcase for new Pod::HtmlMarc Green2011-10-311-23/+20
| |