summaryrefslogtreecommitdiff
path: root/x2p
diff options
context:
space:
mode:
authorMartin Becker <mhasch@cpan.org>2011-05-18 18:15:40 -0700
committerFather Chrysostomos <sprout@cpan.org>2011-05-18 20:13:33 -0700
commitbdec6fb964eb42f18da855b242ed847e2a58d20b (patch)
treea7d11122853cf841960305030b16c29b4c797246 /x2p
parent5d104d5079db727bb10215a37819b26cc1d8121a (diff)
downloadperl-bdec6fb964eb42f18da855b242ed847e2a58d20b.tar.gz
[perl #88496] missing dependencies in perl core makefiles
I have spotted a couple of missing dependencies in the makefiles utils/Makefile.SH and x2p/Makefile.SH that prevent json_pp, s2p, psed, and find2perl from being rebuilt after configuration changes. This could cause trouble if the install prefix has been changed, so that the shebang line of these scripts from a previous build no longer matches the target location of the perl binary. A workaround would be to always "make clean" after changes to the configuration, which sounds reasonable anyway. That said, most of the other tools do have config.sh properly listed as a dependency and I don't see why those four should not. I have attached a small patch against perl-5.13.11 to fix this. The bug is also present in the latest stable release as of this writing, perl-5.12.3, except that json_pp is not included there.
Diffstat (limited to 'x2p')
-rwxr-xr-xx2p/Makefile.SH4
1 files changed, 2 insertions, 2 deletions
diff --git a/x2p/Makefile.SH b/x2p/Makefile.SH
index 127d6f922f..800f583db3 100755
--- a/x2p/Makefile.SH
+++ b/x2p/Makefile.SH
@@ -185,9 +185,9 @@ shlist:
$(plextract):
$(RUN) $(PERL) -I../lib $@.PL
-find2perl: find2perl.PL
+find2perl: find2perl.PL ../config.sh
-s2p: s2p.PL
+s2p: s2p.PL ../config.sh
malloc.c: ../malloc.c
rm -f malloc.c