sprinkle NOTREACHED and FALLTHROUGH

Coverity complains bitterly about many switch statements in lots of files.

Many of these are of the form:

    case FOO:
        ...
        goto baz;
    case BAR:
        ....

and something as smart as Coverity shouldn't really be complaining about
a missing 'break' when the last statement of the previous branch is an
unconditional goto/return/continue. But I've shoved in a bunch of
'NOTREACHED' to hopefully shut it up.

Missing 'FALLTHROUGH' comments were more reasonable, and I've added them
where appropriate.

The only confusing one was cx_dup(), where the various CXt_LOOP_ branches
all fell through to the next one, and it took a while to figure out that
those weren't bugs.

1 files changed, 3 insertions, 0 deletions

diff --git a/perl.c b/perl.c
index d41ebedc97..1a603ae663 100644
--- a/perl.c
+++ b/perl.c
@@ -3206,9 +3206,12 @@ Perl_moreswitches(pTHX_ const char *s)
 	for (s++; isWORDCHAR(*s); s++) ;
 #endif
 	return s;
+        NOT_REACHED; /* NOTREACHED */
     }	
     case 'h':
 	usage();
+        NOT_REACHED; /* NOTREACHED */
+
     case 'i':
 	Safefree(PL_inplace);
 #if defined(__CYGWIN__) /* do backup extension automagically */