op.c: Calculate hash for CvNAME_HEK

I assumed when I wrote that code that share_hek would calculate the
hash, like most hash functions; but this internal function assumes
the caller does it.

Hence, CVs were not sharing their heks with other types of thingies
that have heks.  A CV named foo and a GV named foo would cause two
heks of the same name to be present in the shared string table.

1 files changed, 4 insertions, 1 deletions

diff --git a/pad.c b/pad.c
index 42f373450f..68e1078904 100644
--- a/pad.c
+++ b/pad.c
@@ -2092,13 +2092,16 @@ S_cv_clone_pad(pTHX_ CV *proto, CV *cv, CV *outside, bool newcv)
 			/* my sub */
 			/* Just provide a stub, but name it.  It will be
 			   upgrade to the real thing on scope entry. */
+			U32 hash;
+			PERL_HASH(hash, SvPVX_const(namesv)+1,
+				  SvCUR(namesv) - 1);
 			sv = newSV_type(SVt_PVCV);
 			CvNAME_HEK_set(
 			    sv,
 			    share_hek(SvPVX_const(namesv)+1,
 				      SvCUR(namesv) - 1
 					 * (SvUTF8(namesv) ? -1 : 1),
-				      0)
+				      hash)
 			);
 		    }
 		    else sv = SvREFCNT_inc(ppad[ix]);