summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorNicholas Clark <nick@ccl4.org>2012-02-07 16:59:23 +0100
committerNicholas Clark <nick@ccl4.org>2012-02-08 17:59:32 +0100
commit1a87ef38d274e06b5f822ca3e4e88b08e8f01c94 (patch)
tree622322c139b4ca58f05fb49ec09029d1deb61aa6 /lib
parentb70d370eef9e421be0a8c1c65beb8ca59c8f15ab (diff)
downloadperl-1a87ef38d274e06b5f822ca3e4e88b08e8f01c94.tar.gz
Convert triplicated code in lib/Pod/t/eol.t to a loop.
Diffstat (limited to 'lib')
-rw-r--r--lib/Pod/t/eol.t50
1 files changed, 13 insertions, 37 deletions
diff --git a/lib/Pod/t/eol.t b/lib/Pod/t/eol.t
index 784608a1c1..a159fb7551 100644
--- a/lib/Pod/t/eol.t
+++ b/lib/Pod/t/eol.t
@@ -36,44 +36,20 @@ close $pod or die $!;
use Pod::Html;
-# --- CR ---
-
-open $pod, '<', $podfile or die "$podfile: $!";
-open my $in, '>', $infile or die "$infile: $!";
-while (<$pod>) {
- s/[\r\n]+/\r/g;
- print $in $_;
-}
-close $pod or die $!;
-close $in or die $!;
-
-pod2html("--title=eol", "--infile=$infile", "--outfile=$outfile[0]");
-
-# --- LF ---
-
-open $pod, '<', $podfile or die "$podfile: $!";
-open $in, '>', $infile or die "$infile: $!";
-while (<$pod>) {
- s/[\r\n]+/\n/g;
- print $in $_;
-}
-close $pod or die $!;
-close $in or die $!;
-
-pod2html("--title=eol", "--infile=$infile", "--outfile=$outfile[1]");
-
-# --- CRLF ---
+my $i = 0;
+foreach my $eol ("\r", "\n", "\r\n") {
+ open $pod, '<', $podfile or die "$podfile: $!";
+ open my $in, '>', $infile or die "$infile: $!";
+ while (<$pod>) {
+ s/[\r\n]+/$eol/g;
+ print $in $_;
+ }
+ close $pod or die $!;
+ close $in or die $!;
-open $pod, '<', $podfile or die "$podfile: $!";
-open $in, '>', $infile or die "$infile: $!";
-while (<$pod>) {
- s/[\r\n]+/\r\n/g;
- print $in $_;
+ pod2html("--title=eol", "--infile=$infile", "--outfile=$outfile[$i]");
+ ++$i;
}
-close $pod or die $!;
-close $in or die $!;
-
-pod2html("--title=eol", "--infile=$infile", "--outfile=$outfile[2]");
# --- now test ---
@@ -81,7 +57,7 @@ my @cksum;
foreach (0..2) {
local $/;
- open $in, '<', $outfile[$_] or die "$outfile[$_]: $!";
+ open my $in, '<', $outfile[$_] or die "$outfile[$_]: $!";
$cksum[$_] = unpack "%32C*", <$in>;
close $in or die $!;
}