summaryrefslogtreecommitdiff
path: root/gv.c
diff options
context:
space:
mode:
authorJarkko Hietaniemi <jhi@iki.fi>2014-05-04 19:44:24 -0400
committerSteffen Mueller <smueller@cpan.org>2014-05-28 19:27:22 +0200
commitc67159e16ee2c8d23fc3c3a55448ffbda709b3f6 (patch)
treee490fd9d5327e9f7519b1a0d3578baff4d241600 /gv.c
parenta482c76f48270e80f77784f6a08d244af9b26d7e (diff)
downloadperl-c67159e16ee2c8d23fc3c3a55448ffbda709b3f6.tar.gz
Annotate intentional case fallthrough, or add breaks.
Fix suspicious (*) switch cases found by Coverity by annotating with either "/* FALLTHROUGH */" or adding a break; The FALLTHROUGH was much more common, but the break turned out to be the right choice in three spots. All changes tested to work. (*) suspicious = case1 + code + case2, and neither flow control (like break) nor fallthrough annotation between code and case2. Fix for Coverity perl5 CIDs 28977..28989, 45353.
Diffstat (limited to 'gv.c')
-rw-r--r--gv.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/gv.c b/gv.c
index e402f6bf72..1f36d31ffd 100644
--- a/gv.c
+++ b/gv.c
@@ -353,6 +353,7 @@ Perl_gv_init_pvn(pTHX_ GV *gv, HV *stash, const char *name, STRLEN len, U32 flag
case SVt_PVIO:
Perl_croak(aTHX_ "Cannot convert a reference to %s to typeglob",
sv_reftype(has_constant, 0));
+ break;
default: NOOP;
}
SvRV_set(gv, NULL);