diff options
| author | Father Chrysostomos <sprout@cpan.org> | 2011-10-25 17:56:32 -0700 |
|---|---|---|
| committer | Father Chrysostomos <sprout@cpan.org> | 2011-10-26 18:22:18 -0700 |
| commit | d67594ff366291f164fb41e4dcc791494ec4bb0e (patch) | |
| tree | 3ec3aa27ad2ba46ff773fe14e6a18e31c4882b07 /ext/File-Glob | |
| parent | 1bb8785ab1af03172a3a220f8948d33bdc3dd374 (diff) | |
| download | perl-d67594ff366291f164fb41e4dcc791494ec4bb0e.tar.gz | |
Fix CORE::glob
This commit makes CORE::glob bypassing glob overrides.
A side effect of the fix is that, with the default glob implementa-
tion, undefining *CORE::GLOBAL::glob no longer results in an ‘unde-
fined subroutine’ error.
Another side effect is that compilation of a glob op no longer assumes
that the loading of File::Glob will create the *CORE::GLOB::glob type-
glob. ‘++$INC{"File/Glob.pm"}; sub File::Glob::csh_glob; eval '<*>';’
used to crash.
This is accomplished using a mechanism similar to lock() and
threads::shared. There is a new PL_globhook interpreter varia-
ble that pp_glob calls when there is no override present. Thus,
File::Glob (which is supposed to be transparent, as it *is* the
built-in implementation) no longer interferes with the user mechanism
for overriding glob.
This removes one tier from the five or so hacks that constitute glob’s
implementation, and which work together to make it one of the buggiest
and most inconsistent areas of Perl.
Diffstat (limited to 'ext/File-Glob')
| -rw-r--r-- | ext/File-Glob/Glob.xs | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/ext/File-Glob/Glob.xs b/ext/File-Glob/Glob.xs index 2a9fbb027f..a5f531d68f 100644 --- a/ext/File-Glob/Glob.xs +++ b/ext/File-Glob/Glob.xs @@ -321,6 +321,10 @@ BOOT: { CV *cv = newXS("File::Glob::bsd_glob", XS_File__Glob_doglob, __FILE__); XSANY.any_i32 = 1; +#ifndef PERL_EXTERNAL_GLOB + /* Don’t do this at home! The globhook interface is highly volatile. */ + PL_globhook = csh_glob; +#endif } BOOT: |