summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobin Barker <rmbarker@cpan.org>2011-09-07 22:22:42 +0100
committerFather Chrysostomos <sprout@cpan.org>2011-09-08 08:24:31 -0700
commit14f0f125b45b58bbf2d9e275abf2fef1655f8a3e (patch)
treed1f498a7896c607ac46e1b049fbffa0848aa5bac
parentf8ccc5c641d025d213119510fd38619b06273044 (diff)
downloadperl-14f0f125b45b58bbf2d9e275abf2fef1655f8a3e.tar.gz
remove unused variables and assignments
and silences some compiler warnings. I do not understand the code in toke.c but the change aligns the code with other uses of FUN0OP, it has no warnings and does not break any test.
-rw-r--r--op.c3
-rw-r--r--pp.c3
-rw-r--r--toke.c3
3 files changed, 3 insertions, 6 deletions
diff --git a/op.c b/op.c
index 2dff0593ed..7e1360cc7e 100644
--- a/op.c
+++ b/op.c
@@ -9292,10 +9292,9 @@ Perl_ck_entersub_args_core(pTHX_ OP *entersubop, GV *namegv, SV *protosv)
PERL_ARGS_ASSERT_CK_ENTERSUB_ARGS_CORE;
if (!opnum) {
- OP *prev, *cvop;
+ OP *cvop;
if (!aop->op_sibling)
aop = cUNOPx(aop)->op_first;
- prev = aop;
aop = aop->op_sibling;
for (cvop = aop; cvop->op_sibling; cvop = cvop->op_sibling) ;
if (PL_madskills) while (aop != cvop && aop->op_type == OP_STUB) {
diff --git a/pp.c b/pp.c
index c732c5ba86..ba337b25f6 100644
--- a/pp.c
+++ b/pp.c
@@ -155,12 +155,11 @@ static SV *
S_rv2gv(pTHX_ SV *sv, const bool vivify_sv, const bool strict,
const bool noinit)
{
- dSP; dVAR;
+ dVAR;
if (!isGV(sv) || SvFAKE(sv)) SvGETMAGIC(sv);
if (SvROK(sv)) {
if (SvAMAGIC(sv)) {
sv = amagic_deref_call(sv, to_gv_amg);
- SPAGAIN;
}
wasref:
sv = SvRV(sv);
diff --git a/toke.c b/toke.c
index 1bf7e18c86..604934e463 100644
--- a/toke.c
+++ b/toke.c
@@ -6927,8 +6927,7 @@ Perl_yylex(pTHX)
case KEY___FILE__:
FUN0OP(
- pl_yylval.opval = (OP*)newSVOP(OP_CONST, 0,
- newSVpv(CopFILE(PL_curcop),0))
+ (OP*)newSVOP(OP_CONST, 0, newSVpv(CopFILE(PL_curcop),0))
);
case KEY___LINE__: