summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSteffen Mueller <smueller@cpan.org>2011-09-06 08:20:54 +0200
committerSteffen Mueller <smueller@cpan.org>2011-09-06 08:43:26 +0200
commit65aad273380da9c83f76e24d48ee5df7a03ee888 (patch)
treefb2ac3b2aea1b357e9392aec5042619fc11296c7
parent985b9e549fd484800c8e9aae896e5e9c5b04d148 (diff)
downloadperl-65aad273380da9c83f76e24d48ee5df7a03ee888.tar.gz
ExtUtils::ParseXS: Fix INCLUDE: $cmd |
INCLUDE: $cmd | is the old, deprecated way of reading the output of a command into a stream of XS code. Unfortunately, it was accidentally broken by fe7ae66bc2e4a8bbc90ba0d852e511116d6e97bb by replacing the two-arg open with a three-arg open that opens in read-mode. This change fixes the issue, reported as CPAN RT #70213.
-rw-r--r--dist/ExtUtils-ParseXS/Changes2
-rw-r--r--dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm2
2 files changed, 3 insertions, 1 deletions
diff --git a/dist/ExtUtils-ParseXS/Changes b/dist/ExtUtils-ParseXS/Changes
index 0556dfa578..be780b054a 100644
--- a/dist/ExtUtils-ParseXS/Changes
+++ b/dist/ExtUtils-ParseXS/Changes
@@ -1,5 +1,7 @@
Revision history for Perl extension ExtUtils::ParseXS.
+ - Fixed "INCLUDE: $cmd |", CPAN RT #70213
+
3.04_03 - Sun Sep 4 18:49:00 CET 2011
- By #defining PERL_EUPXS_ALWAYS_EXPORT or
diff --git a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
index 1d9a85fbca..36b88a5b39 100644
--- a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
+++ b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
@@ -1540,7 +1540,7 @@ sub INCLUDE_handler {
$self->{FH} = Symbol::gensym();
# open the new file
- open ($self->{FH}, '<', $_) or $self->death("Cannot open '$_': $!");
+ open($self->{FH}, $_) or $self->death("Cannot open '$_': $!");
print Q(<<"EOF");
#