summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthew Wilcox <willy@linux.intel.com>2015-04-22 16:27:21 -0400
committerMartin Mares <mj@ucw.cz>2015-09-14 16:43:15 +0200
commit90ec4a6d0ae85ccd018be3da2d080f602fc56ca7 (patch)
tree0794a59d692d0442f1bc191eb5f644f1359e200a
parentc8b1fb09a992a76e0d7fd30bf291e95c5033b71d (diff)
downloadpciutils-90ec4a6d0ae85ccd018be3da2d080f602fc56ca7.tar.gz
Report NUMA node in lspci -v
In multi-socket systems, it's useful to see which node a particular PCI device belongs to. Linux provides this information through sysfs, but some users don't like poking through sysfs themselves to find it, and it's pretty straightforward to report it in lspci. I should note that when there is no NUMA node for a particular device, Linux reports -1. I've chosen to continue that convention in pciutils, and simply omit the information if the device does not belong to a NUMA node (eg on single-socket systems, or devices which are not preferentially attached to a particular node, like Nehalem-based systems).
-rw-r--r--lib/access.c1
-rw-r--r--lib/pci.h1
-rw-r--r--lib/sysfs.c1
-rw-r--r--lspci.c2
4 files changed, 5 insertions, 0 deletions
diff --git a/lib/access.c b/lib/access.c
index d292085..a547d2c 100644
--- a/lib/access.c
+++ b/lib/access.c
@@ -28,6 +28,7 @@ pci_alloc_dev(struct pci_access *a)
d->access = a;
d->methods = a->methods;
d->hdrtype = -1;
+ d->numa_node = -1;
if (d->methods->init_dev)
d->methods->init_dev(d);
return d;
diff --git a/lib/pci.h b/lib/pci.h
index bd6f6a1..0ccfbe3 100644
--- a/lib/pci.h
+++ b/lib/pci.h
@@ -127,6 +127,7 @@ struct pci_dev {
u16 vendor_id, device_id; /* Identity of the device */
u16 device_class; /* PCI device class */
int irq; /* IRQ number */
+ int numa_node; /* NUMA node */
pciaddr_t base_addr[6]; /* Base addresses including flags in lower bits */
pciaddr_t size[6]; /* Region sizes */
pciaddr_t rom_base_addr; /* Expansion ROM base address */
diff --git a/lib/sysfs.c b/lib/sysfs.c
index 9f348bb..800fb4e 100644
--- a/lib/sysfs.c
+++ b/lib/sysfs.c
@@ -192,6 +192,7 @@ static void sysfs_scan(struct pci_access *a)
{
sysfs_get_resources(d);
d->irq = sysfs_get_value(d, "irq");
+ d->numa_node = sysfs_get_value(d, "numa_node");
/*
* We could read these faster from the config registers, but we want to give
* the kernel a chance to fix up ID's and especially classes of broken devices.
diff --git a/lspci.c b/lspci.c
index 6f16142..a78eb26 100644
--- a/lspci.c
+++ b/lspci.c
@@ -757,6 +757,8 @@ show_verbose(struct device *d)
printf(", latency %d", latency);
if (irq)
printf(", IRQ " PCIIRQ_FMT, irq);
+ if (p->numa_node != -1)
+ printf(", NUMA node %d", p->numa_node);
putchar('\n');
}