summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOctavian Ciuhandu <ociuhandu@cloudbasesolutions.com>2014-03-18 19:54:00 +0200
committerOctavian Ciuhandu <ociuhandu@cloudbasesolutions.com>2014-03-19 01:52:57 +0200
commitaf4c193250c891af3d50973aaf995b6279fda0a1 (patch)
tree79d2adca36921bcec0a1c668ed66d5d2248d7859
parent6ffff7c95706e3a39e82fa0362e825aab21cbb26 (diff)
downloadpbr-af4c193250c891af3d50973aaf995b6279fda0a1.tar.gz
Fixes blocking issue on Windows
On Windows, environment variables can not be unicode. Change-Id: I8c7fd7627d7f733e0db8690a39e7128b7fe2ebcf Closes-bug: #1294246
-rw-r--r--pbr/packaging.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/pbr/packaging.py b/pbr/packaging.py
index c39f5f7..21b2b82 100644
--- a/pbr/packaging.py
+++ b/pbr/packaging.py
@@ -87,9 +87,11 @@ def _pip_install(links, requires, root=None, option_dict=dict()):
for link in links:
cmd.append("-f")
cmd.append(link)
+
+ # NOTE(ociuhandu): popen on Windows does not accept unicode strings
_run_shell_command(
cmd + requires,
- throw_on_error=True, buffer=False, env=dict(PIP_USE_WHEEL="true"))
+ throw_on_error=True, buffer=False, env=dict(PIP_USE_WHEEL=b"true"))
def _any_existing(file_list):