diff options
author | Robert Collins <rbtcollins@hp.com> | 2014-03-12 19:16:59 +1300 |
---|---|---|
committer | Robert Collins <rbtcollins@hp.com> | 2014-03-13 15:00:33 +1300 |
commit | 406667beee8fcb69161744d7c52532487c18c753 (patch) | |
tree | 14df70fb375f8299889ecd545353f51d4369acb4 | |
parent | 68e88965b6ed36bc97c27372aa6c410518af7e1a (diff) | |
download | pbr-406667beee8fcb69161744d7c52532487c18c753.tar.gz |
Fix up some docstrings.
The version.py docstrings were a) not PEP compliant and b) somewhat
out of sync with the code.
Change-Id: I87c4134ef80fd9e6fd57b66c58c3c5920ee0b6b6
-rw-r--r-- | pbr/version.py | 23 |
1 files changed, 14 insertions, 9 deletions
diff --git a/pbr/version.py b/pbr/version.py index 87a5ca9..9a3b653 100644 --- a/pbr/version.py +++ b/pbr/version.py @@ -25,6 +25,7 @@ class VersionInfo(object): def __init__(self, package): """Object that understands versioning for a package + :param package: name of the python package, such as glance, or python-glanceclient """ @@ -42,8 +43,11 @@ class VersionInfo(object): return "VersionInfo(%s:%s)" % (self.package, self.version_string()) def _get_version_from_pkg_resources(self): - """Get the version of the package from the pkg_resources record - associated with the package. + """Obtain a version from pkg_resources or setup-time logic if missing. + + This will try to get the version of the package from the pkg_resources + record associated with the package, and if there is no such record + falls back to the logic sdist would use. """ try: requirement = pkg_resources.Requirement.parse(self.package) @@ -57,8 +61,9 @@ class VersionInfo(object): return packaging.get_version(self.package) def release_string(self): - """Return the full version of the package including suffixes indicating - VCS status. + """Return the full version of the package. + + This including suffixes indicating VCS status. """ if self.release is None: self.release = self._get_version_from_pkg_resources() @@ -83,11 +88,11 @@ class VersionInfo(object): version_string_with_vcs = release_string def cached_version_string(self, prefix=""): - """Generate an object which will expand in a string context to - the results of version_string(). We do this so that don't - call into pkg_resources every time we start up a program when - passing version information into the CONF constructor, but - rather only do the calculation when and if a version is requested + """Return a cached version string. + + This will return a cached version string if one is already cached, + irrespective of prefix. If none is cached, one will be created with + prefix and then cached and returned. """ if not self._cached_version: self._cached_version = "%s%s" % (prefix, |