| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
| |
This fixes a problem where ‘gcc -fanalyzer -flto’ (GCC 10)
complained that sys_reset_uid_gid was defined but not used in some
modules. This function belonged in a .c file anyway.
* lib/rtapelib.c (sys_reset_uid_gid):
* paxlib/rtape.c (sys_reset_uid_gid):
Move here from system.h. The code is now duplicated, but so is
most of the rest of this file anyway.
* lib/system.h (sys_reset_uid_gid): Remove.
|
| |
|
|
|
|
|
|
|
|
| |
* lib/rtapelib.c (rmt_ioctl__):
* paxlib/rtape.c (rmt_ioctl):
Arg is now of type unsigned long int, not int. This works better
on GNU/Linux, where some ioctl values used by this code do not fit
in int. FreeBSD ioctl also has unsigned long int here, and old
hosts where it’s int should still work when this is unsigned long
int. Problem reported by clang.
|
| |
|
|
|
|
|
|
| |
* lib/system.h (sys_reset_uid_gid) [!MSDOS]: On failure, instead
of invoking FATAL_ERROR set errno and return the name of the
syscall that failed, so that the caller can decide what to do.
This avoids some GNU Tar linking problems on compilers that do not
inline this function. All callers changed.
|
| |
|
|
|
|
|
|
|
| |
Gnulib now defines _Noreturn for us on pre-C11 compilers,
so use that instead of the less-portable __attribute__ ((noreturn)).
* lib/system.h (__attribute__): Remove; no longer used.
* paxlib/paxlib.h: Use _Noreturn instead of __attribute__ ((noreturn)).
* paxtest/paxtest.c (dump): First arg is char *,
not unsigned char *, to avoid type mismatch.
|
| |
|
|
|
|
|
| |
* paxlib/error.c (error_hook): New global.
* paxlib/paxlib.h (error_hook): New extern.
(WARN, ERROR, FATAL_ERROR)
(USAGE_ERROR): Call error_hook (if defined) before error().
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
* paxlib/DISTFILES: Add exit-status.c.
* paxlib/Makefile.am (libpax_a_SOURCES): Add exit-status.c.
* paxlib/exit-status.c: New file.
* paxlib/exit.c (exit_status): Move to exit-status.c.
* paxlib/names.c (hash_string_insert, hash_string_lookup): Remove.
* paxlib/paxlib.h: Don't include hash.h.
(hash_string_insert, hash_string_lookup): Remove.
|
| |
|
|
|
|
|
|
| |
* paxlib/paxlib.h (pax_exit): Remove stray semicolon that I
introduced in the previous patch; sorry about that.
* tests/genfile.c (print_stat): Don't assume that mode_t
promotes to unsigned int when calling a varargs function;
that assumption is not portable.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
* lib/rtapelib.c (do_command, rmt_write__): Use function
prototypes instead of old-style decls.
* paxlib/error.c (write_fatal): Remove unused and undeclared
function.
* paxlib/paxlib.h (stat_fatal, pax_exit): Add noreturn attribute.
(write_error_details): New decl.
* rmt/rmt.c (rmt_read, rmt_write, rmt_reply, rmt_error_message):
(rmt_error, xlat_kw, skip_ws, decode_open_flag, close_device):
(lseek_device, read_device, write_device, iocop_device, status_device):
Declare as static, since they're not exported.
Use function prototypes (void) instead of old-style decls ().
|
| | |
|
| | |
|
| |
|
|
|
|
| |
(hash_string_insert): Rewrite using hash_string_insert_prefix
(safer_name_suffix): Use hash_string_insert_prefix to avoid
stack allocation. Bug reported by Dmitry V. Levin
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
when linking on Darwin. Reported by EXCOFFIER, Denis
<denis.excoffier@airbus.com>.
|
| |
|
|
|
|
|
|
|
|
| |
* lib/system.h: Move the MTIO* stuff into....
* lib/system-ioctl.h: New file. That way, the symbols defined
by these includes won't collide with the symbols defined by
<sys/filio.h> on Solaris when compiling misc.c.
* lib/rtapelib.c: Include system-ioctl.h.
* paxlib/rtape.c: Likewise.
* rmt/rmt.c: Likewise.
|
| |
|
|
|
|
|
|
|
|
| |
is always defined now.
* paxlib/rtape.c (encode_oflag): Likewise.
* lib/system.h (O_DIRCTORY, O_NOATIME, O_NONBLOCK): Define to 0
if not already defined.
* paxlib/error.c (rmdir_error): New function.
* paxlib/error.h (rmdir_error): New decl.
* rmt/rmt.c (decode_oflag): Use '#if O_NONBLOCK", not ifdef.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* gnulib.modules: Add inttostr, quote, quotearg.
* lib/system.h (TYPE_SIGNED, TYPE_MINIMUM, TYPE_MAXIMUM): Remove.
(INT_STRLEN_BOUND): Remove.
Include "intprops.h" instead.
(UINTMAX_STRSIZE_BOUND): Define in terms of INT_BUFSIZE_BOUND,
not INT_STRLEN_BOUND.
[HAVE_UTIME_H]: Don't include utime.h.
* paxlib/DISTFILES: Remove convert.c.
* paxlib/convert.c: Remove.
* paxlib/error.c: Include quote.h, quotearg.h.
* paxlib/paxlib.h: Include inttostr.h.
(STRINGIFY_BIGINT): Define in terms of umaxtostr.
(stringify_uintmax_t_backwards): Remove decl.
* tests/genfile.c: Include <utimens.h> instead of rolling our own.
(exec_checkpoint): Use utimens instead of rolling our own.
Don't pass extra args to error.
(main): Wrap message inside _().
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
