diff options
| author | Eelco Chaudron <echaudro@redhat.com> | 2023-02-07 15:05:25 +0100 |
|---|---|---|
| committer | Ilya Maximets <i.maximets@ovn.org> | 2023-02-09 00:43:36 +0100 |
| commit | adac28dcdf377a6ef8200aac121a1cd383f69a58 (patch) | |
| tree | 6bcf66fe9b589ead0b132fcab4e337bec40fdd2e | |
| parent | a1c2abba785324972a8824cc71cea3c8ca68cadc (diff) | |
| download | openvswitch-adac28dcdf377a6ef8200aac121a1cd383f69a58.tar.gz | |
netdev-offload-tc: Conntrack ALGs are not supported with tc.
tc does not support conntrack ALGs. Even worse, with tc enabled, they
should not be used/configured at all. This is because even though TC
will ignore the rules with ALG configured, i.e., they will flow through
the kernel module, return traffic might flow through a tc conntrack
rule, and it will not invoke the ALG helper.
Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack support")
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
Acked-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Tested-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
| -rw-r--r-- | lib/netdev-offload-tc.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index c68361da0..19eae7bd2 100644 --- a/lib/netdev-offload-tc.c +++ b/lib/netdev-offload-tc.c @@ -1303,6 +1303,10 @@ parse_put_flow_ct_action(struct tc_flower *flower, get_32aligned_u128(&ct_label->mask); } break; + /* The following option we do not support in tc-ct, and should + * not be ignored for proper operation. */ + case OVS_CT_ATTR_HELPER: + return EOPNOTSUPP; } } |