summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTimothy Redaelli <tredaelli@redhat.com>2020-08-06 18:33:50 +0200
committerIlya Maximets <i.maximets@ovn.org>2020-08-26 21:26:38 +0200
commit8cc9803c35bf646365e4149a3775a9c9e8f4caf8 (patch)
tree8cde04cf966f05f7c3659cc686cf2f5f998ae548
parentc935d369c807d751627f0859d462d8a7a04d43af (diff)
downloadopenvswitch-8cc9803c35bf646365e4149a3775a9c9e8f4caf8.tar.gz
meta-flow: fix a typo in "MPLS Bottom of Stack Field" paragraph.
In the ovs-fields.7 manual page, the "MPLS Bottom of Stack Field" paragraph says: * When mpls_bos is 1, there is another MPLS label following this one, so the Ethertype passed to pop_mpls should be an MPLS Ethertype. [...] * When mpls_bos is 0, this MPLS label is the last one, so the Ethertype passed to pop_mpls should be a non-MPLS Ethertype such as IPv4. [...] The values 0 and 1 have been swapped: when BOS is 1, then no more label stack entries follows. Fixes: 96fee5e0a2a0 ("ovs-fields: New manpage to document Open vSwitch and OpenFlow fields.") Reported-at: https://bugzilla.redhat.com/1842032 Reported-by: Guillaume Nault <gnault@redhat.com> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> Acked-by: Greg Rose <gvrose8192@gmail.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
-rw-r--r--lib/meta-flow.xml8
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/meta-flow.xml b/lib/meta-flow.xml
index 0b5c1d008..e1b32d6ab 100644
--- a/lib/meta-flow.xml
+++ b/lib/meta-flow.xml
@@ -3835,18 +3835,18 @@ r r c c c.
<ul>
<li>
- When <ref field="mpls_bos"/> is 1, there is another MPLS label
+ When <ref field="mpls_bos"/> is 0, there is another MPLS label
following this one, so the Ethertype passed to <code>pop_mpls</code>
should be an MPLS Ethertype. For example: <code>table=0,
- dl_type=0x8847, mpls_bos=1, actions=pop_mpls:0x8847,
+ dl_type=0x8847, mpls_bos=0, actions=pop_mpls:0x8847,
goto_table:1</code>
</li>
<li>
- When <ref field="mpls_bos"/> is 0, this MPLS label is the last one,
+ When <ref field="mpls_bos"/> is 1, this MPLS label is the last one,
so the Ethertype passed to <code>pop_mpls</code> should be a non-MPLS
Ethertype such as IPv4. For example: <code>table=1, dl_type=0x8847,
- mpls_bos=0, actions=pop_mpls:0x0800, goto_table:2</code>
+ mpls_bos=1, actions=pop_mpls:0x0800, goto_table:2</code>
</li>
</ul>
</field>