summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Revert "Add retries to fetching the zookeeper server version""0.7.1Jenkins2015-02-164-92/+3
|\
| * Revert "Add retries to fetching the zookeeper server version"Joshua Harlow2015-02-164-92/+3
| | | | | | | | | | | | This reverts commit a14adc3c62658228a12d45e0851ae443c8429b85. Change-Id: Ib0d1dad15142b3b8650d343515ad4c61db65db1b
* | Merge "Allow turning off the version check"Jenkins2015-02-162-4/+7
|\ \
| * | Allow turning off the version checkJoshua Harlow2015-02-162-4/+7
| |/ | | | | | | | | | | | | | | | | | | Since the version check appears to be somewhat flakey allow it to be turned off by power users who know they are running the correct zookeeper version (and therefore can avoid this flakey check in the first place). Change-Id: Ia5323454aac543d3241e322144928d1076558d93
* | Merge "adding check for str/unicode type in requires"Jenkins2015-02-164-2/+21
|\ \ | |/ |/|
| * adding check for str/unicode type in requiresMin Pae2015-02-154-2/+21
| | | | | | | | | | | | | | | | | | | | | | | | When the requires argument for an Atom is passed in as a string, each character of the string is iterated over to build up a requirement list. This works for simple one letter argument names but not for long argument names. Added check for str and unicode types to prevent iterating over a string. Change-Id: Ida584221b48966d26935fb2ede0075aabb7ce972
* | Merge "Add retries to fetching the zookeeper server version"Jenkins2015-02-164-3/+92
|\ \ | |/ |/|
| * Add retries to fetching the zookeeper server versionJoshua Harlow2015-02-164-3/+92
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Apparently the execution of four-letter commands to zookeeper is known to be flakey (and you may receive partial results) so to avoid this use the retrying library during fetching/parsing of the server version and try up to 3 times to get a valid version from the zookeeper server. When the following merges (and is released) we can likely remove this equivalent/similar code: https://github.com/python-zk/kazoo/pull/280 Change-Id: I9191c463c7969df101541463a76fe20ff5ed06af
* | Merge "Fix log statement"Jenkins2015-02-151-1/+1
|\ \
| * | Fix log statementManish Godara2015-02-131-1/+1
| |/ | | | | | | | | | | | | | | Added quotes around flow repr output used in exception. Since the name can contain spaces it maybe sometimes confusing to debug without the quotes. Change-Id: I469af4758acb41c0d79f2368d21b707e88639047
* | Merge "Remove duplicate 'the' and link to worker engine section"Jenkins2015-02-151-5/+7
|\ \
| * | Remove duplicate 'the' and link to worker engine sectionJoshua Harlow2015-02-151-5/+7
| | | | | | | | | | | | Change-Id: I9c5c315359b93636af187b2619bec306d94e2a6d
* | | Merge "catch NotFound errors when consuming or abandoning"Jenkins2015-02-151-1/+1
|\ \ \
| * | | catch NotFound errors when consuming or abandoningDan Krause2015-02-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the zk node disappears underneath the conductor before it attempts to abandon or consume a job, consumption/abandonment would fail with an uncaught exception, killing the conductor. Catching excp.NotFound corrects this. Change-Id: Iaa7d0d8d0ebbc76973f16d717cc3137c75fbfec2
* | | | Merge "Make the atom class an abstract class"Jenkins2015-02-151-0/+11
|\ \ \ \ | |_|/ / |/| | |
| * | | Make the atom class an abstract classJoshua Harlow2015-02-131-0/+11
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | To enforce the already existing behavior that atoms have execute and revert methods (this is already the de-facto behavior with its subclasses) we might as well have the atom class be abstract and have methods execute() and revert() that need to be implemented in subclasses (which they already are). Change-Id: Idfc25a7c2b01f674a065e3f467607eba4ab89a26
* | | Merge "Add a BFS tree iterator"Jenkins2015-02-152-0/+35
|\ \ \
| * | | Add a BFS tree iteratorJoshua Harlow2015-02-102-0/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To complement the DFS iterator that we provide in our tree helper/type class add a BFS iterator as well so that when/if we extract this module to elsewhere we can have a nice featureful (and hopefully useful) set of iterators for folks to use. Change-Id: I1bc10c25bb62a5ffc85863f3f894d5469db95ff6
* | | | Merge "Remove delayed decorator and replace with nicer method"Jenkins2015-02-151-20/+38
|\ \ \ \
| * | | | Remove delayed decorator and replace with nicer methodJoshua Harlow2015-02-131-20/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of having a delayed decorator that is in the module have one that is attached onto the instance and that can log how long it took for the target method to finally be ran. Change-Id: Ie6e51b0a2a60a063554dfba7fcc321ecd6661949
* | | | | Merge "Mark conductor 'stop' method deprecation kwarg with versions"Jenkins2015-02-141-5/+6
|\ \ \ \ \
| * | | | | Mark conductor 'stop' method deprecation kwarg with versionsJoshua Harlow2015-02-121-5/+6
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To make it known (when the warning message is emitted) what version this was deprecated in and when it may be removed in add those parameters to the 'removed_kwarg' decorator so that users of conductors are aware of this information. Change-Id: Iacc97831ccd96d68cea4bd7e65a967b5ff9e7dc5
* | | | | Merge "Improve upon/adjust/move around new optional example"Jenkins2015-02-146-102/+196
|\ \ \ \ \ | |_|_|/ / |/| | | |
| * | | | Improve upon/adjust/move around new optional exampleJoshua Harlow2015-02-116-102/+196
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of having the optional requirements example be a example that is itself a unittest just move the example to be an actual unit test that gets tested using the various engine types and change the example to be something slightly different (but shows the same kind of usage information). Change-Id: Ia03a81a6be636c501a35e7e290f587f7d05f8b30
* | | | | Merge "Move to hacking 0.10"Jenkins2015-02-132-3/+1
|\ \ \ \ \
| * | | | | Move to hacking 0.10Joe Gordon2015-02-122-3/+1
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release notes: http://lists.openstack.org/pipermail/openstack-dev/2015-January/054165.html Remove deleted hacking rules from tox.ini (H904) Change-Id: I9a7130c700e2e49ee95fd16bf48af4697e78312d
* | | | | Merge "Clarify documentation related to inputs"Jenkins2015-02-131-3/+4
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | Clarify documentation related to inputsManish Godara2015-02-111-3/+4
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | Fixed typo and clarify documentation related to inputs and storage modification. Change-Id: Ib1998edd8f1018ea3cfe403e58ed998614a7629a
* | | | Merge "Docstrings should document parameters return values"Jenkins2015-02-129-48/+200
|\ \ \ \ | |_|_|/ |/| | |
| * | | Docstrings should document parameters return valuesVilobh Meshram2015-02-119-48/+200
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Partial-Bug: #1374202 Documents what the function parameters are, what is the type of the parameters passed what return values are, how it is used and what they should provide for it when using a method/class or deriving from an existing class. Change-Id: Ie81b3a446c9fee2dad9411efa28dad8d455b06ba
* | | | Merge "DFS in right order when not starting at the provided node"Jenkins2015-02-122-2/+10
|\ \ \ \ | | |_|/ | |/| |
| * | | DFS in right order when not starting at the provided nodeJoshua Harlow2015-02-102-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the dfs iteration is requested to start at the provided nodes children make sure that we create the stack in the same way as we do its children to ensure that the DFS iteration order is maintained correctly in this situation. Change-Id: I9d5e3a46b4d2349ab1662a634d635b2052be4a55
* | | | Merge "Use the new table length constants"Jenkins2015-02-121-14/+24
|\ \ \ \
| * | | | Use the new table length constantsJoshua Harlow2015-02-121-14/+24
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of having constants for lengths that aren't shared among the table master schema and the upgrade scripts move the constants that exist in the schema upgrade scripts (which are used to arrive at the master schema) to use the same constants the master table schema module uses. Change-Id: I312760ee329ebd3161c09b316d55afe129ff2d09
* | | | Merge "Let the multi-lock convert the provided value to a tuple"Jenkins2015-02-121-3/+5
|\ \ \ \
| * | | | Let the multi-lock convert the provided value to a tupleJoshua Harlow2015-02-101-3/+5
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of forcing the locks (list or tuple) into a list and then having the multi-lock code force that back into a tuple just pass the value through to the multi-lock class and let it handle the conversion in a more easy to understand manner (and one that doesn't involve as many copies). Change-Id: Ib0e78bacb80aea73af465a91cb4f509904f47990
* | | | Merge "Modify stop and add wait on conductor to prevent lockups"Jenkins2015-02-123-14/+52
|\ \ \ \ | |_|/ / |/| | |
| * | | Modify stop and add wait on conductor to prevent lockupsMin Pae2015-02-093-14/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removed _dead.wait from the stop method and added a wait method to explicitly wait for graceful shutdown. Implicitly waiting for graceful shutdown in the stop method is leading to potential deadlock situations when conductor is running in the main thread and a signal handler is used to kick off stop/shutdown. Also in larger systems, it is desirable to be able to initiate shutdown on all running services then wait/join everything together so as not to force a serial shutdown pattern. Change-Id: Ic74dab22b09100c5b653d12c2518f83a1bf8e859
* | | | Merge "Map optional arguments as well as required arguments"Jenkins2015-02-118-51/+207
|\ \ \ \ | |_|/ / |/| | |
| * | | Map optional arguments as well as required argumentsMin Pae2015-02-108-51/+207
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Optional arguments that are not explicitly required are being ignored when arguments are being mapped based on inference from atoms' execute method signatures. This patch adds support for mapping optional arguments in addition to required arguments. Change-Id: I440c02dcd901a563df512e33754b13e3c05d4155
* | | | Rework the sqlalchemy backendJoshua Harlow2015-02-103-344/+282
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can just simplify the usage of an sqlalchemy if we just use (we already have our own ORM like objects anyway) sqlalchemy core in the first place and have a very tiny layer that converts back and forth from our very limited object model that we use in our persistence layer. This change makes that adjustment, which makes it easier to read and understand the actions the sqlalchemy backend is doing when saving, reading and updating data, and avoids yet another layer that isn't useful for our purposes anyway. Change-Id: I911c509f65e7845aee86fed1622eaa56970741f2
* | | Merge "Add warning to sqlalchemy backend size limit docs"Jenkins2015-02-071-0/+10
|\ \ \
| * | | Add warning to sqlalchemy backend size limit docsJoshua Harlow2015-02-051-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | Partial-Bug: #1416088 Change-Id: I21bde00445892a4c734592cbcc143f23085e5660
* | | | Merge "Add a capturing listener (for test or other usage)"Jenkins2015-02-073-47/+127
|\ \ \ \
| * | | | Add a capturing listener (for test or other usage)Joshua Harlow2015-02-033-47/+127
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To enable those that are using taskflow to easily attach to an engine (say in a unit test) and capture all the transitions, details and state changes in a accumulating 'values' list provide a capturing listener that does just this (and change the one used for internal testing to use it) so that others may also benefit from the same functionality. Change-Id: I7a35e282dd4a6b3e14277bea2af1f275615bd212
* | | | Merge "Bump up the env_builder.sh to 2.7.9"Jenkins2015-02-071-4/+5
|\ \ \ \
| * | | | Bump up the env_builder.sh to 2.7.9Joshua Harlow2015-02-031-4/+5
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The latest python 2.x release is 2.7.9 and not 2.7.7 so when people are using this script to build a useful environment (that is lacking py2.7) use this newer version instead. Change-Id: I2fdd035e0b4efcacd6ef2da04d6cd8a56dcca512
* | | | Merge "Default to using a thread-safe storage unit"Jenkins2015-02-079-79/+26
|\ \ \ \
| * | | | Default to using a thread-safe storage unitJoshua Harlow2015-02-059-79/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of having a nominally useful single-threaded storage unit that uses a dummy r/w lock and a multi-threaded storage unit just have the storage unit by default protect itself from multi-threading calls being used on it (with the appropriate reader/writer locks being activated to make this work correctly). Change-Id: Ib6879edb465156a8e54fd5b4002550d1cec49137
* | | | | Merge "Add + use a staticmethod to fetch the immediate callables"Jenkins2015-02-071-8/+13
|\ \ \ \ \