summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDoug Hellmann <doug.hellmann@dreamhost.com>2014-03-27 10:22:33 -0700
committerDoug Hellmann <doug.hellmann@dreamhost.com>2014-03-27 10:22:33 -0700
commit2bbf3eb5696e1e5decfd151453a57015a8c68f33 (patch)
tree9b89af6a27a5cc27bc302995bf91967986f4760c
parent180b1789e3cf3ed2ea43d5977fb6a0d1c81e7037 (diff)
downloadstevedore-2bbf3eb5696e1e5decfd151453a57015a8c68f33.tar.gz
Only log error when no load handler is set0.15
Only log an error from loading a plugin if no load failure handler callback is provided. Otherwise, assume the handler will do any logging it wants. Change-Id: Iac83f3c140067bc3d1996c40c0184e4a0d0b564a
-rw-r--r--stevedore/extension.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/stevedore/extension.py b/stevedore/extension.py
index 2dd22c7..0f227a3 100644
--- a/stevedore/extension.py
+++ b/stevedore/extension.py
@@ -166,10 +166,11 @@ class ExtensionManager(object):
except (KeyboardInterrupt, AssertionError):
raise
except Exception as err:
- LOG.error('Could not load %r: %s', ep.name, err)
- LOG.exception(err)
if self._on_load_failure_callback is not None:
self._on_load_failure_callback(self, ep, err)
+ else:
+ LOG.error('Could not load %r: %s', ep.name, err)
+ LOG.exception(err)
return extensions
def _load_one_plugin(self, ep, invoke_on_load, invoke_args, invoke_kwds,