summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Remove None valued network quota entries" into stable/victoriastable/victoriaZuul2022-07-063-4/+36
|\
| * Remove None valued network quota entriesasarfaty2021-02-173-4/+36
| | | | | | | | | | | | | | | | | | | | | | Since the openstack SDK still has the neutron-lbaas entries in the network quota, but those are already deprecated [1], the 'opentack quota show' command shows those as None value. This fix removes those empty deprecated values from the output. [1] https://review.opendev.org/#/c/658494/ Change-Id: I8dbdba2a029ea8e6a268ddf29627e1466a7e3a8a (cherry picked from commit e9bd4ef007153e4f2e2d69f3bcb94eef8e8983c2)
* | Merge "compute: Show flavor in 'server list' with API >= 2.47" into ↵Zuul2022-07-063-135/+231
|\ \ | | | | | | | | | stable/victoria
| * | compute: Show flavor in 'server list' with API >= 2.47Khomesh Thakre2021-12-083-135/+231
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the issue where the flavor name was empty in server list output. This requires somewhat invasive unit test changes to reflect the changed API response from the server, but this has the upside of meaning we don't need new tests since what we have validates things. Also drop the flavor ID column as it is removed from the compute API. Conflicts: openstackclient/tests/unit/compute/v2/test_server.py NOTE(melwitt): The conflicts and differences from the cherry picked change are because the following changes are not in Victoria: * I4811f8f66dcb14ed99cc1cfb80b00e2d77afe45f (compute: Add 'server * --all-projects' option) * I7a8349106e211c57c4577b75326b39b88bd9ac1e (compute: Fix 'server * -f yaml' output) * I84848c0bf8ab3c36dd821141191e2725e4e3b58b (Remove usage of six) * Ieeb1f22df7092e66a411b6a36eafb3e16efc2fc2 (compute: Add missing options for 'server list') * If065602792958ff0145ae9f2e05f5b7a3177905c (Compute: Add tags support for server) * I25a4da697e27c0fba4d28b504377667eb18f15fe (compute: Add '--force' option to 'server delete') * I463993170c03a1d98c47ab6a3c19131b7fca1099 (Remove oslo.utils) * I18991adf899c7b72c98bb89871bf0715d35943f0 (Add a few selectable fields to the "openstack server list" output) * I62b2ed8488ee4ac9c42051311bcfb455506ddd90 (Switch compute flavors from novaclient/direct to SDK) Change-Id: Ica3320242a38901c1180b2b29109c9474366fde0 Signed-off-by: Khomesh Thakre <khomeshthakre24@gmail.com> Story: 2008257 Task: 41113 (cherry picked from commit 8e362402dee07744668bcf7f6774af4fbe9a07e3) (cherry picked from commit 0873e7580eceab07c3be0824d2ea4163491f8d6e) (cherry picked from commit 4b7e777c0ce19aa67a9a33cbeb3b4ee2b052383f)
* | | Merge "compute: Reorder building of columns for 'server list'" into ↵Zuul2022-07-061-77/+99
|\ \ \ | |/ / | | | | | | stable/victoria
| * | compute: Reorder building of columns for 'server list'Stephen Finucane2021-12-041-77/+99
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This has no impact on the end result, but it should make fixing issues introduced by API microversion 2.69 a little easier. Conflicts: openstackclient/compute/v2/server.py NOTE(melwitt): The conflicts are because the following changes are not in Victoria: * I463993170c03a1d98c47ab6a3c19131b7fca1099 (Remove oslo.utils) * I18991adf899c7b72c98bb89871bf0715d35943f0 (Add a few selectable fields to the "openstack server list" output) * I2f2033a8d49ee42eb21696a9cd28e63ad9712fad (trivial: Cleanup docs for 'server list') Change-Id: I7d70eac8aa1a6197ed05a49f071e6899ec219c03 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> (cherry picked from commit 4c3de28e83babb0672950320a20492dc61803b4a) (cherry picked from commit f4adbcef7b1b18d9454109a020e5e2c6ad78b5f1) (cherry picked from commit cb621f22d4547c20f5722058be8d99de936a48c6)
* | | Merge "compute: Add missing options for 'server group list'" into ↵Zuul2022-07-063-5/+85
|\ \ \ | | | | | | | | | | | | stable/victoria
| * | | compute: Add missing options for 'server group list'Stephen Finucane2022-07-043-5/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add pagination parameters, '--limit' and '--offset'. It's unfortunate that we can't use '--marker' like elsewhere but that requires server-side support to be truly effective. Change-Id: I186adc8cdf28e9c540ad22bca6684d9dd892976a Signed-off-by: Stephen Finucane <sfinucan@redhat.com> (cherry picked from commit 5ec4d4c7188f4766d270be32e12b64b709d2b835)
* | | | Stop testing lower-constraintslikui2022-07-044-149/+4
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [1] http://lists.openstack.org/pipermail/openstack-discuss/2020-October/018445.html Conflicts: .zuul.yaml lower-constraints.txt NOTE(stephenfin): Conflicts are due to the changed job template (victoria vs wallaby) and slightly different lower constraints between branches. Change-Id: I45e9a81d451c64cdd51f9b606d94161742bacdb7 (cherry picked from commit c677192d51ac80922f990c8a96b49e9dcc9325d2) (cherry picked from commit cde8db3d619ff94369cdabeebb42d3ecc2027651) (cherry picked from commit 40f56c653cc4eabf9edc05b5c5785e818295b013)
* | | Merge "stop image downloads to memory" into stable/victoriaZuul2022-06-204-3/+19
|\ \ \ | |/ / |/| |
| * | stop image downloads to memorySimon Merrick2021-05-284-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + Fixes issue with large images hogging memory + stream image downloads + output to stdout if file not specified Change-Id: Ia01ff9b21a2dac5d0ccf2bd58a8640e88c5cbb36 Story: 2007672 Task: 39776 (cherry picked from commit 5bdcd590ecacbc0aa8db2cbafa0ab1a9f3c28ce0)
* | | Merge "zuul: Stop testing against Tempest" into stable/victoriaZuul2021-06-021-1/+1
|\ \ \ | |/ / |/| |
| * | zuul: Stop testing against TempestStephen Finucane2020-10-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Neither Tempest itself nor any of the service projects use OSC. As such, there's no reason to run Tempest jobs here. It's simply a waste of resources. Change-Id: I74b0b196fe59e5e1462e3dadc659cf6680a53f80 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> (cherry picked from commit 671f73694a207b4b2b5a7cf377bc46dad7e79324)
* | | Merge "Add reno for change Ic3c555226a220efd9b0f27edffccf6c4c95c2747" into ↵Zuul2021-03-181-0/+6
|\ \ \ | | | | | | | | | | | | stable/victoria
| * | | Add reno for change Ic3c555226a220efd9b0f27edffccf6c4c95c2747Stephen Finucane2021-01-111-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change Ic3c555226a220efd9b0f27edffccf6c4c95c2747 introduced some validation for the 'openstack server group create --policy' command. Call this out in the release notes. Change-Id: I7e00851a03470364db00f0f114fc724b0f686b72 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> (cherry picked from commit bb15b29190dfe77ea0218a01edc1f4886993b177)
* | | | Merge "Validate 'server group create --policy' option" into stable/victoriaZuul2021-03-032-5/+63
|\ \ \ \ | |/ / / | | | / | |_|/ |/| |
| * | Validate 'server group create --policy' optionStephen Finucane2021-01-112-5/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were documenting that some of these policies were only supported with specific microversions, however, we weren't actually enforcing that, leading to a poor user experience. Correct this. Change-Id: Ic3c555226a220efd9b0f27edffccf6c4c95c2747 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Story: #2007727 Task: #39882 (cherry picked from commit ab0b1fe885ee0a210a58008b631521025be7f3eb)
* | | Fix lower-constraints jobStephen Finucane2021-01-123-7/+8
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | pip 20.3 finally includes a proper dependency resolver. Its use is causing the following error messages on the lower-constraints job: ERROR: Cannot install ... because these package versions have conflicting dependencies. The conflict is caused by: bandit 1.1.0 depends on PyYAML>=3.1.0 cliff 3.4.0 depends on PyYAML>=3.12 openstacksdk 0.52.0 depends on PyYAML>=3.13 Bump our lower constraint for PyYAML to resolve this issue. With that resolved, we see a new issue: ERROR: Could not find a version that satisfies the requirement cryptography>=2.7 (from openstacksdk) ERROR: No matching distribution found for cryptography>=2.7 This is less self-explanatory but looking at the lower-constraints for openstacksdk 0.52.0 shows a dependency on cryptography 2.7 [1], meaning we need to bump this also. Next up, flake8-import-order seems to cause the dependency resolver to go nuts, eventually ending with the following error message in a Python 3.6 environment: Using cached enum34-1.1.2.zip (49 kB) ERROR: Command errored out with exit status 1: command: ... cwd: ... Complete output (9 lines): Traceback (most recent call last): File "<string>", line 1, in <module> File ".../lib/python3.6/site-packages/setuptools/__init__.py", line 7, in <module> import setuptools.distutils_patch # noqa: F401 File ".../lib/python3.6/site-packages/setuptools/distutils_patch.py", line 9, in <module> import re File "/usr/lib64/python3.6/re.py", line 142, in <module> class RegexFlag(enum.IntFlag): AttributeError: module 'enum' has no attribute 'IntFlag' ---------------------------------------- A quick Google suggests this is because the enum34 package is not complete [2]. We shouldn't even be using it since our base virtualenv should at least use Python 3.6, but I guess some dependency doesn't properly restrict the dependency to <= Python 3.4. This is moved from 'test-requirements.txt' to 'tox.ini' since we don't need to use our constraints machinery for linters. Finally, the versions of bandit and hacking that pip is bringing in both requires in a newer version of babel, which in turn requires a new version of pytz. Collecting hacking>=2.0.0 ... ERROR: Cannot install oslo.i18n because these package versions have conflicting dependencies. The conflict is caused by: babel 2.9.0 depends on pytz>=2015.7 babel 2.8.1 depends on pytz>=2015.7 babel 2.8.0 depends on pytz>=2015.7 babel 2.7.0 depends on pytz>=2015.7 Seeing as we shouldn't be tracking bandit in lower-constraints, I'm not sure why we're want to bump these dependencies for just that. As above, we move these dependencies out of 'test-requirements' and into 'tox.ini' since we can do that for linters. Modifications: tox.ini NOTE(stephenfin): A cap is placed on the version of hacking used to prevent us bringing in 4.0.0, which requires additional fixes. [1] https://opendev.org/openstack/openstacksdk/src/tag/0.52.0/requirements.txt#L19 [2] https://github.com/iterative/dvc/issues/1995#issuecomment-491889669 Change-Id: I8ec738fbcabc8d8553db79a876e5592576cd18fa Signed-off-by: Stephen Finucane <sfinucan@redhat.com> (cherry picked from commit 20769cd7b27d51da84a324a17922427eba5c6eac)
* | Update TOX_CONSTRAINTS_FILE for stable/victoriaOpenStack Release Bot2020-10-021-4/+4
|/ | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/victoria branch, tests will continue to use the upper-constraints list on master. Change-Id: Ib4b565bce41077c82c3069c7fd124e849cb26218
* Update .gitreview for stable/victoriaOpenStack Release Bot2020-10-021-0/+1
| | | | Change-Id: Iedf387dbfa77a2a658af491bda0d4439e86c4b91
* Merge "bump py37 to py38 in tox.ini"victoria-em5.4.0Zuul2020-10-011-1/+1
|\
| * bump py37 to py38 in tox.iniwangzihao2020-09-181-1/+1
| | | | | | | | | | | | | | in 'victoria' cycle, we should test py38 by default. and remove redundant python env. Change-Id: I6426cc55ee9b6bee96620a8185fbdb39c24a68a8
* | Merge "Remove install unnecessary packages"Zuul2020-10-010-0/+0
|\ \
| * | Remove install unnecessary packageswu.shiming2020-09-141-1/+0
| |/ | | | | | | | | | | | | The docs and releasenotes requirements migrated to doc/requirements.txt we need not install things from requirements.txt. Change-Id: I4403cee833448beb69afaec503519d5a951f7e34
* | Merge "Update developing.rst"Zuul2020-10-011-1/+1
|\ \
| * | Update developing.rstlikui2020-09-081-1/+1
| | | | | | | | | | | | | | | | | | Use unittest.mock instead of mock Change-Id: Ib573e9d217b4f18ef4e7ba3ab581164be423cb26
* | | Merge "Fix --image-property option in 'create server'"Zuul2020-10-013-3/+76
|\ \ \
| * | | Fix --image-property option in 'create server'Myeongchul Chae2020-09-103-3/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a problem that the '-image-property' option, which can be used to create an instance, did not work as intended. I found that there were two problems with this option. First, I cannot select an image as its metadata. The second is that when there are multiple images available, the desired image may not be selected depending on the situation. This patch solves these two problems. I wrote the test case with these two problems considered together. Change-Id: Ib2745d7e067056ff4ca8bfaf6cff492d0dacb73a story: #2007860
* | | | Merge "Add API check for server_groups.create"Zuul2020-09-302-2/+28
|\ \ \ \
| * | | | Add API check for server_groups.createLewis Denny2020-08-262-2/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The policies field has been replaced with the policy field since Nova API version 2.64[1] This commit adds a check to make sure the correct field is used. [1]https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id59 Change-Id: I06d3211937d822c26070b7f8ad757c365dcbb1bb Story: #2007822 Task: #40101
* | | | | Merge "Add API check for server_groups.list"Zuul2020-09-303-4/+138
|\ \ \ \ \
| * | | | | Add API check for server_groups.listLewis Denny2020-08-213-4/+138
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The policies parameter has been replaced with the policy parameter since Nova API version 2.64[1] This commit adds a check to make sure the correct parameter is used. [1]https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id59 Change-Id: Ia37beb7790884d6d15bec45074f446e64af1a2aa Story: #2008041 Task: #40703
* | | | | Merge "Show words indicating booted from volume for server image"Zuul2020-09-303-8/+35
|\ \ \ \ \
| * | | | | Show words indicating booted from volume for server imagemelanie witt2020-08-273-8/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For a server booted from a volume, nova API does not store an image_id and instead returns an empty string. Currently, openstackclient similarly shows an empty string for Image Name and Image ID for servers booted from volumes. To aid CLI users in understanding the meaning of no image_id, we can display the string "N/A (booted from volume)" in the image field if the server was booted from a volume. Change-Id: I9c62cf6fe23b2e934dcbf5ebbf706b2705d2e424
* | | | | | Merge "Remove install unnecessary packages"Zuul2020-09-301-1/+0
|\ \ \ \ \ \
| * | | | | | Remove install unnecessary packagesmaaoyu2020-09-241-1/+0
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The docs requirements migrated to doc/requirements.txt we need not install things from requirements.txt. Change-Id: I35a367505b2b423c345b05519e4134113cb66648
* | | | | | Merge "Output correct json for security groups in 'openstack server show'"Zuul2020-09-254-21/+42
|\ \ \ \ \ \ | |/ / / / / |/| | | | |
| * | | | | Output correct json for security groups in 'openstack server show'jay2020-09-144-21/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes incorrect json output for 'openstack server show -f json'. The security group json output groups all the json as one for e.g. "security_groups": "name='group1'\nname='group2'" The correct output should be "security_groups" : [{"name" : "group1"}, {"name" : "group2"}] properties and volumes_attached fields also has similar issue. Story: 2007755 Change-Id: I1b1cac716329e0530400aff782c08000b21d8e1d
* | | | | | Merge "Support tagging Neutron ports on creation"Zuul2020-09-133-15/+59
|\ \ \ \ \ \
| * | | | | | Support tagging Neutron ports on creationMiguel Lavalle2020-09-043-15/+59
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds support for tagging ports on creation Co-Authored-By: Slawek Kaplonski <skaplons@redhat.com> Change-Id: I3148a568664588eb2f529138f984859570c0fca1 Related-Bug: #1815933
* | | | | | Fix gate due to switch to focalArtem Goncharov2020-09-112-3/+2
| |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | In focal we do not have libffi6. cffi and greenlet versions in lower-contraints are too old. Change-Id: Iab3634039845adb649c7fd69d1812b405a61433c
* | | | | Merge "Add NUMA affinity policy parameter to "port""Zuul2020-09-074-0/+134
|\ \ \ \ \
| * | | | | Add NUMA affinity policy parameter to "port"Rodolfo Alonso Hernandez2020-07-314-0/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added port NUMA affinity policy parameter to "port create", "port set" and "port unset" commands. Change-Id: I48cacab275856af2911829f9b7176bb87fd039b3 Related-Bug: #1886798
* | | | | | Merge "Allow openstack flavor set to update flavor description using name"Zuul2020-09-032-1/+37
|\ \ \ \ \ \ | |_|/ / / / |/| | | | |
| * | | | | Allow openstack flavor set to update flavor description using nameGabriel Ramirez2020-06-102-1/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Modified take_action() method for SetFlavor to use flavor id instead of flavor name when setting description Closes-Bug: #1844708 Story: #2007781 Task: #40019 Change-Id: If6798c89fef4c9feb4ebb460722b891f5655037d
* | | | | | Merge "Bypass user and group verification in RemoveRole"Zuul2020-08-133-32/+285
|\ \ \ \ \ \
| * | | | | | Bypass user and group verification in RemoveRoleLance Bragstad2020-08-123-32/+285
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Keystone let's users remove role assignments that reference non-existent users and groups. This is nice when keystone backs to an identity store like LDAP and users or groups are removed. Previously, openstackclient would validate the user and group existed in keystone before sending the request to delete the role assignment. This commit updates the code to bypass that validation so that users can use IDs to forcibly cleanup role assignments. Change-Id: I102b41677736bbe37a82abaa3c5b3e1faf2475d5 Story: 2006635 Task: 36848
* | | | | | | Merge "Add system role assignment tests for users and groups"Zuul2020-08-061-0/+137
|\ \ \ \ \ \ \ | |/ / / / / /
| * | | | | | Add system role assignment tests for users and groupsLance Bragstad2020-07-101-0/+137
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was writing some additional functionality and noticed these tests were missing. This commit adds tests for adding and removing system role assignments for users and groups. Change-Id: I30fdc6ec55e1eb1cfa55f4cbf92c3f001d89865f
* | | | | | | Merge "Fix reverted osc-lib interface change"Zuul2020-08-031-1/+1
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | |
View Lorry Controller Status