log take_action parameters in a single place

Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be

1 files changed, 4 insertions, 23 deletions

diff --git a/openstackclient/identity/v3/endpoint.py b/openstackclient/identity/v3/endpoint.py
index 3d1c6f54..1eff3b3b 100644
--- a/openstackclient/identity/v3/endpoint.py
+++ b/openstackclient/identity/v3/endpoint.py
@@ -15,14 +15,10 @@
 
 """Identity v3 Endpoint action implementations"""
 
-import logging
 import six
 import sys
 
-from cliff import command
-from cliff import lister
-from cliff import show
-
+from openstackclient.common import command
 from openstackclient.common import utils
 from openstackclient.identity import common
 
@@ -34,11 +30,9 @@ def get_service_name(service):
         return ''
 
 
-class CreateEndpoint(show.ShowOne):
+class CreateEndpoint(command.ShowOne):
     """Create new endpoint"""
 
-    log = logging.getLogger(__name__ + '.CreateEndpoint')
-
     def get_parser(self, prog_name):
         parser = super(CreateEndpoint, self).get_parser(prog_name)
         parser.add_argument(
@@ -78,7 +72,6 @@ class CreateEndpoint(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
         service = common.find_service(identity_client, parsed_args.service)
@@ -102,8 +95,6 @@ class CreateEndpoint(show.ShowOne):
 class DeleteEndpoint(command.Command):
     """Delete endpoint"""
 
-    log = logging.getLogger(__name__ + '.DeleteEndpoint')
-
     def get_parser(self, prog_name):
         parser = super(DeleteEndpoint, self).get_parser(prog_name)
         parser.add_argument(
@@ -113,7 +104,6 @@ class DeleteEndpoint(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
         endpoint_id = utils.find_resource(identity_client.endpoints,
@@ -122,11 +112,9 @@ class DeleteEndpoint(command.Command):
         return
 
 
-class ListEndpoint(lister.Lister):
+class ListEndpoint(command.Lister):
     """List endpoints"""
 
-    log = logging.getLogger(__name__ + '.ListEndpoint')
-
     def get_parser(self, prog_name):
         parser = super(ListEndpoint, self).get_parser(prog_name)
         parser.add_argument(
@@ -147,7 +135,6 @@ class ListEndpoint(lister.Lister):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
         columns = ('ID', 'Region', 'Service Name', 'Service Type',
@@ -176,8 +163,6 @@ class ListEndpoint(lister.Lister):
 class SetEndpoint(command.Command):
     """Set endpoint properties"""
 
-    log = logging.getLogger(__name__ + '.SetEndpoint')
-
     def get_parser(self, prog_name):
         parser = super(SetEndpoint, self).get_parser(prog_name)
         parser.add_argument(
@@ -221,7 +206,6 @@ class SetEndpoint(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
         endpoint = utils.find_resource(identity_client.endpoints,
@@ -256,11 +240,9 @@ class SetEndpoint(command.Command):
         return
 
 
-class ShowEndpoint(show.ShowOne):
+class ShowEndpoint(command.ShowOne):
     """Display endpoint details"""
 
-    log = logging.getLogger(__name__ + '.ShowEndpoint')
-
     def get_parser(self, prog_name):
         parser = super(ShowEndpoint, self).get_parser(prog_name)
         parser.add_argument(
@@ -270,7 +252,6 @@ class ShowEndpoint(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
         endpoint = utils.find_resource(identity_client.endpoints,