summaryrefslogtreecommitdiff
path: root/openstackclient/identity/v3/domain.py
diff options
context:
space:
mode:
authorHuanxuan Ao <huanxuan.ao@easystack.cn>2016-07-12 12:44:55 +0800
committerHuanxuan Ao <huanxuan.ao@easystack.cn>2016-07-19 09:49:36 +0800
commit60639d76a742852e18f9e2889c480be95596c268 (patch)
treecad7069ec7b4175f9ceea7e14113b9477698f1e8 /openstackclient/identity/v3/domain.py
parent55c1c575d63f4e9e6fc3f4dbb6c572e841b513d9 (diff)
downloadpython-openstackclient-60639d76a742852e18f9e2889c480be95596c268.tar.gz
Support bulk deletion for delete commands in identityv3
Support bulk deletion for delete commands in the list below identity/v3/consumer identity/v3/credential identity/v3/domain identity/v3/ec2creds identity/v3/endpoint identity/v3/federation_protocol identity/v3/identity_provider identity/v3/mapping identity/v3/policy identity/v3/region identity/v3/service_provider identity/v3/service The unit test in identityv3 need to be refactored, so I add some functional tests instead. I will add all unit tests at one time after the refactor completed. Change-Id: I82367570f59817b47c87b6c7bfeae95ccfe5c50e Closes-Bug: #1592906
Diffstat (limited to 'openstackclient/identity/v3/domain.py')
-rwxr-xr-xopenstackclient/identity/v3/domain.py25
1 files changed, 20 insertions, 5 deletions
diff --git a/openstackclient/identity/v3/domain.py b/openstackclient/identity/v3/domain.py
index 3e9bcf63..76e47d32 100755
--- a/openstackclient/identity/v3/domain.py
+++ b/openstackclient/identity/v3/domain.py
@@ -19,6 +19,7 @@ import logging
from keystoneauth1 import exceptions as ks_exc
from osc_lib.command import command
+from osc_lib import exceptions
from osc_lib import utils
import six
@@ -88,22 +89,36 @@ class CreateDomain(command.ShowOne):
class DeleteDomain(command.Command):
- """Delete domain"""
+ """Delete domain(s)"""
def get_parser(self, prog_name):
parser = super(DeleteDomain, self).get_parser(prog_name)
parser.add_argument(
'domain',
metavar='<domain>',
- help=_('Domain to delete (name or ID)'),
+ nargs='+',
+ help=_('Domain(s) to delete (name or ID)'),
)
return parser
def take_action(self, parsed_args):
identity_client = self.app.client_manager.identity
- domain = utils.find_resource(identity_client.domains,
- parsed_args.domain)
- identity_client.domains.delete(domain.id)
+ result = 0
+ for i in parsed_args.domain:
+ try:
+ domain = utils.find_resource(identity_client.domains, i)
+ identity_client.domains.delete(domain.id)
+ except Exception as e:
+ result += 1
+ LOG.error(_("Failed to delete domain with name or "
+ "ID '%(domain)s': %(e)s")
+ % {'domain': i, 'e': e})
+
+ if result > 0:
+ total = len(parsed_args.domain)
+ msg = (_("%(result)s of %(total)s domains failed "
+ "to delete.") % {'result': result, 'total': total})
+ raise exceptions.CommandError(msg)
class ListDomain(command.Lister):