summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Theis <rtheis@us.ibm.com>2016-04-07 16:35:38 -0500
committerRui Chen <chenrui.momo@gmail.com>2017-01-16 06:22:54 +0000
commit53a79c33f88cea83fb2a90408dd3f5e8dd48a2f5 (patch)
treee0eff0b8cda23b1a64cac9d41aff5d8aa13800d8
parent59bd93e49aace4e827b5d269dc3505812e0cf45f (diff)
downloadpython-openstackclient-53a79c33f88cea83fb2a90408dd3f5e8dd48a2f5.tar.gz
Fix SSL/TLS verification for network commands
The network commands ignored the --insecure and --os-cacert options and OS_CACERT environment variable which prevented them from properly completing SSL/TLS verification. This resulted in the network commands failing with "An SSL error occurred." Change-Id: I15167631ef58335e1476c16b828b079e3b0f13c1 Closes-Bug: #1560157 (cherry picked from commit b5f10f43eb9fd1a046a3e80db09d8bc8c350c218)
-rw-r--r--openstackclient/network/client.py3
-rw-r--r--releasenotes/notes/bug-1560157-bce572f58b43efa1.yaml7
2 files changed, 9 insertions, 1 deletions
diff --git a/openstackclient/network/client.py b/openstackclient/network/client.py
index 7714c525..dca9efc4 100644
--- a/openstackclient/network/client.py
+++ b/openstackclient/network/client.py
@@ -31,7 +31,8 @@ API_VERSIONS = {
def make_client(instance):
"""Returns a network proxy"""
- conn = connection.Connection(authenticator=instance.session.auth)
+ conn = connection.Connection(authenticator=instance.session.auth,
+ verify=instance.session.verify)
LOG.debug('Connection: %s', conn)
LOG.debug('Network client initialized using OpenStack SDK: %s',
conn.network)
diff --git a/releasenotes/notes/bug-1560157-bce572f58b43efa1.yaml b/releasenotes/notes/bug-1560157-bce572f58b43efa1.yaml
new file mode 100644
index 00000000..e5c394bc
--- /dev/null
+++ b/releasenotes/notes/bug-1560157-bce572f58b43efa1.yaml
@@ -0,0 +1,7 @@
+---
+fixes:
+ - Fixed SSL/TLS verification for Network v2 commands. The commands
+ were ignoring the ``--insecure`` and ``--os-cacert`` options and
+ the ``OS_CACERT`` environment variable which caused them to fail
+ with ``An SSL error occurred.`` when authenticating using SSL/TLS.
+ [Bug `1560157 <https://bugs.launchpad.net/python-openstackclient/+bug/1560157>`_]