diff options
author | Ihar Hrachyshka <ihrachys@redhat.com> | 2016-05-18 10:44:16 +0200 |
---|---|---|
committer | Ihar Hrachyshka <ihrachys@redhat.com> | 2016-05-23 11:57:18 +0200 |
commit | 13a0ce3ce106fa91d50094e6a41b1fef148855df (patch) | |
tree | 7c124aa272ae54d47e48ece77ef1cb1981828fc5 | |
parent | 9ff116091e5a4d5b536b3b4d5695fc253621186e (diff) | |
download | python-neutronclient-13a0ce3ce106fa91d50094e6a41b1fef148855df.tar.gz |
Constraint tox targets with upper-constraints.txt
Client version pin is maintained in upper-constraints.txt file, so we
should replace it in the file with source based specifier before
applying it to pip install, otherwise pip fails with:
Could not satisfy constraints for 'python-neutronclient': installation
from path or url cannot be constrained to a version
Also switched to using stable/mitaka branch instead of master.
Change-Id: I33302cdcab980a42c39dc9ec1e430add459615ff
Closes-Bug: #1583050
(cherry picked from commit 78d778cdeccb6a24b7f6fa7e3c2eb0891b633701)
-rwxr-xr-x | tools/tox_install.sh | 55 | ||||
-rw-r--r-- | tox.ini | 9 |
2 files changed, 63 insertions, 1 deletions
diff --git a/tools/tox_install.sh b/tools/tox_install.sh new file mode 100755 index 0000000..e825d3a --- /dev/null +++ b/tools/tox_install.sh @@ -0,0 +1,55 @@ +#!/usr/bin/env bash + +# Client constraint file contains this client version pin that is in conflict +# with installing the client from source. We should replace the version pin in +# the constraints file before applying it for from-source installation. + +ZUUL_CLONER=/usr/zuul-env/bin/zuul-cloner +BRANCH_NAME=stable/mitaka +CLIENT_NAME=python-neutronclient +requirements_installed=$(echo "import openstack_requirements" | python 2>/dev/null ; echo $?) + +set -e + +CONSTRAINTS_FILE=$1 +shift + +install_cmd="pip install" +if [ $CONSTRAINTS_FILE != "unconstrained" ]; then + + mydir=$(mktemp -dt "$CLIENT_NAME-tox_install-XXXXXXX") + localfile=$mydir/upper-constraints.txt + if [[ $CONSTRAINTS_FILE != http* ]]; then + CONSTRAINTS_FILE=file://$CONSTRAINTS_FILE + fi + curl $CONSTRAINTS_FILE -k -o $localfile + install_cmd="$install_cmd -c$localfile" + + if [ $requirements_installed -eq 0 ]; then + echo "ALREADY INSTALLED" > /tmp/tox_install.txt + echo "Requirements already installed; using existing package" + elif [ -x "$ZUUL_CLONER" ]; then + export ZUUL_BRANCH=${ZUUL_BRANCH-$BRANCH} + echo "ZUUL CLONER" > /tmp/tox_install.txt + pushd $mydir + $ZUUL_CLONER --cache-dir \ + /opt/git \ + --branch $BRANCH_NAME \ + git://git.openstack.org \ + openstack/requirements + cd openstack/requirements + $install_cmd -e . + popd + else + echo "PIP HARDCODE" > /tmp/tox_install.txt + if [ -z "$REQUIREMENTS_PIP_LOCATION" ]; then + REQUIREMENTS_PIP_LOCATION="git+https://git.openstack.org/openstack/requirements@$BRANCH_NAME#egg=requirements" + fi + $install_cmd -U -e ${REQUIREMENTS_PIP_LOCATION} + fi + + edit-constraints $localfile -- $CLIENT_NAME "-e file://$PWD#egg=$CLIENT_NAME" +fi + +$install_cmd -U $* +exit $? @@ -10,7 +10,8 @@ setenv = VIRTUAL_ENV={envdir} LANGUAGE=en_US:en LC_ALL=C usedevelop = True -install_command = pip install -U {opts} {packages} +install_command = + {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h=stable/mitaka} {opts} {packages} deps = -r{toxinidir}/requirements.txt -r{toxinidir}/test-requirements.txt # Delete bytecodes from normal directories before running tests. @@ -27,6 +28,8 @@ commands = flake8 distribute = false [testenv:venv] +# TODO(ihrachys): remove once infra supports constraints for this target +install_command = pip install -U {opts} {packages} commands = {posargs} [testenv:functional] @@ -40,6 +43,8 @@ setenv = OS_NEUTRONCLIENT_EXEC_DIR = {envdir}/bin [testenv:cover] +# TODO(ihrachys): remove once infra supports constraints for this target +install_command = pip install -U {opts} {packages} commands = python setup.py test --coverage --coverage-package-name=neutronclient --testr-args='{posargs}' coverage report @@ -48,6 +53,8 @@ commands = commands = sphinx-build -W -b html doc/source doc/build/html [testenv:releasenotes] +# TODO(ihrachys): remove once infra supports constraints for this target +install_command = pip install -U {opts} {packages} commands = sphinx-build -a -E -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html [flake8] |