summaryrefslogtreecommitdiff
path: root/run_tests.sh
diff options
context:
space:
mode:
authorJoe Heck <heckj@mac.com>2012-11-21 21:48:12 +0000
committerDolph Mathews <dolph.mathews@gmail.com>2012-11-26 13:37:18 -0600
commitf9649e2615ff1be30bdca1c96b02c2a36dab84ac (patch)
tree6a8c3d92614979d13d95a3dab37b5a6c3012f7f0 /run_tests.sh
parente4ed1f39a03d9979e8b41cfc6ef0daea159034a4 (diff)
downloadpython-keystoneclient-f9649e2615ff1be30bdca1c96b02c2a36dab84ac.tar.gz
updating PEP8 to 1.3.3
* matching cinder, glance, etc * made run_tests exclusions match tox Change-Id: I9963245b079535a38a8c9b46917e8d833b62addb
Diffstat (limited to 'run_tests.sh')
-rwxr-xr-xrun_tests.sh23
1 files changed, 3 insertions, 20 deletions
diff --git a/run_tests.sh b/run_tests.sh
index dff6948..782c365 100755
--- a/run_tests.sh
+++ b/run_tests.sh
@@ -78,27 +78,10 @@ function run_pep8 {
srcfiles="keystoneclient tests"
# Just run PEP8 in current environment
#
- # NOTE(sirp): W602 (deprecated 3-arg raise) is being ignored for the
- # following reasons:
- #
- # 1. It's needed to preserve traceback information when re-raising
- # exceptions; this is needed b/c Eventlet will clear exceptions when
- # switching contexts.
- #
- # 2. There doesn't appear to be an alternative, "pep8-tool" compatible way of doing this
- # in Python 2 (in Python 3 `with_traceback` could be used).
- #
- # 3. Can find no corroborating evidence that this is deprecated in Python 2
- # other than what the PEP8 tool claims. It is deprecated in Python 3, so,
- # perhaps the mistake was thinking that the deprecation applied to Python 2
- # as well.
- #
- # NOTE(henry-nash): Added exlusion of the openstack.common dir (as
- # is the case in other projects, since some of the common files
- # don't pass pep8. Clearly we should come back a fix this
- #
+ # NOTE(heckj): E125, E126 are being ignored matching other openstack projects
+ # for pep 1.3.3 due to relatively arbitrary line indentation rulings
${wrapper} pep8 --repeat --show-pep8 --show-source \
- --ignore=E202,W602 --exclude=openstack \
+ --ignore=E125,E126 --exclude=.venv,.tox,dist,doc \
${srcfiles}
}