summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix AttributeError in negotiate_versionstein-eolstein-em2.7.3stable/steinMark Goddard2019-12-042-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Seen in kolla-ansible CI, if ironic inspector starts up before ironic API is properly up, we see the following error: The PXE filter DnsmasqFilter, state=initialized encountered an exception: StrictVersion instance has no attribute 'version'; resetting the filter: AttributeError: StrictVersion instance has no attribute 'version' Example: http://paste.openstack.org/show/756342/ The usual cause of this error is when StrictVersion is initialised with a version of None. This suggests to me that max_ver is None. This leads to an exception being raised that circumvents the client's retry mechanisms. In the particular case of kolla-ansible CI, Ironic API is behind a load balancer, and all backends are down resulting in a 503. The lack of a retry caused ironic inspector to fail on startup. This patch catches the case where we get a 4xx or 5xx return code when checking the version, and raises an error that works with the client's retry mechanisms. Change-Id: Ib62ca3ee4626084e5e9b90e93e4fa97938023457 Story: 2006393 Task: 36266 (cherry picked from commit 0e9bf337f1f6aa41f67df2966dacf9e8e897b7da)
* fix session cert argumentsSteve Baker2019-10-215-9/+13
| | | | | | | | | | | | | | All calls to the deprecated ironic commands are failing because unsupported cert arguments are being used to create the session (cafile, certfile, keyfile) This change switches to using the correct arguments. It is proposed first on stable/stein because the deprecated ironic commands were removed in Train. Change-Id: If0730c0d9c1c3a700cbc6ae16b1c3752d0b681c4 Story: 2006748 Task: 37230
* Fix usage of --owner filter during node listGaëtan Trellu2019-09-253-2/+32
| | | | | | | | | | | | When using --owner filter during node list, the CLI returns this error: list() got an unexpected keyword argument 'owner' Change-Id: Id751336d8d8cb99e62e465e17114e610f619c520 Story: 2006563 Task: 36660 (cherry picked from commit 89088e2aaa8329bbb98380748e5d9716734e0db6)
* Do not try to use /v1/v1 when endpoint_override is used2.7.2Dmitry Tantsur2019-05-173-9/+18
| | | | | | | | | | | | | | | | In one of the places where endpoint_override is used we did not strip the /v1 suffix, resulting in doube /v1/v1 sometimes. This patch also corrects the way we strip this suffix (str.rstrip accepts a set of symbols, not a substring; use regex instead). It remains unclear why the breakage passed the gate initially. I assume it was not on the active code path until some Nova change. Story: #2005723 Task: #31051 Change-Id: I3b25f4fb170aa93159ffa8074dc74fa6f50671b7 (cherry picked from commit 4565af8ccd8aaa35868fae6ae31216c3e57014f3)
* OpenDev Migration PatchOpenDev Sysadmins2019-04-192-2/+2
| | | | | | | | | | | | | | | This commit was bulk generated and pushed by the OpenDev sysadmins as a part of the Git hosting and code review systems migration detailed in these mailing list posts: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html Attempts have been made to correct repository namespaces and hostnames based on simple pattern matching, but it's possible some were updated incorrectly or missed entirely. Please reach out to us via the contact information listed at https://opendev.org/ with any questions you may have.
* Use endpoint_override in version negotiation2.7.1Jason2019-04-163-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | Change [1] introduced the usage of endpoint_filter when deciding which endpoint to use during version negotiation. This requires properly setting interface/region/service_type in order to properly pick the endpoint. But, sometimes (for example in Kolla-ansible), the endpoint url is explicitly defined. In the event of the endpoint being explicitly defined, it should take priority here. It should be noted that even though SessionClient extends from keystoneauth1's adapter.LegacyJsonAdapter, the `request` function within _make_simple_request is being called on the nested Session object, not the Adapter itself. If it was called on the Adapter this problem wouldn't exist, as the `endpoint_override` (or `endpoint`) kwarg passed in to the constructor of the SessionClient would already take precedence. Additionally: Adds a release note to the older branch as this is a fix that needs to be released and is worthy of change visibility in release notes. [1]: I42b66daea1f4397273a3f4eb1638abafb3bb28ce Change-Id: I69dc2c88648ba1d09a9ad3ab3435662e8d1ea6ff Related-Bug: #1818295 (cherry picked from commit 8071d5de57c728ce09d25d04c8c9fe48cd7db42e)
* Run jobs under python2 and python3Iury Gregory Melo Ferreira2019-04-108-12/+57
| | | | | | | | | | | | | | -Switch functional job to run under python3 -Create a functional job to run under python2 -Create a tempest job to run under python2 -Create tox env to run functional tests under python3 -Validate if `USE_PYTHON3` is set to `True` to call the correct env for tests -Remove hardcoded path for client when running functional tests - Update tests failures to work for python2 and python3 Change-Id: I96d418f08c46add8bf61bf8d1b4e45b6083b8d84 (cherry picked from commit 9b881cb973bc2219df90c2b71e2a1d0e18dcd98a)
* Move to zuulv3Iury Gregory Melo Ferreira2019-03-2611-334/+102
| | | | | | | | | | | | | | | | | | | To move ironicclient legacy jobs to zuulv3 the the following changes were necessary: - Change `tox.ini` to pass envrioment variables - Clean `post_test_hook.sh` to avoid legacy variables (`$USER` and `$BASE`), removing `generate_testr_results` function since we only get `testrepository.subunit` in logs and the results of the tests are present in job-output file. - Convert `post_test_hook.sh` and `run_functional.sh` into `playbooks/functional/run.yaml` to run after the setup. Also includes the changes from commit 9cd6ce7eb2d96a8f58a4d00f85b405babf67d28f Change-Id: I6a5b3f82c238083b66bdf6f379092260d367d82d (cherry picked from commit 2c349cc8930897052e66d29a70e1e7f1c4d40d79)
* Replace openstack.org git:// URLs with https://Ian Wienand2019-03-242-4/+4
| | | | | | | | | | | | | | | | | This is a mechanically generated change to replace openstack.org git:// URLs with https:// equivalents. This is in aid of a planned future move of the git hosting infrastructure to a self-hosted instance of gitea (https://gitea.io), which does not support the git wire protocol at this stage. This update should result in no functional change. For more information see the thread at http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html Change-Id: Ia27139cf22ac11803855bd6c52cae8a8a2fbc3ba
* Merge "Update .gitreview for stable/stein" into stable/steinZuul2019-03-211-0/+1
|\
| * Update .gitreview for stable/steinOpenStack Release Bot2019-03-211-0/+1
| | | | | | | | Change-Id: I55be8c175cb9d3c63d2b6f17120dee6680a51473
* | Update UPPER_CONSTRAINTS_FILE for stable/steinOpenStack Release Bot2019-03-211-4/+4
|/ | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/stein branch, tests will continue to use the upper-constraints list on master. Change-Id: I875d54770405597d91c32155e3699e536824a5e6
* Fix allocation testsIury Gregory Melo Ferreira2019-03-211-2/+2
| | | | | | | | | | The exception raised in the Ironic side has changed and the test need to be updated. This commit only cherry picked the test file to unblock the gate in `stable/stein` Change-Id: I55abc999f6f397b171d05fd9e9b39d833ca95e55 (cherry picked from commit 9b881cb973bc2219df90c2b71e2a1d0e18dcd98a)
* Update release notes2.7.0Ruby Loo2019-03-075-17/+14
| | | | | | | | | | | Cleans up the release notes for the next release: - removes the prelude since it was incorrectly added; no release note was needed for the change to help strings - combines two features related to event handling, into one feature - adds the API version to the is-smartnic argument - some grammatical fixes Change-Id: Idd929e419e036de8fbafc22f06ff6c129fc23b16
* Merge "Follow-up to the configdrive change"Zuul2019-03-072-3/+9
|\
| * Follow-up to the configdrive changeDmitry Tantsur2019-03-072-3/+9
| | | | | | | | | | | | | | This is a follow-up to commit 595db83ddcbed667c6d1abdb1e697e3397df3a3b. Change-Id: Ie3d177f77289a25077592a6a0c76d65fa4ce591b Story: #2005083
* | Merge "Accept 'valid_interfaces' in client setup"Zuul2019-03-073-3/+46
|\ \
| * | Accept 'valid_interfaces' in client setupEric Fried2019-03-073-3/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The consumer of ironicclient may be deriving their get_client kwargs from config inherited from ksa, where the 'interface' option has been deprecated in favor of 'valid_interfaces'. To accomodate this, we accept 'valid_interfaces' as a kwarg, giving it precedence over 'interface'. However, we still accept 'interface', as the consumer may be deriving kwargs from a non-conf source (such as an already-created ksa Adapter where 'valid_interfaces' has already been translated to 'interfaces'. Co-Authored-By: guang-yee <guang.yee@suse.com> Change-Id: I3b6fa53005f143d34f03bb1ed71c0aa04b7fce7b
* | | Merge "Support passing a dictionary for configdrive"Zuul2019-03-076-11/+60
|\ \ \ | |/ / |/| / | |/
| * Support passing a dictionary for configdriveDmitry Tantsur2019-03-056-11/+60
| | | | | | | | | | | | | | | | | | | | | | API version 1.56 introduces support for building configdrive on the server side. In this case configdrive is a dictionary, this changes adds support for it. Change-Id: I2b870fc89aa31c13b33f76b14acd6ee959800554 Depends-On: https://review.openstack.org/639050 Story: #2005083 Task: #29841
* | Merge "pass endpoint interface to http client"Zuul2019-03-063-11/+83
|\ \ | |/ |/|
| * pass endpoint interface to http clientGuang Yee2019-03-063-11/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | The 'interface' argument was being ignored so that the HTTP client was always using the public endpoint for Ironic. This fixes it so that the 'interface' argument is taken into consideration. There's also no need to explicitly set the interface to 'publicURL' because that's already the default in keystoneauth. Change-Id: I610836e5038774621690aca88b2aee25670f0262 story: 2005118 task: 29802
* | Deploy templates: client supportMark Goddard2019-03-0115-9/+1484
|/ | | | | | | | | Adds OSC support for the deploy templates API. Change-Id: I0f2f37e840449ee41f747e2a43ed6f53c927094e Depends-On: https://review.openstack.org/631845 Story: 1722275 Task: 28678
* [Trivial] Allocation API: fix incorrect parameter descriptionDmitry Tantsur2019-02-221-1/+1
| | | | | Change-Id: Ic3c46901e3d461b0469188ba9fe179e6030dfb37 Story: #2004341
* Merge "Allocation API: client API and CLI"Zuul2019-02-2216-19/+1520
|\
| * Allocation API: client API and CLIDmitry Tantsur2019-02-1616-19/+1520
| | | | | | | | | | | | | | | | | | Adds the Python API to create/list/view/delete allocations, as well as the OpenStackClient commands. Change-Id: Ib97ee888c4a7b6dfa38934f02372284aa4c781a0 Story: #2004341 Task: #28028
* | [Follow Up] Add 'hostname' to port's local link connectionHamdy Khader2019-02-192-5/+5
| | | | | | | | Change-Id: I59d65e4e9385476bc6f00b7f1c688eaeeb4e3b57
* | Merge "Replace mock.has_calls() with assert_has_calls"Zuul2019-02-196-11/+11
|\ \
| * | Replace mock.has_calls() with assert_has_callsTienDC2019-02-186-11/+11
| | | | | | | | | | | | | | | | | | | | | mock object has no has_calls() method, but assert_has_calls(). This patch fixes some misuses of this method. Change-Id: If2795ebe8d4893d9f99e5e82732757d08cc27237
* | | Merge "Add 'hostname' to port's local link connection"Zuul2019-02-192-5/+14
|\ \ \
| * | | Add 'hostname' to port's local link connectionHamdy Khader2019-02-182-5/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to create Smart NIC port, port argument is-smartnic should be used in addition to local link connection attributes 'port_id' and 'hostname'. Story: #2003346 Change-Id: I95d6e5d53eb6df8468748ed223bf947da5212b6e
* | | | Merge "Add is-smartnic port attribute to port command"Zuul2019-02-197-5/+89
|\ \ \ \ | |/ / /
| * | | Add is-smartnic port attribute to port commandHamdy Khader2019-02-187-5/+89
| | |/ | |/| | | | | | | | | | | | | | | | Support Smart NIC ports creation by using port argument is-smartnic. Story: #2003346 Change-Id: Ie954b1ad8e6987a8a7a349051825a2043ecc54ac
* | | Support node descriptionKaifeng Wang2019-02-185-6/+108
| |/ |/| | | | | | | | | | | | | | | | | Adds support to display and update the description field of a node. Querying nodes which the description field contain the given piece of text is supported as well. Change-Id: I00843140deb759009df2bf0577bd405442e39447 Story: 2003089 Task: 29040
* | Merge "add python 3.7 unit test job"Zuul2019-02-181-0/+1
|\ \ | |/ |/|
| * add python 3.7 unit test jobCorey Bryant2019-02-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | This is a mechanically generated patch to add a unit test job running under Python 3.7. See ML discussion here [1] for context. [1] http://lists.openstack.org/pipermail/openstack-dev/2018-October/135626.html Change-Id: I687eb98f6fe8e36acefba71170b59442d62c3ce3 Story: #2004073 Task: #27420
* | Add Events supportVasyl Saienko2019-02-135-1/+102
|/ | | | | | | | | | | | | Adds support to POST events to the /v1/events API endpoint. Updates LAST_KNOWN_API_VERSION to 51. Co-Authored-By: Harald Jensås <hjensas@redhat.com> Story: 1304673 Task: 22149 Depends-On: https://review.openstack.org/631946 Change-Id: I6bc2d711687350ee3000b6898b68c3d05db62260
* Add node ownerdnuka2019-02-056-5/+102
| | | | | | | | | Adds support to display and update the owner field of a node. Story: 2004916 Task: 29276 Change-Id: If79fea2a33b83ba0930f5df52eaf1e2b41f70eb7
* Support for conductors exposed from APIKaifeng Wang2018-12-1217-3/+908
| | | | | | | | | | Adds conductor resource to the CLI, the support to list and show conductor resource, and filter nodes by conductor field. Story: 1724474 Task: 28066 Change-Id: I9644b9b1bbe2f4f5aa6e80a6bb7ab9b0a4663a6f
* Change openstack-dev to openstack-discusszhulingjie2018-11-181-1/+1
| | | | Change-Id: I37f82ff856999a53f7fa43daccaff115530a9a1f
* Change openstack-dev to openstack-discuss2.6.0sunjia2018-12-031-1/+1
| | | | | | Mailinglists have been updated. Openstack-discuss replaces openstack-dev. Change-Id: I4cb9f81b4be845025ff17835cbde19c54303e722
* Merge "Add Python 3.6 classifier to setup.cfg"Zuul2018-11-291-0/+1
|\
| * Add Python 3.6 classifier to setup.cfgqingszhao2018-11-291-0/+1
| | | | | | | | Change-Id: I6a5f55d65f98c08894e1174f510fcd165dde8d7f
* | Support for protected and protected_reason fieldsDmitry Tantsur2018-11-276-3/+121
|/ | | | | | | Story: #2003869 Task: #27624 Depends-On: https://review.openstack.org/611662 Change-Id: Ib575ace38d1bedce54d0d21517d745ed3204d6f2
* Sort columns in node detailed list alphabeticallyDmitry Tantsur2018-10-242-87/+85
| | | | | | | | | | | Currently we insert new fields in semi-random place. This change sorts the columns alphabetically and enforces this order via unit tests. Also correct the case of the "Automated Clean" heading. Follow-up to commit dfd341585b3a331df240202b2de80834ae1acc9d. Change-Id: Id9909a85a5b8b53751c6e1034b9e1c1b15af3f77
* Merge "Add management of automated_clean field"Zuul2018-10-247-18/+92
|\
| * Add management of automated_clean fieldYolanda Robla2018-10-237-18/+92
| | | | | | | | | | | | | | | | | | Modify api to manage the new automated_clean field. Also bump last known version to 47 Change-Id: I790c762083c2c1b6cbdde4b21434c56bb99236dd Story: #2002161 Task: #23252
* | Update min tox version to 2.0huang.zhiping2018-10-211-1/+1
| | | | | | | | | | | | | | | | The commands used by constraints need at least tox 2.0. Update to reflect reality, which should help with local running of constraints targets. Change-Id: I9e985c4942ad3843b1c0af63d5504c690c836b26
* | Fix a LOG.warning which didn't work properlyKaifeng Wang2018-10-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Found when checking ci logs here: http://logs.openstack.org/41/587041/3/check/ironic-inspector-tempest-dsvm-discovery/7912a3a/logs/screen-ironic-inspector.txt.gz#_Oct_17_16_44_39_477744 It's supposed to be printing missing arguments when constructing an http client. The http client is supposed to be removed ?soon?, so if the fix is not required, please let me know. Change-Id: I2bad387afa2ede56da7164a7bc9a5ac461e78d9c
* | Merge "Modify useful links to project resources in README"Zuul2018-10-051-2/+2
|\ \
View Lorry Controller Status