| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
| |
Change-Id: I1f24c52c2354e7f09f93c6912c7c8b5f554483cc
|
| |
|
|
| |
Change-Id: I6caeb20b0f80a174dab052ab69037793003b4db0
|
| |\ |
|
| | |
| |
| |
| | |
Change-Id: Idd6391979d247c189ef983b43790a91e30dfe8fb
|
| |/
|
|
| |
Change-Id: I422617a5a82f7a4cc4134c5091a0f7fdeb523af0
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The python client should catch 406 Not Acceptable errors when talking to
older versions of the server. If the user did not request a specific
version, the client should negotiate (fall back to) a mutually supported
API version with the server.
If there is no mutually supported version, or if the user specified a
version in which the requested feature is unavailable, the client should
raise an error.
This patch is a partial implementation of the client side of
auto-negotiation. It catches the 406 error and attempts to determine
what version the server is based on the returned headers. It does NOT
actually change what values are sent or returned by the client, aside
from the version headers.
Without this fix, the client fails to connect to any server version
between commit 41595327 (when v1.1 was introduced) and commit 6ecee368
(when v1.6 was introduced), because it is requesting API version 1.6
and not handling the 406 Not Acceptable response.
Note that API server versions prior to commit 32fb6e99 did not return
any version information in the header of a 406 Not Acceptable response.
To work around this, when the client receives a 406 response that does
not contain any version header, the client performs an extra GET request
to the root /v1/ URL to retrieve the supported versions. This allows the
client to work with API services that might be running unreleased
mid-kilo code as well as both stable/juno and the latest kilo code.
Co-Authored-By: Dmitry Tantsur <dtantsur@redhat.com>
Co-Authored-By: John L. Villalovos <john.l.villalovos@intel.com>
Change-Id: Iab6a0814f0db6dd6e7bfc00da28baf8403a6b1db
Blueprint: api-microversions
Partial-bug: #1441170
|
| | |
| |
| |
| |
| |
| |
| | |
Use the latest hacking release and make a few minor modifications
to the code base.
Change-Id: I8ce78a19c1973740e0641bc6022b657e0cb5eb5b
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
A previous commit separated the -n/--node option from the --node_uuid
option on the "port-create" command. This meant that, even when the user
specified --node_uuid, the client required -n/--node as well and would
error out.
This moves these options onto a single CLI argument.
Change-Id: Idcc3217e07f9600f7db18182e9b1bc8b2ae356d3
Closes-bug: #1441374
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Basically copying commit bf6d966756d3745d2facd5ac39444646dcfae6de from
the ironic project.
If your native locale is not en_US and you run tests, some could fail
due to the message translation that happens since the assertion messages
are in en_US (not translated, just hard-coded in the tests).
Note that setting LANG=en_US had no effect.
Change-Id: I812a296ea6c9be303f40346c6db06673fefda8d5
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| | |
Add some simple unittests to make sure that lists are kept into sync
length wise in resource_fields.py
Change-Id: I7d1709d2aeefdb9f3b091c12b803479bac66cc37
|
| |\ \ |
|
| | | |
| | |
| | |
| | | |
Change-Id: Ifd89e5ca604c6ff3423c76243275412df0daa35e
|
| |\ \ \ |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This adds a DEFAULT_VER module variable to the v1 client,
and passes it in the HTTP request by default (ie, when the user has not
specified any other version string).
Change-Id: I526beccce5fd1bcb3df2857032f74d8e1ec6f81d
|
| |\ \ \ \ |
|
| | | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This patch is adding support for generating the config drive as part of
the node-set-provision-state command. If a directory is passed via the
--config-drive parameter, the client will then generate a configdrive
with the contents of that directory and give it to Ironic.
Change-Id: I9163846acb30b34d34953f3b82b797ec944569d9
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
Use importutils from oslo_utils and clean reference from
openstack-common.conf to stop syncing it.
Change-Id: Ia34bde4efe20c1ffee9a7446377ec87693a79b6a
|
| | |/
|/|
| |
| |
| |
| |
| | |
Stop using gettextutils from oslo.incubator and replace with
the graduated library oslo.i18n
Change-Id: I479be348f6e0894ecff5cd93d37ee66648f3ea01
|
| |\ \
| |/
|/| |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add client support for node logical names.
- update help strings to indicate places where Names can be used instead
of UUIDs
- add new "-n" / "--name" parameter to "ironic node-create"
- add Name field to output of both "node-list" and "node-show"
Change-Id: Id16255e9611e95bd37a225ff475268f609726e37
Implements: blueprint logical-names
|
| |/
|
|
|
|
|
|
| |
The commit Ifd97696a22c0c79687a0190ec13f827467286e2e
accidentally undid the change that hyphenated metavar
names. This puts the hyphen back.
Change-Id: I36a4e857f023e0bea1781ab64e883b677d8c2410
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Added the possible actions inspect, manage and provide
to node-set-provision-state. It enables node-show
to show the fields 'inspection_finished_at' and
'inspection_started_at' also.
Implements : blueprint ironic-node-properties-discovery
Change-Id: Ifd97696a22c0c79687a0190ec13f827467286e2e
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Two error strings in ironicclient/shell.py were not translated.
This patch adds _() and also improves the clarity of one of
the messages.
Change-Id: I85a4db59aa486d7f7e1c901ab8b41668edd59acc
|
| |\ \ \ |
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix PEP8 E126,E127,E128 errors, which were the only ones remaining.
Fix PEP8 errors:
E126: continuation line over-indented for hanging indent
E127: continuation line over-indented for visual indent
E128: continuation line under-indented for visual indent
Remove the ignore= entries for flake8 in tox.ini
Change-Id: I919551121d85d2aab528f4fa5ecdb3cfd940557a
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A hanging issue was occurring with httpretty 0.8.8 when testing
openstack/python-ironicclient.
* Blacklist 0.8.8
The underlying issue appears to be tracked in this bug:
https://github.com/gabrielfalcao/HTTPretty/issues/221
Change-Id: I6b63d4b9966c30d7d1d4d287b156f85f0b78f602
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
This moves unit tests to ironicclient/tests/unit and adds a new test
directory at ironicclient/tests/functional. These are meant to be
functional tests that are run against a living cloud (presumably deployed
by devstack as part of a gating job). They depend on a test.conf to exist
that contains admin user credentials for said cloud. This includes a simple
run_functional.sh script that is meant to create that and serve as the entry
point for running the tests from a devstack post_test_hook.
Change-Id: I11570c3e22e4f80b94d0643dca6ed8231217c877
|
| |
|
|
|
|
| |
This is a follow up patch to correct a spelling issue with 155624.
Change-Id: I56df414acb9fcccbd872f902e536a18c5474c1e0
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
python-ironic-client doesn't recognize API micro-version parameter.
Reuse --ironic-api-version to recognize this.
1. The client accepts '1.x' or 'latest' as valid API version and send
corresponding headers to Ironic.
2. If the user does not specify a version, client will not sent any
extra headers to Ironic. It will use the minimum version.
Closes-Bug: #1417430
Change-Id: I1db6e2f4e57d6d47d86f068018f143d0044b7211
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
E121: continuation line under-indented for hanging indent
E122: continuation line missing indentation or outdented
E123: closing bracket does not match indentation of opening bracket's line
E124: closing bracket does not match visual indentation
E125: continuation line with same indent as next logical line
E129: visually indented line with same indent as next logical line
Remove E121,E122,E123,E124,E125, & E129 from the ignore list for flake8
Change-Id: I1b98335dd24086ab0271d25d662ad667ff8c5835
|
| |\ \
| |/
|/| |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
When running the unit tests, this environment variable was being
set: OS_TEST_TIMEOUT=60. However, this variable isn't used, and
there doesn't seem to be a need to use it, so it is removed here.
Change-Id: Iede6fda9f8844ec1769ec988eade9229f55521c6
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
ignore = E12 means ignore E12* errors.
Make it more granular by converting to E121,E122,...,E129
This will make it easier in the future to remove a single ignore and
update the code to resolve the issues.
Change-Id: I88adc53ce78db22f8fe9bcaa0885afef592150e9
|
| |/ /
| |
| |
| | |
Change-Id: Id1287a1ff6d0352159c958993349c632121a2782
|
| | |
| |
| |
| | |
Change-Id: Icf500a63d65528c85fe9ae580d34e14bb5e911f7
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This modifies the CLI so that the argument names, metavar names
and help strings are more consistent.
Argument names that consist of more than one word are now separated
by hyphens instead of underscores. Existing argument names with
underscores are still supported but not displayed via help. The new
argument names are: http_method -> http-method, chassis_uuid -> chassis,
driver_info -> driver-info, node_uuid -> node.
Metavars are only used in the help strings displayed to the user. For
consistency, they are lowercased with hyphens to separate the
words. (Using spaces might make someone think that more than one argument
is needed.)
Help strings were updated. Among other things, they are treated like
sentences with the first letter in upper case, and a period at the end.
Closes-Bug: #1420318
Change-Id: If05d51b09d787ccfbf6f6d35d8e752d42f673601
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This uses the environment variables OS_STDOUT_CAPTURE and
OS_STDERR_CAPTURE to determine whether or not to capture
stdout and stderr (respectively) in the unit tests. These
will appear in the test results for tests that fail.
Capturing will be done if the value is set to one of
(case-insensitive) '1', 't', 'true', 'on', 'y', 'yes'.
Any other value will turn off capturing. The default (via
.testr.conf) is to capture.
Change-Id: I3e6006aa1ed1cf3fad7e55a7201be1c10d165431
Closes-Bug: #1421307
|
| | |
| |
| |
| | |
Change-Id: I130ea99462869d70f0af474ff79e52894191bbc0
|
| |/
|
|
|
|
|
|
|
| |
In the 'ironicclient Python API' page, the credential section has a little
mistake in the example. It's missing "," in the first line and a '}'
in the last. You can see it at
http://docs.openstack.org/developer/python-ironicclient/api_v1.html
Change-Id: I195f46ca7261390b0d6321bc6bdd7e8d0908af40
|
| |
|
|
|
|
|
| |
Rename the --configdrive option of the CLI to make it consistent with
the --config-drive option in the Nova client.
Change-Id: Ic7f4c4b530ba9530bbec21867c6799c53be7eb0e
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The argument name defined must match how it is used in the code. Fix
--config-drive to be --configdrive, to match the code. Fix the metavar
as well while we're here, though it only has an effect on help, docs,
etc.
This wasn't caught by tests because shell arguments are mocked there,
and the gate doesn't use the CLI at all.
Change-Id: Iac1bf91388b79deee971088a53dd86167ca3fb29
Closes-Bug: #1419940
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| | |
Adds a space to separate 'portwhich', and ends the sentence with
a period (because the other help strings do that).
Change-Id: I6756828c87836f1a5c6acc725bf1bdb8dcd58306
|