summaryrefslogtreecommitdiff
path: root/glanceclient
Commit message (Collapse)AuthorAgeFilesLines
* Fix failure to create glance https connection poolHaikel Guemar2015-12-221-3/+4
| | | | | | | | | | | | Due to a typo in an attribute named, an Attribute error is raised causing failure in connection to glance through HTTPS Urllib3 PoolManager class has a connection_pool_kw attribute but not connection_kw Change-Id: Id4d6a5bdcf971d09e80043fd2ab399e208fd931c Closes-Bug: #1479020 (cherry picked from commit c41dcc9f4366429d952cc47853496d58d47b7511)
* Don't get the image before deleting itFlavio Percoco2015-09-231-4/+4
| | | | | | | | | | | | The client currently downloads the image metadata to check if it's deleted or not. This logic belongs to the server and it's already implemented there. Instead of getting the image, send the delete request and catch the 404 error, which is already raised by the server. Change-Id: I1e6ef42340f8e380ff99b9d6ca7ea416e0eebfbc Closes-bug: #1496305 (cherry picked from commit b8a881f5ea89514d715e61b632bc3081a0dde2c6) (cherry picked from commit e82d9df74cbac9accc8a6724c0759760e44bb315)
* Merge "V2: Do not validate image schema when listing" into stable/kiloJenkins2015-08-243-14/+381
|\
| * V2: Do not validate image schema when listingStuart McLaren2015-08-103-14/+381
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously when listing images via v2, the first image of each batch was validated against the v2 schema. This could lead to unpredictable behaviour where a particular image which failed the schema check may or may not be the first of a batch. In some cases it also meant that operation by one user could affect the ability of another other to list images. Change-Id: I22974a3e3d9cbdd254099780752ae45ff2a557af Closes-bug: 1477910 (cherry picked from commit 43769d6cc7266d7c81db31ad58b4fa403c35b611)
* | Ship the default image schema in the clientFlavio Percoco2015-08-122-0/+226
|/ | | | | | | | | | | | | | | | | | | | | | Now that we have stable branches for clients, it's easier to keep track of the current default image's schema in Glance and update it respectively. This patch adds the current image schema, including the schema-properties. One good reason to do this is to be able to react when a running Glance instance is not around to be introspected. It's really unfortunate that things like help text can't be rendered when there image schema is not available in the system. We could keep the schema in a json file but rather than shipping data files with glanceclient we can just have it in the python modules. Conflicts: glanceclient/v2/shell.py Change-Id: I9b8cc1d18d6717ccf991fb8149ab13c06d653ee4 Closes-bug: #1481729 (cherry picked from commit 3949e0e918e2501c4953a7d9beb58511688d84e1)
* Expose 'is_base' schema property attributeAlexander Tivelkov2015-08-031-1/+20
| | | | | | | | | | | | | | | | | | Changeset I49255255 has added an 'is_base' attribute for Image Schema properties, thus allowing to differentiate between base and custom image properties, but the client hasn't make any use of it. This patch adds appropriate attribute to SchemaProperty class and a helper method which allows to validate if the given property is base or not. The added helper method (is_base_property) should not be confused with the existing is_core_property: the latter just checks if the property is known to the schema, regardless of its being base or not. Change-Id: I7c397196dad9ae5494ed2f8f3aacef3fc1ce70d8 Partial-Bug: #1323660 (cherry picked from commit 90407d9e473014c24eeab294192f9d3208f58ea7)
* Merge "Fix Metadef Object update issue with python-glanceclient" into ↵Jenkins2015-07-091-2/+2
|\ | | | | | | stable/kilo
| * Fix Metadef Object update issue with python-glanceclientLakshmi N Sampath2015-07-081-2/+2
| | | | | | | | | | | | | | | | | | Disallowed fields(schema, created_at and updated_at) were getting deleted from Metadef namespace instead of Metadef object. Change-Id: Id80e204c7af1ac6926c66627d290a15c4e6b00d9 Closes-Bug: #1433884 (cherry picked from commit 5d933b0dd59b6340147d1f2307df98c1b66d76f7)
* | Merge "Omit 'locations' as image-create parameter" into stable/kiloJenkins2015-07-091-1/+2
|\ \
| * | Omit 'locations' as image-create parameterFei Long Wang2015-07-081-1/+2
| |/ | | | | | | | | | | | | | | | | | | | | Based on current implementation, locations is reserved attribute, so it should not be a parameter for image create. Closes-Bug: #1399778 Change-Id: Ie51e52157e905fdecf736125be0dac87b1a966ec (cherry picked from commit c73026634cc4bef7e648bb1e82bde29d6b737af2)
* | Merge "Creating task with invalid property crashes in py3" into stable/kiloJenkins2015-07-091-1/+1
|\ \
| * | Creating task with invalid property crashes in py3Kamil Rykowski2015-07-081-1/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | | | Currently when you are trying to set invalid additional property for task using py3 interpreter it will fail, because function `unicode` does not exist in py3. Fix it by replacing `unicode` with `utils.exception_to_str` which is used in other modules already. Change-Id: I5897868f801467a2eaa7585b5f2d578cef358426 Closes-Bug: 1439513 (cherry picked from commit a6234d1c4e0ba8c6bbf822cfe89473436b583acc)
* | Correct help messages for image-update commandAbhishek Talwar2015-07-081-2/+4
|/ | | | | | | | | | | | | | Currently when you are trying to update the location of an image which is not in queued status you will get an error from the Glance API. The help message for --location and --copy-from arguments should be updated to inform the user that it works only for images in queued status. Co-Authored-By: Abhishek Talwar <abhishek.talwar@tcs.com> Co-Authored-By: Kamil Rykowski <kamil.rykowski@intel.com> Change-Id: I82b14ffde3f301d7ffef68e984ba4ad2ae0f8b0f Closes-Bug: #1220809 (cherry picked from commit 6d864ef65c73905370fe9c817fb81b262714bd2d)
* Do not crash on homedir mkdirThomas Goirand2015-05-231-1/+9
| | | | | | | | | | | | Glanceclient is trying to create ~/.glanceclient, and crashes if it can't do that. In some environment (for example, when building the package under Jenkins), writing on $HOME is simply not allowed, and Glanceclient can simply ignore it. This patch allows the mkdir() to fail, which fixes the issue. Closes-Bug: #1446096 Change-Id: Ib3591fb4e54ccd2fe63a1a4815551ac10ef5b961 (cherry picked from commit 1686d6aa535562ae2ea6e04b6dfd59b86c998c8a)
* Fix client when using no ssl compressionStuart McLaren2015-04-161-0/+7
| | | | | | | | | | | | Since the release of the 0.16.1 client, using the 'no ssl compression' option, whether on the command line, or via the library -- Nova does this by default -- a stack trace was generated. Closes-bug: 1442664 Related-bug: 1357430 Change-Id: I2b8ddcb0a7ae3cfccdfc20d3ba476f3b4f4ec32d (cherry picked from commit c698b4e3227b4767f042e435423fcc307d7f6d5c)
* Updated help for v2 member-update apiYamini Sardana2015-03-172-1/+8
| | | | | | | | | | | help message for v2 glance member-update api now displays the Valid Values of member status variable. The valid values are: pending, accepted, rejected Change-Id: Ibe6f55c933668451b407ed9a19c520c3fbf1912a Closes-bug: #1420707
* Merge "Extend images CLI v2 with new sorting syntax"Jenkins2015-03-162-19/+53
|\
| * Extend images CLI v2 with new sorting syntaxMike Fedosin2015-03-162-19/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This code enables new syntax for sorting output with multiple keys and directions based on API Working group sorting guidelines. It's a client code to consume API modified in change Ie4ccfefa0492a3ac94cc7e22201f2f2be5c1cdbb Example: glance --os-image-api-version 2 --sort name:desc,size:asc Implements-blueprint: glance-sorting-enhancements DocImpact Depends-On: Ie4ccfefa0492a3ac94cc7e22201f2f2be5c1cdbb Change-Id: I36a9fa9f0508fea1235de2ac3a0d6a093e1af635
* | Merge "Add the ability to specify the sort dir for each key"Jenkins2015-03-162-12/+26
|\ \ | |/
| * Add the ability to specify the sort dir for each keyMike Fedosin2015-03-162-12/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds client code to consume API modified in change Ib43b53abfba7cb5789d916a014376cf38fc5245b Extends CLI for v2 with multiple sort dirs Example: glance --os-image-api-version 2 image-list \ --sort-key name --sort-dir asc --sort-key size --sort-dir desc Implements-blueprint: glance-sorting-enhancements DocImpact Depends-On: Ib43b53abfba7cb5789d916a014376cf38fc5245b Change-Id: Ia20716f3c75299f796879299da317b2e81496088
* | Merge "Adds the ability to sort images with multiple keys"Jenkins2015-03-162-0/+27
|\ \ | |/
| * Adds the ability to sort images with multiple keysMike Fedosin2015-03-132-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds client code to consume API modified in change Ib7a6aeb2df3bc5d23fe8e070290b5bfcab00c0f5 Extends CLI for v2 with multiple sort keys Example: glance --os-image-api-version 2 image-list --sort-key name --sort-key size Implements-blueprint: glance-sorting-enhancements Change-Id: If79779a4c52c8dc5c4f39192d3d247335a76ba24 DocImpact Closes-Bug: 1221274
* | Merge "Apply expected patch format when updating tags in v2.images"Jenkins2015-03-161-2/+20
|\ \
| * | Apply expected patch format when updating tags in v2.imagesSteve Lewis2015-03-121-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, glanceclient.v2.update builds a patch request that does not match glance API. This patch overrides the default behaviour to customize the patch request with the right format for the API. Co-Authored-By: Steve Lewis <steve.lewis@rackspace.com> Fixes bug 1306774 Change-Id: If0739ac285da1e741bfa40b6c719331a5ce49319
* | | Import sys moduleJimmy McCrory2015-03-141-0/+1
| |/ |/| | | | | | | | | | | This module is required by the _is_image_data_provided function. Change-Id: I78265209a2f80aaf61bbe25d69e79c939182516c Closes-Bug: 1432249
* | Merge "Fix leaking sockets after v1 list operation"Jenkins2015-03-111-54/+83
|\ \
| * | Fix leaking sockets after v1 list operationLouis Taylor2015-03-041-54/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since the move to using the requests library, v1 list operations keep the connection open to the glance server. This is normally closed by the garbage collector if it is not explicitly closed, however the paginate function used by the list method had a circular reference preventing it from ever being collected during the lifecycle of a service consuming glanceclient. This is problematic, since it causes long running nova processes to run out of file descriptors for new connections. This patch makes paginate() non-recursive, which allows the connection to be freed. Change-Id: I16a7b02f2b10e506e91719712cf34ef0aea1afc0 Closes-Bug: 1423939
* | | Merge "Fix minor typo in version error message"Jenkins2015-03-111-1/+1
|\ \ \ | |_|/ |/| |
| * | Fix minor typo in version error messageStuart McLaren2014-11-251-1/+1
| | | | | | | | | | | | | | | Change-Id: Ic6441c6952f89fc41c7f41b1baae3f601c0fc87e Closes-bug: 1396087
* | | Merge "Remove duplicate 'a' in the help string of --os-image-url"Jenkins2015-03-101-1/+1
|\ \ \
| * | | Remove duplicate 'a' in the help string of --os-image-urlChristian Berendt2015-01-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of 'url contains a a version number' it should be 'url contains a version number'. Change-Id: I7caa350954a37e2af90c656ceb698d9ab772e463
* | | | Merge "v2: read limit for list from --limit in shell"Jenkins2015-03-061-1/+1
|\ \ \ \
| * | | | v2: read limit for list from --limit in shellLouis Taylor2015-03-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously this was read from the --page-size argument, which lead to incorrect behaviour. Change-Id: I08ecda95eca0ff524e28a1d5371ce6c73dfc548e Closes-Bug: #1429088
* | | | | Merge "Fix leaking sockets after v2 list operation"Jenkins2015-03-061-34/+34
|\ \ \ \ \ | |/ / / /
| * | | | Fix leaking sockets after v2 list operationLouis Taylor2015-03-051-34/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the same problem with leaking file descriptors after the port to requests I16a7b02f2b10e506e91719712cf34ef0aea1afc0 does, but for the v2 api client. The paginate function in the list method has been refactored from a recursive generator to a non-recursive generator, which avoids issues with garbage collection holding the socket open. Change-Id: Iaa7a421e8c1acafb7b23bb3f55e50b9d2a9d030a Closes-Bug: #1428797
* | | | | Merge "v2: Allow upload from stdin on image-create"Jenkins2015-03-061-2/+3
|\ \ \ \ \
| * | | | | v2: Allow upload from stdin on image-createStuart McLaren2015-01-071-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For example: $ glance --os-image-api-version 2 image-create < /tmp/data This is consistent with v1. DocImpact Closes-bug: 1408033 Change-Id: Ifed4ece9e4e02a46d80b49a8e4fc372f1a304241
* | | | | | Merge "Fix v2 image create --file documentation"Jenkins2015-03-061-3/+2
|\ \ \ \ \ \ | |/ / / / / | | / / / / | |/ / / / |/| | | |
| * | | | Fix v2 image create --file documentationStuart McLaren2015-01-061-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Help for 'v2 image create --file' should refer to upload, not download. DocImpact Change-Id: I2ae00e3242fb10001e216cde93fdf9c6f18ad13e Closes-bug: 1408028
* | | | | Merge "removed excessive call to os.path.exists"Jenkins2015-03-051-3/+3
|\ \ \ \ \
| * | | | | removed excessive call to os.path.existsKirill2015-03-031-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | os.path.isfile checks for existance anyway so there is no point in checking both isfile and exists Change-Id: Idbc2d22a807d5413db6e27ff0f6b5a87a5af8fa3
* | | | | | Merge "Show error on trying to upload to non-queued image"Jenkins2015-03-041-0/+18
|\ \ \ \ \ \
| * | | | | | Show error on trying to upload to non-queued imageLouis Taylor2015-02-191-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, attempting to upload data to an image which has a status which is not 'queued' would appear to succeed, when the data has actually never been sent to the glance server. To the user, it appeared that their request was successful. This patch adds a check for incoming image data on the 'image-update' command, and exits with an error if the specified image does not have the status 'queued'. Examples: $ cat os.img | glance image-update d50b0236-b27c-412a-91b9-18ceafa9cc5a Unable to upload image data to an image which is active. $ glance image-update --file os.img d50b0236-b27c-412a-91b9-18ceafa9cc5a Unable to upload image data to an image which is killed. Change-Id: I91bbd7f86d5851a5e35946c711dba1932283ed79 Closes-Bug: #1395084
* | | | | | | Merge "Unify using six.moves.range rename everywhere"Jenkins2015-03-041-0/+2
|\ \ \ \ \ \ \
| * | | | | | | Unify using six.moves.range rename everywhereErno Kuvaja2015-02-251-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mainly to improve consistency, use range() from six.moves renames across glance. Behaves consistently like py2 xrange() and py3 range(). Change-Id: I7c573a3a9775f454b98d25f2a14f8e9f5f4ac432
* | | | | | | | Merge "https: Prevent leaking sockets for some operations"Jenkins2015-03-041-56/+77
|\ \ \ \ \ \ \ \
| * | | | | | | | https: Prevent leaking sockets for some operationsStuart McLaren2015-02-181-56/+77
| | |/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Other OpenStack services which instantiate a 'https' glanceclient using ssl_compression=False and insecure=False (eg Nova, Cinder) are leaking sockets due to glanceclient not closing the connection to the Glance server. This could happen for a sub-set of calls, eg 'show', 'delete', 'update'. netstat -nopd would show the sockets would hang around forever: ... 127.0.0.1:9292 ESTABLISHED 9552/python off (0.00/0/0) urllib's ConnectionPool relies on the garbage collector to tear down sockets which are no longer in use. The 'verify_callback' function used to validate SSL certs was holding a reference to the VerifiedHTTPSConnection instance which prevented the sockets being torn down. Change-Id: Idb3e68151c48ed623ab89d05d88ea48465429838 Closes-bug: 1423165
* | | | | | | | Merge "Remove graduated gettextutils from openstack/common"Jenkins2015-03-033-449/+36
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | |
| * | | | | | | Remove graduated gettextutils from openstack/commonIan Cordasco2015-02-033-449/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use oslo.i18n package and handle different versions properly in glanceclient._i18n. The oslo namespace is being deprecated so imports will be oslo_i18n going forward. For older versions of oslo.i18n though, we will still be able to import i18n from oslo. Change-Id: Id56d34ccf447dc6f7becafb74d6a30e8a1642030
* | | | | | | | Merge "Strip json and html from error messages"Jenkins2015-03-012-15/+40
|\ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ |/| | | | | | |
View Lorry Controller Status