summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* 1.0.0 release notes1.0.0Erno Kuvaja2015-08-271-0/+52
| | | | Change-Id: I2cc3ba8d0064d6f424f16be94deaecdf1c5c8332
* Merge "Remove custom SSL compression handling"Jenkins2015-08-267-328/+122
|\
| * Remove custom SSL compression handlingStuart McLaren2015-08-267-328/+122
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Custom SSL handling was introduced because disabling SSL layer compression provided an approximately five fold performance increase in some cases. Without SSL layer compression disabled the image transfer would be CPU bound -- with the CPU performing the DEFLATE algorithm. This would typically limit image transfers to < 20 MB/s. When --no-ssl-compression was specified the client would not negotiate any compression algorithm during the SSL handshake with the server which would remove the CPU bottleneck and transfers could approach wire speed. In order to support '--no-ssl-compression' two totally separate code paths exist depending on whether this is True or False. When SSL compression is disabled, rather than using the standard 'requests' library, we enter some custom code based on pyopenssl and httplib in order to disable compression. This patch/spec proposes removing the custom code because: * It is a burden to maintain Eg adding new code such as keystone session support is more complicated * It can introduce additional failure modes We have seen some bugs related to the 'custom' certificate checking * Newer Operating Systems disable SSL for us. Eg. While Debian 7 defaulted to compression 'on', Debian 8 has compression 'off'. This makes both servers and client less likely to have compression enabled. * Newer combinations of 'requests' and 'python' do this for us Requests disables compression when backed by a version of python which supports it (>= 2.7.9). This makes clients more likely to disable compression out-of-the-box. * It is (in principle) possible to do this on older versions too If pyopenssl, ndg-httpsclient and pyasn1 are installed on older operating system/python combinations, the requests library should disable SSL compression on the client side. * Systems that have SSL compression enabled may be vulnerable to the CRIME (https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2012-4929) attack. Installations which are security conscious should be running the Glance server with SSL disabled. Full Spec: https://review.openstack.org/#/c/187674 Blueprint: remove-custom-client-ssl-handling Change-Id: I7e7761fc91b0d6da03939374eeedd809534f6edf
* | Merge "Add more information show in v2"Jenkins2015-08-261-1/+2
|\ \ | |/ |/|
| * Add more information show in v2wangxiyuan2015-08-191-1/+2
| | | | | | | | | | | | | | | | | | In v2, it's only show Id and Name. When use --verbose, although added owner and status, it's still lack of Disk-format,Container-format and Size. Change-Id: I26b4b7bd3a3f6dbf82ca73c32dd94c56e8e173a1 Closes-bug:#1486329
* | Merge "V2: Do not validate image schema when listing"Jenkins2015-08-203-14/+381
|\ \ | |/ |/|
| * V2: Do not validate image schema when listingStuart McLaren2015-08-103-14/+381
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously when listing images via v2, the first image of each batch was validated against the v2 schema. This could lead to unpredictable behaviour where a particular image which failed the schema check may or may not be the first of a batch. In some cases it also meant that operation by one user could affect the ability of another other to list images. Change-Id: I22974a3e3d9cbdd254099780752ae45ff2a557af Closes-bug: 1477910
* | Require disk and container format on image-createGorka Eguileor2015-08-145-2/+198
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently glanceclient doesn't enforce disk-format or container-format presence in the command line on image-create when providing image data (with --file, --location, --copy-from), which means that the POST request is made with the whole image and error is reported by Glance API. This post enforces presence of those arguments when image data is provided so we can get the error quicker and avoid sending unnecessary data over the network. Change-Id: I5914fa9cfef190a028b374005adbf3a804b1b677 Closes-Bug: #1309272
* | Merge "Use API v2 as default"Jenkins2015-08-133-29/+107
|\ \
| * | Use API v2 as defaultFei Long Wang2015-08-113-29/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now we have claimed v2 is the current API version of Glance, we should change the Glance client as well to be consistent with Glance server. DocImpact Change-Id: I09c9e409d149e2d797785591183e06c13229b7f7
* | | Merge "Ship the default image schema in the client"Jenkins2015-08-123-0/+233
|\ \ \ | |/ / |/| |
| * | Ship the default image schema in the clientFlavio Percoco2015-08-123-0/+233
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that we have stable branches for clients, it's easier to keep track of the current default image's schema in Glance and update it respectively. This patch adds the current image schema, including the schema-properties. One good reason to do this is to be able to react when a running Glance instance is not around to be introspected. It's really unfortunate that things like help text can't be rendered when there image schema is not available in the system. We could keep the schema in a json file but rather than shipping data files with glanceclient we can just have it in the python modules. Change-Id: I9b8cc1d18d6717ccf991fb8149ab13c06d653ee4 Closes-bug: #1481729
* | | Updated from global requirementsOpenStack Proposal Bot2015-08-103-7/+6
| | | | | | | | | | | | Change-Id: I47c54849f6687927ac1eb25081907438c7ea2b56
* | | Merge "Support for Metadata Definition Catalog for Tags"Jenkins2015-08-065-0/+508
|\ \ \ | |/ / |/| |
| * | Support for Metadata Definition Catalog for TagsWayne Okuma2015-07-165-0/+508
| | | | | | | | | | | | | | | | | | | | | | | | | | | This set provides API and shell commands support for: - CRUD on metadef_tags; Change-Id: I09bdf43edee6fff615d223f1a6df7c15a1e40565 Implements: blueprint metadefs-tags-cli DocImpact
* | | Merge "Add unicode support for properties values in v2 shell"Jenkins2015-08-032-3/+4
|\ \ \
| * | | Add unicode support for properties values in v2 shellDarja Shakhray2015-08-032-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | This code allows to set unicode values to v2 properties. Change-Id: I5f9c29a3e458808dd95375c7557dfce0c4f09038 Closes-bug: #1475769
* | | | Merge "Fix failure to create glance https connection pool"Jenkins2015-07-292-3/+20
|\ \ \ \ | |/ / / |/| | |
| * | | Fix failure to create glance https connection poolHaikel Guemar2015-07-282-3/+20
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Due to a typo in an attribute named, an Attribute error is raised causing failure in connection to glance through HTTPS Urllib3 PoolManager class has a connection_pool_kw attribute but not connection_kw Closes-Bug: #1479020 Change-Id: Id4d6a5bdcf971d09e80043fd2ab399e208fd931c
* | | Enable flake8 checksDarja Shakhray2015-07-2130-163/+118
|/ / | | | | | | | | | | | | | | | | | | | | | | This commit enables new flake8 checks: * E265 block comment should start with '# ' * H405 multi line docstring summary not separated with an empty line * E123 closing bracket does not match indentation of opening bracket's line * H238 old style class declaration, use new style (inherit from `object`) * E128 continuation line under-indented for visual indent and makes related changes in the code. Change-Id: Ie993afc930f6b74d7a990bcaa9fc0e9f5ba1585c
* | Extend unittests coverage for v2 tasks moduleKamil Rykowski2015-07-201-14/+97
| | | | | | | | | | | | | | | | | | Add new tests for v2 tasks module to cover following cases: - getting list of tasks using the marker - getting list of tasks using sort_key & sort_dir keys Change-Id: Ic126999ebb16e51cc472fe8f86dfe1fced0bc016 Closes-Bug: 1433637
* | Merge "Fix exception message in Http.py"Jenkins2015-07-172-2/+18
|\ \
| * | Fix exception message in Http.pywangxiyuan2015-07-142-2/+18
| |/ | | | | | | | | | | | | In common.http.py, the exception RequestTimeout has wrong message.This patch fixed it. Change-Id: Ie8ff188b9c82ce424cb8177278f36e4d1275b306
* | Merge "Add .eggs/* to .gitignore"Jenkins2015-07-161-0/+1
|\ \ | |/ |/|
| * Add .eggs/* to .gitignoreErno Kuvaja2015-07-091-0/+1
| | | | | | | | Change-Id: I4657733071dfed6485411406427901efeffb348c
* | Merge "Fix an issue with broken test on ci"Jenkins2015-07-132-28/+43
|\ \
| * | Fix an issue with broken test on ciMike Fedosin2015-07-132-28/+43
| |/ | | | | | | | | | | | | | | | | Several tests with cert verification are broken. This code fixes it by setting right imports. Also some typos are fixed too. Change-Id: Ie014f90714c3dabee65459fd704dd11b1770c7de Closed-Bug: #1472234
* | Remove usage of assert_called_once on Mock objectsrico.lin2015-07-102-2/+3
| | | | | | | | | | | | | | | | | | mock 1.1.0 was released on 10 July 2015 which prevents users from using non-existent assertion methods. This broke the test in the diff. Co-Authored-By: Ian Cordasco <graffatcolmingov@gmail.com> Closes-Bug: #1473454 Change-Id: I162b76bbd7d96c96787a8dd8f9642ca1c80c596a
* | Updated from global requirementsOpenStack Proposal Bot2015-06-301-2/+2
|/ | | | Change-Id: I61ff841e2224fbd127e695bb11ca884f541f76a8
* Merge "Do not fall back to namespaced oslo.i18n"Jenkins2015-06-301-4/+1
|\
| * Do not fall back to namespaced oslo.i18nIan Cordasco2015-06-241-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Oslo libraries have moved all of their code out of the 'oslo' namespace package into per-library packages. The namespace package was retained during kilo for backwards compatibility, but will be removed by the liberty-2 milestone. This change removes the use of the namespace package, replacing it with the new package names. The patches in the libraries will be put on hold until application patches have landed, or L2, whichever comes first. At that point, new versions of the libraries without namespace packages will be released as a major version update. Please merge this patch, or an equivalent, before L2 to avoid problems with those library releases. Blueprint: remove-namespace-packages https://blueprints.launchpad.net/oslo-incubator/+spec/remove-namespace-packages Change-Id: I831eb6b773d80edc233fd6f6e565ca6f24b65210
* | Merge "Account for dictionary order in test_shell.py"Jenkins2015-06-301-5/+12
|\ \
| * | Account for dictionary order in test_shell.pyCorey Bryant2015-06-291-5/+12
| |/ | | | | | | | | Change-Id: Id15f3d642e8fcbd663f12b32f52b6014e32574a5 Closes-Bug: 1468485
* | Updated from global requirementsOpenStack Proposal Bot2015-06-223-11/+10
|/ | | | Change-Id: I19b9915bedacec60fc584a7437a9b46a80a26bdc
* Merge "Add v2 support for the marker attribute"Jenkins2015-06-222-0/+9
|\
| * Add v2 support for the marker attributeBrad Pokorny2015-06-192-0/+9
| | | | | | | | | | | | | | | | | | | | The v2 Glance client implementation ignores the marker attribute if it's passed to the client as part of the kwargs. Include support for the attribute, as the v1 client supports it and it makes it easier to work with the Glance client. Change-Id: Ifaa59129bc4178212b890ea591673cb154e0f110 Closes-bug: 1465373
* | Merge "Import only modules and update tox.ini"Jenkins2015-06-1810-46/+50
|\ \
| * | Import only modules and update tox.iniCindy Pallares2015-06-1710-46/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | As stated in the OpenStack Hacking Guidelines, it is prefered that only modules should be imported. Also updated tox.ini to ignore opestack/common among others. Change-Id: I2f0a603c31052eadee581c11880c0ec6bd392829
* | | Updated from global requirementsOpenStack Proposal Bot2015-06-161-1/+1
|/ / | | | | | | Change-Id: I9b3c158fecbbd36587cb0a1e402bdf1598af2b69
* | Merge "Close iterables at the end of iteration"Jenkins2015-06-162-1/+18
|\ \ | |/ |/|
| * Close iterables at the end of iterationRobert Collins2015-06-112-1/+18
| | | | | | | | | | | | | | | | | | | | | | This fixes a bug where if iteration is interrupted, we're stuck until the iterable is garbage collected, which can be a very long time (e.g. if the iterable is held in an exception stack frame). Co-authored-by: Stuart McLaren <stuart.mclaren@hp.com> Change-Id: Ibe9990e8c337c117a978b1cd8ec388c4bc6d3b4b Closes-bug: 1461678
* | Merge "Add parameter 'changes-since' for image-list of v1"Jenkins2015-06-152-1/+64
|\ \
| * | Add parameter 'changes-since' for image-list of v1Fei Long Wang2015-05-062-1/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now Glance /images/detail API of v1 supports parameter 'changes-since' to query deleted images. But it's missed in client. This patch will add the parameter. Related-Bug: #1432701 Change-Id: Id38e3a78b4b2ef680ea04d35e32beb4b9c8efa00
* | | Merge "cleanup openstack-common.conf and sync updated files"Jenkins2015-06-144-5/+4
|\ \ \
| * | | cleanup openstack-common.conf and sync updated filesDavanum Srinivas2015-06-104-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | periodic updates of latest from oslo-incubator. please note that files no longer on oslo-incubator mean that they have been moved to oslo.* libraries. So there's more work needed to remove these files and switch to appropriate libraries Change-Id: Icd71b4b1ea9f1df526614a29277f25a7ab47b721
* | | | Make glanceclient accept a session objectJamie Lennox2015-06-117-97/+209
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | To make this work we create a different HTTPClient that extends the basic keystoneclient Adapter. The Adapter is a standard set of parameters that all clients should know how to use like region_name and user_agent. We extend this with the glance specific response manipulation like loading and sending iterables. Implements: bp session-objects Change-Id: Ie8eb4bbf7d1a037099a6d4b272cab70525fbfc85
* | | Add release notes for 0.19.00.19.0Nikhil Komawar2015-06-101-0/+14
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes included in this release: $ git log 0.18.0..HEAD --no-merges --oneline dfa98ab Updated from global requirements 6cb26fc Include owner and status option in v2 image list 5d933b0 Fix Metadef Object update issue with python-glanceclient 9f5c581 Fix functional tests in gate 1686d6a Do not crash on homedir mkdir 1f89beb Improve import related error handling 583adc3 Check image-download for redirection 9c172fb Add some basic CLI functional tests bf413a6 Use assertIn instead of assertTrue in tests 6431fae Unorder compare in tests 5fa71aa Add release notes for 0.18.0 6d31116 Update README to work with release tools 71d9783 Create functional test base f2a8a52 Move unit tests to standard directory f931a20 Fixed doc example Co-Authored-By: Louis Taylor <louis@kragniz.eu> Change-Id: Ied7f5b4f298e2bbf4a5486eb6b7dbcea2d0e74d3
* | Updated from global requirementsLouis Taylor2015-06-053-6/+15
| | | | | | | | | | | | | | | | | | | | Also update hacking to hacking>=0.10.0,<0.11 to get around breakage with pbr dependency. Change-Id: Ic5e2d8df6993397ee4d1b087d96cc6667bd72acc
* | Merge "Improve import related error handling"Jenkins2015-05-262-12/+80
|\ \
| * | Improve import related error handlingStuart McLaren2015-05-082-12/+80
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If there was a problem importing a library we would incorrectly raise an unsupported version error: $ glance --os-image-api-version 1 image-list "1" is not a supported API version. Example values are "1" or "2". We should change this to provide information on the failed import, eg: $ glance --os-image-api-version 1 image-list No module named badimport We also now raise the full stacktrace in this case if '--debug' is passed on the command line. Change-Id: I1c687ae6c5da239090b0b7a4a855b3271a9076da Related-bug: 1402632