Fix Resource.__eq__ mismatch semantics of object equal

The __eq__ of apiclient.base.Resource will return True,
if the two objects have same id, even if they have different
other attributes value. The behavior is weird and don't
match the semantics of object equal. The objects that have
different value should be different objects.
Fix this issue and add some test cases in this patch.

Change-Id: I24ba39bf90d727116f256de46241746520efbfee
Closes-Bug: #1499369

1 files changed, 8 insertions, 2 deletions

diff --git a/glanceclient/tests/unit/test_base.py b/glanceclient/tests/unit/test_base.py
index 4a97de8..ddbc3d7 100644
--- a/glanceclient/tests/unit/test_base.py
+++ b/glanceclient/tests/unit/test_base.py
@@ -32,10 +32,16 @@ class TestBase(testtools.TestCase):
             id = 4
         self.assertEqual(4, base.getid(TmpObject))
 
-    def test_two_resources_with_same_id_are_equal(self):
-        # Two resources of the same type with the same id: equal
+    def test_two_resources_with_same_id_are_not_equal(self):
+        # Two resources with same ID: never equal if their info is not equal
         r1 = base.Resource(None, {'id': 1, 'name': 'hi'})
         r2 = base.Resource(None, {'id': 1, 'name': 'hello'})
+        self.assertNotEqual(r1, r2)
+
+    def test_two_resources_with_same_id_and_info_are_equal(self):
+        # Two resources with same ID: equal if their info is equal
+        r1 = base.Resource(None, {'id': 1, 'name': 'hello'})
+        r2 = base.Resource(None, {'id': 1, 'name': 'hello'})
         self.assertEqual(r1, r2)
 
     def test_two_resources_with_eq_info_are_equal(self):