diff options
| author | liuqing <jing.liuqing@99cloud.net> | 2014-07-01 16:34:16 +0800 |
|---|---|---|
| committer | liuqing <jing.liuqing@99cloud.net> | 2014-07-03 15:10:54 +0800 |
| commit | 9b9f3befeda88c84e9fae6f307615656f4eed9bd (patch) | |
| tree | 16d0a123c3e75d3960728c4b987997a16fc399fe | |
| parent | 1c46c769e874a448275060651895f194249e36e7 (diff) | |
| download | python-glanceclient-9b9f3befeda88c84e9fae6f307615656f4eed9bd.tar.gz | |
Use immutable arg rather mutable arg
Passing mutable objects as default args is a known Python pitfall.
We'd better avoid this. This commit changes mutable default args with
None.
Change-Id: I78323383c8b6a9a516a2a217303124870822418b
| -rw-r--r-- | glanceclient/common/utils.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/glanceclient/common/utils.py b/glanceclient/common/utils.py index 6cdc364..58c0ded 100644 --- a/glanceclient/common/utils.py +++ b/glanceclient/common/utils.py @@ -45,7 +45,8 @@ def arg(*args, **kwargs): return _decorator -def schema_args(schema_getter, omit=[]): +def schema_args(schema_getter, omit=None): + omit = omit or [] typemap = { 'string': str, 'integer': int, @@ -104,7 +105,8 @@ def pretty_choice_list(l): return ', '.join("'%s'" % i for i in l) -def print_list(objs, fields, formatters={}): +def print_list(objs, fields, formatters=None): + formatters = formatters or {} pt = prettytable.PrettyTable([f for f in fields], caching=False) pt.align = 'l' |